From: Dave Brolley <brolley@redhat.com>
To: Michael Snyder <msnyder@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [ob] frv/sim testsuite tweak
Date: Thu, 11 Sep 2003 18:46:00 -0000 [thread overview]
Message-ID: <3F60C34F.8000406@redhat.com> (raw)
In-Reply-To: <3F60C1AF.7070500@redhat.com>
Michael, please revert this change. This test uses several different
notations to reference the lcr register and one of them is 'lcr'. As you
can see spr[273] is tested a few lines later.
Thanks,
Dave
Michael Snyder wrote:
> Inferring the intent from the comments, this test is
> redundant without this change.
>
>------------------------------------------------------------------------
>
>2003-09-11 Michael Snyder <msnyder@redhat.com>
>
> * sim/testsuite/sim/frv/movgs.cgs: Change lcr to spr[273],
> which according to the comments seems to be the intent.
>
>Index: sim/frv/movgs.cgs
>===================================================================
>RCS file: /cvs/src/src/sim/testsuite/sim/frv/movgs.cgs,v
>retrieving revision 1.1
>diff -p -r1.1 movgs.cgs
>*** sim/frv/movgs.cgs 29 Aug 2003 16:41:31 -0000 1.1
>--- sim/frv/movgs.cgs 11 Sep 2003 18:37:54 -0000
>*************** movgs:
>*** 15,21 ****
>
> ; try alternate names for lcr
> and_spr_immed 0,273
>! movgs gr8,lcr ; lcr is spr number 273
> test_gr_limmed 0xdead,0xbeef,gr8
> test_spr_limmed 0xdead,0xbeef,spr[273]
>
>--- 15,21 ----
>
> ; try alternate names for lcr
> and_spr_immed 0,273
>! movgs gr8,spr[273] ; lcr is spr number 273
> test_gr_limmed 0xdead,0xbeef,gr8
> test_spr_limmed 0xdead,0xbeef,spr[273]
>
>
>
next prev parent reply other threads:[~2003-09-11 18:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-11 18:40 Michael Snyder
2003-09-11 18:46 ` Dave Brolley [this message]
2003-09-11 19:10 ` Michael Snyder
2003-09-11 19:36 ` Dave Brolley
2003-09-11 19:52 ` Michael Snyder
2003-09-12 16:14 ` Dave Brolley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3F60C34F.8000406@redhat.com \
--to=brolley@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox