Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Adam Fedor <fedor@doc.com>, Daniel Jacobowitz <drow@mvista.com>
Cc: GDB Patches <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] Compile objc-lang.c, objc-exp.tab.c [1/5]
Date: Mon, 31 Mar 2003 22:39:00 -0000	[thread overview]
Message-ID: <3E88C39F.2030605@redhat.com> (raw)
In-Reply-To: <3E87A68C.6090301@doc.com>

> 
> 
> Daniel Jacobowitz wrote:
> On Thu, Mar 20, 2003 at 05:13:40PM -0500, Andrew Cagney wrote:
> 
> 
> Would it be possible to make the cplus_demangle() method part of the language vector?  That way code like the patch below could be reduced to:
> 
>     /* Return demangled language symbol, or NULL.  */
>     language_demangle (current_language, arg);
> 
> This would in turn allow Adam to just add an equivalent objc_demangle() method to the objc language vector, and hence eliminate the need to always link in objc-lang.c.
> 
> As well as then?  The places where objc is adding calls to the demangler the language is known.
> 
> 
> My gut reaction is that it's just clutter until we decide how to solve
> the problem of not knowing demanglings.  But it'll do for now.  I'd
> like a comment along the lines of:
> 
> /* FIXME: sometimes the demangler is invoked when we don't know the
>    language, so we can't use this everywhere.  */
> 
> 
> Here's my crack at doing this

Looks right to me.  Daniel, see any C++ problems?

> 2003-03-30  Adam Fedor  <fedor@gnu.org>
> 
> 	* Makefile.in (c_lang.c, jv_lang.c): Add $(demangle_h).

I think you ment c-lang.o, jv-lang.o.

Andrew



  reply	other threads:[~2003-03-31 22:39 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-03 22:06 Adam Fedor
2003-02-19 19:02 ` Elena Zannoni
2003-02-19 20:27   ` Adam Fedor
2003-02-19 21:11     ` Elena Zannoni
2003-03-20 21:27 ` Andrew Cagney
2003-03-20 21:39   ` Daniel Jacobowitz
2003-03-20 22:13     ` Andrew Cagney
2003-03-20 22:19       ` Daniel Jacobowitz
2003-03-31  2:23         ` Adam Fedor
2003-03-31 22:39           ` Andrew Cagney [this message]
2003-03-31 22:53           ` David Carlton
2003-03-31 23:03             ` David Carlton
2003-03-31 23:15             ` Adam Fedor
2003-04-01  0:31               ` Andrew Cagney
2003-04-01  0:45                 ` David Carlton
2003-04-01  4:09                 ` Adam Fedor
2003-04-01 21:31                   ` David Carlton
2003-04-01 21:38                   ` Daniel Jacobowitz
2003-03-20 22:22     ` David Ayers
2003-03-20 21:35 ` Andrew Cagney
2003-03-24 17:46   ` Adam Fedor
2003-03-24 18:25     ` Andrew Cagney
2003-03-25  2:23       ` Adam Fedor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E88C39F.2030605@redhat.com \
    --to=ac131313@redhat.com \
    --cc=drow@mvista.com \
    --cc=fedor@doc.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox