From: Daniel Jacobowitz <drow@mvista.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: Adam Fedor <fedor@doc.com>, GDB Patches <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] Compile objc-lang.c, objc-exp.tab.c [1/5]
Date: Thu, 20 Mar 2003 21:39:00 -0000 [thread overview]
Message-ID: <20030320213945.GA17345@nevyn.them.org> (raw)
In-Reply-To: <3E7A3226.9040904@redhat.com>
Not without some substantial thought. We use cplus_demangle in a lot
of places where we don't even know what the language is supposed to be
- for minsyms, during lookups, et cetera.
Certainly it needs to be thought about. At least objc's mangling is
probably not entirely ambiguous with C++/Java's? I don't know.
On Thu, Mar 20, 2003 at 04:27:02PM -0500, Andrew Cagney wrote:
> Daniel,
>
> Would it be possible to make the cplus_demangle() method part of the
> language vector? That way code like the patch below could be reduced to:
>
> /* Return demangled language symbol, or NULL. */
> language_demangle (current_language, arg);
>
> This would in turn allow Adam to just add an equivalent objc_demangle()
> method to the objc language vector, and hence eliminate the need to
> always link in objc-lang.c.
>
> Andrew
>
> >RCS file: /cvs/src/src/gdb/maint.c,v
> >retrieving revision 1.30
> >diff -u -p -r1.30 maint.c
> >--- maint.c 24 Dec 2002 03:57:58 -0000 1.30
> >+++ maint.c 3 Jan 2003 03:06:25 -0000
> >@@ -35,6 +35,7 @@
> > #include "symfile.h"
> > #include "objfiles.h"
> > #include "value.h"
> >+#include "objc-lang.h"
> >
> > #include "cli/cli-decode.h"
> >
> >@@ -154,9 +155,8 @@ maintenance_demangle (char *args, int fr
> > switch (current_language->la_language)
> > {
> > case language_objc:
> >- /* Commented out until ObjC handling is enabled. */
> >- /* demangled = objc_demangle (args); */
> >- /* break; */
> >+ demangled = objc_demangle (args);
> >+ break;
> > case language_cplus:
> > default:
> > demangled = cplus_demangle (args, DMGL_ANSI | DMGL_PARAMS);
>
>
>
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2003-03-20 21:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-03 22:06 Adam Fedor
2003-02-19 19:02 ` Elena Zannoni
2003-02-19 20:27 ` Adam Fedor
2003-02-19 21:11 ` Elena Zannoni
2003-03-20 21:27 ` Andrew Cagney
2003-03-20 21:39 ` Daniel Jacobowitz [this message]
2003-03-20 22:13 ` Andrew Cagney
2003-03-20 22:19 ` Daniel Jacobowitz
2003-03-31 2:23 ` Adam Fedor
2003-03-31 22:39 ` Andrew Cagney
2003-03-31 22:53 ` David Carlton
2003-03-31 23:03 ` David Carlton
2003-03-31 23:15 ` Adam Fedor
2003-04-01 0:31 ` Andrew Cagney
2003-04-01 0:45 ` David Carlton
2003-04-01 4:09 ` Adam Fedor
2003-04-01 21:31 ` David Carlton
2003-04-01 21:38 ` Daniel Jacobowitz
2003-03-20 22:22 ` David Ayers
2003-03-20 21:35 ` Andrew Cagney
2003-03-24 17:46 ` Adam Fedor
2003-03-24 18:25 ` Andrew Cagney
2003-03-25 2:23 ` Adam Fedor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030320213945.GA17345@nevyn.them.org \
--to=drow@mvista.com \
--cc=ac131313@redhat.com \
--cc=fedor@doc.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox