From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28106 invoked by alias); 31 Mar 2003 22:39:30 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28094 invoked from network); 31 Mar 2003 22:39:30 -0000 Received: from unknown (HELO localhost.redhat.com) (207.219.125.105) by sources.redhat.com with SMTP; 31 Mar 2003 22:39:30 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 611942B23; Mon, 31 Mar 2003 17:39:27 -0500 (EST) Message-ID: <3E88C39F.2030605@redhat.com> Date: Mon, 31 Mar 2003 22:39:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Adam Fedor , Daniel Jacobowitz Cc: GDB Patches Subject: Re: [RFA] Compile objc-lang.c, objc-exp.tab.c [1/5] References: <3E16093D.3070907@doc.com> <3E7A3226.9040904@redhat.com> <20030320213945.GA17345@nevyn.them.org> <3E7A3D14.1020100@redhat.com> <20030320221924.GA25955@nevyn.them.org> <3E87A68C.6090301@doc.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-03/txt/msg00618.txt.bz2 > > > Daniel Jacobowitz wrote: > On Thu, Mar 20, 2003 at 05:13:40PM -0500, Andrew Cagney wrote: > > > Would it be possible to make the cplus_demangle() method part of the language vector? That way code like the patch below could be reduced to: > > /* Return demangled language symbol, or NULL. */ > language_demangle (current_language, arg); > > This would in turn allow Adam to just add an equivalent objc_demangle() method to the objc language vector, and hence eliminate the need to always link in objc-lang.c. > > As well as then? The places where objc is adding calls to the demangler the language is known. > > > My gut reaction is that it's just clutter until we decide how to solve > the problem of not knowing demanglings. But it'll do for now. I'd > like a comment along the lines of: > > /* FIXME: sometimes the demangler is invoked when we don't know the > language, so we can't use this everywhere. */ > > > Here's my crack at doing this Looks right to me. Daniel, see any C++ problems? > 2003-03-30 Adam Fedor > > * Makefile.in (c_lang.c, jv_lang.c): Add $(demangle_h). I think you ment c-lang.o, jv-lang.o. Andrew