* [RFA] arm_store_return_value, big-endian
@ 2002-11-06 15:49 Michael Snyder
2002-11-06 15:58 ` Andrew Cagney
0 siblings, 1 reply; 6+ messages in thread
From: Michael Snyder @ 2002-11-06 15:49 UTC (permalink / raw)
To: gdb-patches, cagney, kevinb, rearnsha
[-- Attachment #1: Type: text/plain, Size: 67 bytes --]
This corresponds to the earlier patch for arm_extract_return_value.
[-- Attachment #2: arm2.patch --]
[-- Type: text/plain, Size: 811 bytes --]
2002-11-06 Michael Snyder <msnyder@redhat.com>
* arm-tdep.c (arm_store_return_value): Handle offset of
small types on big-endian machines.
Index: arm-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/arm-tdep.c,v
retrieving revision 1.74
diff -p -r1.74 arm-tdep.c
*** arm-tdep.c 1 Nov 2002 21:21:49 -0000 1.74
--- arm-tdep.c 6 Nov 2002 23:47:34 -0000
*************** gdb_print_insn_arm (bfd_vma memaddr, dis
*** 2151,2156 ****
--- 2151,2159 ----
memaddr = UNMAKE_THUMB_ADDR (memaddr);
info->symbols = &asym;
}
+ else if (TYPE_LENGTH (type) < REGISTER_RAW_SIZE (A1_REGNUM))
+ write_register_bytes (REGISTER_RAW_SIZE (A1_REGNUM) - TYPE_LENGTH (type),
+ valbuf, TYPE_LENGTH (type));
else
info->symbols = NULL;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFA] arm_store_return_value, big-endian
2002-11-06 15:49 [RFA] arm_store_return_value, big-endian Michael Snyder
@ 2002-11-06 15:58 ` Andrew Cagney
2002-11-06 16:11 ` Michael Snyder
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cagney @ 2002-11-06 15:58 UTC (permalink / raw)
To: Michael Snyder; +Cc: gdb-patches, cagney, kevinb, rearnsha
> This corresponds to the earlier patch for arm_extract_return_value.
>
>
>
> 2002-11-06 Michael Snyder <msnyder@redhat.com>
>
> * arm-tdep.c (arm_store_return_value): Handle offset of
> small types on big-endian machines.
>
> Index: arm-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/arm-tdep.c,v
> retrieving revision 1.74
> diff -p -r1.74 arm-tdep.c
> *** arm-tdep.c 1 Nov 2002 21:21:49 -0000 1.74
> --- arm-tdep.c 6 Nov 2002 23:47:34 -0000
> *************** gdb_print_insn_arm (bfd_vma memaddr, dis
> *** 2151,2156 ****
> --- 2151,2159 ----
> memaddr = UNMAKE_THUMB_ADDR (memaddr);
> info->symbols = &asym;
> }
> + else if (TYPE_LENGTH (type) < REGISTER_RAW_SIZE (A1_REGNUM))
> + write_register_bytes (REGISTER_RAW_SIZE (A1_REGNUM) - TYPE_LENGTH (type),
> + valbuf, TYPE_LENGTH (type));
> else
> info->symbols = NULL;
>
Write register bytes is dead.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFA] arm_store_return_value, big-endian
2002-11-06 15:58 ` Andrew Cagney
@ 2002-11-06 16:11 ` Michael Snyder
2002-11-06 16:14 ` Michael Snyder
2002-11-06 16:39 ` Andrew Cagney
0 siblings, 2 replies; 6+ messages in thread
From: Michael Snyder @ 2002-11-06 16:11 UTC (permalink / raw)
To: Andrew Cagney; +Cc: gdb-patches, cagney, kevinb, rearnsha
Andrew Cagney wrote:
>
> > This corresponds to the earlier patch for arm_extract_return_value.
> >
> >
> >
> > 2002-11-06 Michael Snyder <msnyder@redhat.com>
> >
> > * arm-tdep.c (arm_store_return_value): Handle offset of
> > small types on big-endian machines.
> >
> > Index: arm-tdep.c
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/arm-tdep.c,v
> > retrieving revision 1.74
> > diff -p -r1.74 arm-tdep.c
> > *** arm-tdep.c 1 Nov 2002 21:21:49 -0000 1.74
> > --- arm-tdep.c 6 Nov 2002 23:47:34 -0000
> > *************** gdb_print_insn_arm (bfd_vma memaddr, dis
> > *** 2151,2156 ****
> > --- 2151,2159 ----
> > memaddr = UNMAKE_THUMB_ADDR (memaddr);
> > info->symbols = &asym;
> > }
> > + else if (TYPE_LENGTH (type) < REGISTER_RAW_SIZE (A1_REGNUM))
> > + write_register_bytes (REGISTER_RAW_SIZE (A1_REGNUM) - TYPE_LENGTH (type),
> > + valbuf, TYPE_LENGTH (type));
> > else
> > info->symbols = NULL;
> >
>
> Write register bytes is dead.
I'm not having this argument with you again, Andrew.
If you want the fix, take it. If not, don't.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFA] arm_store_return_value, big-endian
2002-11-06 16:11 ` Michael Snyder
@ 2002-11-06 16:14 ` Michael Snyder
2002-11-06 16:22 ` Michael Snyder
2002-11-06 16:39 ` Andrew Cagney
1 sibling, 1 reply; 6+ messages in thread
From: Michael Snyder @ 2002-11-06 16:14 UTC (permalink / raw)
To: Andrew Cagney, gdb-patches, cagney, kevinb, rearnsha
Michael Snyder wrote:
>
> Andrew Cagney wrote:
> >
> > > This corresponds to the earlier patch for arm_extract_return_value.
> > >
> > >
> > >
> > > 2002-11-06 Michael Snyder <msnyder@redhat.com>
> > >
> > > * arm-tdep.c (arm_store_return_value): Handle offset of
> > > small types on big-endian machines.
> > >
> > > Index: arm-tdep.c
> > > ===================================================================
> > > RCS file: /cvs/src/src/gdb/arm-tdep.c,v
> > > retrieving revision 1.74
> > > diff -p -r1.74 arm-tdep.c
> > > *** arm-tdep.c 1 Nov 2002 21:21:49 -0000 1.74
> > > --- arm-tdep.c 6 Nov 2002 23:47:34 -0000
> > > *************** gdb_print_insn_arm (bfd_vma memaddr, dis
> > > *** 2151,2156 ****
> > > --- 2151,2159 ----
> > > memaddr = UNMAKE_THUMB_ADDR (memaddr);
> > > info->symbols = &asym;
> > > }
> > > + else if (TYPE_LENGTH (type) < REGISTER_RAW_SIZE (A1_REGNUM))
> > > + write_register_bytes (REGISTER_RAW_SIZE (A1_REGNUM) - TYPE_LENGTH (type),
> > > + valbuf, TYPE_LENGTH (type));
> > > else
> > > info->symbols = NULL;
> > >
> >
> > Write register bytes is dead.
>
> I'm not having this argument with you again, Andrew.
> If you want the fix, take it. If not, don't.
Hang on -- that diff is entirely wrong. My use of write_register_bytes
was supposed to be replacing an existing use of write_register_bytes.
Let me see what went wrong...
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFA] arm_store_return_value, big-endian
2002-11-06 16:14 ` Michael Snyder
@ 2002-11-06 16:22 ` Michael Snyder
0 siblings, 0 replies; 6+ messages in thread
From: Michael Snyder @ 2002-11-06 16:22 UTC (permalink / raw)
To: Andrew Cagney, gdb-patches, cagney, kevinb, rearnsha
Err, this patch is withdrawn, and I will re-submit.
I appear to have been bitten by a bug in gnu-patch,
which placed these lines in ENTIRELY the wrong place.
Andrew, I'm sorry for snapping at you. Given the funky patch
you were looking at, your response was understandable.
Michael
Michael Snyder wrote:
>
> Michael Snyder wrote:
> >
> > Andrew Cagney wrote:
> > >
> > > > This corresponds to the earlier patch for arm_extract_return_value.
> > > >
> > > >
> > > >
> > > > 2002-11-06 Michael Snyder <msnyder@redhat.com>
> > > >
> > > > * arm-tdep.c (arm_store_return_value): Handle offset of
> > > > small types on big-endian machines.
> > > >
> > > > Index: arm-tdep.c
> > > > ===================================================================
> > > > RCS file: /cvs/src/src/gdb/arm-tdep.c,v
> > > > retrieving revision 1.74
> > > > diff -p -r1.74 arm-tdep.c
> > > > *** arm-tdep.c 1 Nov 2002 21:21:49 -0000 1.74
> > > > --- arm-tdep.c 6 Nov 2002 23:47:34 -0000
> > > > *************** gdb_print_insn_arm (bfd_vma memaddr, dis
> > > > *** 2151,2156 ****
> > > > --- 2151,2159 ----
> > > > memaddr = UNMAKE_THUMB_ADDR (memaddr);
> > > > info->symbols = &asym;
> > > > }
> > > > + else if (TYPE_LENGTH (type) < REGISTER_RAW_SIZE (A1_REGNUM))
> > > > + write_register_bytes (REGISTER_RAW_SIZE (A1_REGNUM) - TYPE_LENGTH (type),
> > > > + valbuf, TYPE_LENGTH (type));
> > > > else
> > > > info->symbols = NULL;
> > > >
> > >
> > > Write register bytes is dead.
> >
> > I'm not having this argument with you again, Andrew.
> > If you want the fix, take it. If not, don't.
>
> Hang on -- that diff is entirely wrong. My use of write_register_bytes
> was supposed to be replacing an existing use of write_register_bytes.
> Let me see what went wrong...
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFA] arm_store_return_value, big-endian
2002-11-06 16:11 ` Michael Snyder
2002-11-06 16:14 ` Michael Snyder
@ 2002-11-06 16:39 ` Andrew Cagney
1 sibling, 0 replies; 6+ messages in thread
From: Andrew Cagney @ 2002-11-06 16:39 UTC (permalink / raw)
To: Michael Snyder; +Cc: gdb-patches, cagney, kevinb, rearnsha
Michael,
See: http://sources.redhat.com/ml/gdb-patches/2002-11/msg00020.html
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2002-11-07 0:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-11-06 15:49 [RFA] arm_store_return_value, big-endian Michael Snyder
2002-11-06 15:58 ` Andrew Cagney
2002-11-06 16:11 ` Michael Snyder
2002-11-06 16:14 ` Michael Snyder
2002-11-06 16:22 ` Michael Snyder
2002-11-06 16:39 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox