Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: Andrew Cagney <ac131313@redhat.com>,
	gdb-patches@sources.redhat.com, cagney@redhat.com,
	kevinb@redhat.com, rearnsha@arm.com
Subject: Re: [RFA] arm_store_return_value, big-endian
Date: Wed, 06 Nov 2002 16:22:00 -0000	[thread overview]
Message-ID: <3DC9B221.CC44FB9C@redhat.com> (raw)
In-Reply-To: <3DC9B071.95F5733F@redhat.com>

Err, this patch is withdrawn, and I will re-submit.
I appear to have been bitten by a bug in gnu-patch, 
which placed these lines in ENTIRELY the wrong place.

Andrew, I'm sorry for snapping at you.  Given the funky patch
you were looking at, your response was understandable.

Michael

Michael Snyder wrote:
> 
> Michael Snyder wrote:
> >
> > Andrew Cagney wrote:
> > >
> > > > This corresponds to the earlier patch for arm_extract_return_value.
> > > >
> > > >
> > > >
> > > > 2002-11-06  Michael Snyder  <msnyder@redhat.com>
> > > >
> > > >       * arm-tdep.c (arm_store_return_value): Handle offset of
> > > >       small types on big-endian machines.
> > > >
> > > > Index: arm-tdep.c
> > > > ===================================================================
> > > > RCS file: /cvs/src/src/gdb/arm-tdep.c,v
> > > > retrieving revision 1.74
> > > > diff -p -r1.74 arm-tdep.c
> > > > *** arm-tdep.c        1 Nov 2002 21:21:49 -0000       1.74
> > > > --- arm-tdep.c        6 Nov 2002 23:47:34 -0000
> > > > *************** gdb_print_insn_arm (bfd_vma memaddr, dis
> > > > *** 2151,2156 ****
> > > > --- 2151,2159 ----
> > > >         memaddr = UNMAKE_THUMB_ADDR (memaddr);
> > > >         info->symbols = &asym;
> > > >       }
> > > > +   else if (TYPE_LENGTH (type) < REGISTER_RAW_SIZE (A1_REGNUM))
> > > > +     write_register_bytes (REGISTER_RAW_SIZE (A1_REGNUM) - TYPE_LENGTH (type),
> > > > +                       valbuf, TYPE_LENGTH (type));
> > > >     else
> > > >       info->symbols = NULL;
> > > >
> > >
> > > Write register bytes is dead.
> >
> > I'm not having this argument with you again, Andrew.
> > If you want the fix, take it.  If not, don't.
> 
> Hang on -- that diff is entirely wrong.  My use of write_register_bytes
> was supposed to be replacing an existing use of write_register_bytes.
> Let me see what went wrong...


  reply	other threads:[~2002-11-07  0:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-06 15:49 Michael Snyder
2002-11-06 15:58 ` Andrew Cagney
2002-11-06 16:11   ` Michael Snyder
2002-11-06 16:14     ` Michael Snyder
2002-11-06 16:22       ` Michael Snyder [this message]
2002-11-06 16:39     ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DC9B221.CC44FB9C@redhat.com \
    --to=msnyder@redhat.com \
    --cc=ac131313@redhat.com \
    --cc=cagney@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    --cc=rearnsha@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox