From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-19896-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 28644 invoked by alias); 7 Nov 2002 00:22:14 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 28636 invoked from network); 7 Nov 2002 00:22:13 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 7 Nov 2002 00:22:13 -0000
Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200])
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id gA6NxYw22840
	for <gdb-patches@sources.redhat.com>; Wed, 6 Nov 2002 18:59:34 -0500
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gA70Lxl31247;
	Wed, 6 Nov 2002 19:22:05 -0500
Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id gA70LrD10358;
	Wed, 6 Nov 2002 16:21:53 -0800
Message-ID: <3DC9B221.CC44FB9C@redhat.com>
Date: Wed, 06 Nov 2002 16:22:00 -0000
From: Michael Snyder <msnyder@redhat.com>
Organization: Red Hat, Inc.
X-Accept-Language: en
MIME-Version: 1.0
To: Andrew Cagney <ac131313@redhat.com>, gdb-patches@sources.redhat.com,
   cagney@redhat.com, kevinb@redhat.com, rearnsha@arm.com
Subject: Re: [RFA] arm_store_return_value, big-endian
References: <3DC9AA92.5FA9D709@redhat.com> <3DC9ACB3.6070605@redhat.com> <3DC9AF8E.667002A4@redhat.com> <3DC9B071.95F5733F@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-11/txt/msg00152.txt.bz2

Err, this patch is withdrawn, and I will re-submit.
I appear to have been bitten by a bug in gnu-patch, 
which placed these lines in ENTIRELY the wrong place.

Andrew, I'm sorry for snapping at you.  Given the funky patch
you were looking at, your response was understandable.

Michael

Michael Snyder wrote:
> 
> Michael Snyder wrote:
> >
> > Andrew Cagney wrote:
> > >
> > > > This corresponds to the earlier patch for arm_extract_return_value.
> > > >
> > > >
> > > >
> > > > 2002-11-06  Michael Snyder  <msnyder@redhat.com>
> > > >
> > > >       * arm-tdep.c (arm_store_return_value): Handle offset of
> > > >       small types on big-endian machines.
> > > >
> > > > Index: arm-tdep.c
> > > > ===================================================================
> > > > RCS file: /cvs/src/src/gdb/arm-tdep.c,v
> > > > retrieving revision 1.74
> > > > diff -p -r1.74 arm-tdep.c
> > > > *** arm-tdep.c        1 Nov 2002 21:21:49 -0000       1.74
> > > > --- arm-tdep.c        6 Nov 2002 23:47:34 -0000
> > > > *************** gdb_print_insn_arm (bfd_vma memaddr, dis
> > > > *** 2151,2156 ****
> > > > --- 2151,2159 ----
> > > >         memaddr = UNMAKE_THUMB_ADDR (memaddr);
> > > >         info->symbols = &asym;
> > > >       }
> > > > +   else if (TYPE_LENGTH (type) < REGISTER_RAW_SIZE (A1_REGNUM))
> > > > +     write_register_bytes (REGISTER_RAW_SIZE (A1_REGNUM) - TYPE_LENGTH (type),
> > > > +                       valbuf, TYPE_LENGTH (type));
> > > >     else
> > > >       info->symbols = NULL;
> > > >
> > >
> > > Write register bytes is dead.
> >
> > I'm not having this argument with you again, Andrew.
> > If you want the fix, take it.  If not, don't.
> 
> Hang on -- that diff is entirely wrong.  My use of write_register_bytes
> was supposed to be replacing an existing use of write_register_bytes.
> Let me see what went wrong...