[patch v9 3/5] Documentation for the remove-symbol-file command.

[patch v9 3/5] Documentation for the remove-symbol-file command.

[Nicolas Blanc]

2013-04-05  Nicolas Blanc  <nicolas.blanc@intel.com>

	* NEWS: Add description of the remove-symbol-file command.
gdb/doc
	* gdb.texinfo (Commands to Specify Files): Add description
	of the remove-symbol-file command.

Signed-off-by: Nicolas Blanc <nicolas.blanc@intel.com>
---
 gdb/NEWS            |    6 ++++++
 gdb/doc/gdb.texinfo |   26 ++++++++++++++++++++++++--
 2 files changed, 30 insertions(+), 2 deletions(-)

diff --git a/gdb/NEWS b/gdb/NEWS
index eea9917..ac6d6e8 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -31,6 +31,12 @@ maint set|show per-command time
 maint set|show per-command symtab
   Enable display of per-command gdb resource usage.
 
+remove-symbol-file FILENAME
+remove-symbol-file -a ADDRESS
+  Remove a symbol file added via add-symbol-file.  The file to remove
+  can be identified by its filename or by an address that lies within
+  the boundaries of this symbol file in memory.
+
 * New options
 
 set remote trace-status-packet
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index e6ec4ff..c42f320 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -16513,8 +16513,9 @@ section name and base address for that section.  You can specify any
 The symbol table of the file @var{filename} is added to the symbol table
 originally read with the @code{symbol-file} command.  You can use the
 @code{add-symbol-file} command any number of times; the new symbol data
-thus read keeps adding to the old.  To discard all old symbol data
-instead, use the @code{symbol-file} command without any arguments.
+thus read keeps adding to the old.
+
+Changes can be reverted using the command @code{remove-symbol-file}.
 
 @cindex relocatable object files, reading symbols from
 @cindex object files, relocatable, reading symbols from
@@ -16552,6 +16553,27 @@ way.
 
 @code{add-symbol-file} does not repeat if you press @key{RET} after using it.
 
+@kindex remove-symbol-file
+@item remove-symbol-file @var{filename}
+@item remove-symbol-file -a @var{address}
+Remove a symbol file added via the @code{add-symbol-file} command.  The
+file to remove can be identified by its @var{filename} or by an @var{address}
+that lies within the boundaries of this symbol file in memory.  Example:
+
+@smallexample
+(gdb) add-symbol-file /home/user/gdb/mylib.so 0x7ffff7ff9480
+add symbol table from file "/home/user/gdb/mylib.so" at
+    .text_addr = 0x7ffff7ff9480
+(y or n) y
+Reading symbols from /home/user/gdb/mylib.so...done.
+(gdb) remove-symbol-file -a 0x7ffff7ff9480
+Remove symbol table from file "/home/user/gdb/mylib.so"? (y or n) y
+(gdb)
+@end smallexample
+
+
+@code{remove-symbol-file} does not repeat if you press @key{RET} after using it.
+
 @kindex add-symbol-file-from-memory
 @cindex @code{syscall DSO}
 @cindex load symbols from memory
-- 
1.7.6.5

[patch v9 0/5] remove-symbol-file

[Nicolas Blanc]

Hello,

As discussed in http://sourceware.org/ml/gdb-patches/2013-05/msg01029.html,
GDB has no command for listing files that have been added via add-symbol-file.

In particular, 'info files' does not list the sections of user-added symbol files
because add-symbol-file does not update the target sections (current_target_sections).
Patch 4 implements this.

So technically, Patch 4 is a fix for add-symbol-file. I send it, for convinience,
as new revision for the remove-symbol-file command because Patch 4 depends on Patch 1,
which is not checked in, and this issue was raised in its context.

Patch 1 and 3 are identical in V8 and V9. Patch 2 is also identical to the previous
version except for a minor typo in symbol-file.exp that I corrected.

I hope you will find this fix for add-symbol-file useful. Please let me know if
you like this patch series.

Thank you,

Nicolas

Changes between v8 abd v9:

* Patch 4: New patch.
* Patch 5: New patch.

* sym-file.exp: Fixed test name string.

Changes between v7 and v8:

* sym-file.exp: Call gdb_get_line_number with ${libfile}.c intead of $libsrc.

* Fixed typo in commit message for Patch 2/3.

Changes between v6 and v7:

* Changed disable_breakpoints_in_freed_objfile () from feedback:
  Use is_breakpoint () and is_tracepoint ().
  Add call to mark_breakpoint_location_modified ().

* Changed command description according to suggestion.

* Changed commit log message for new functions according to feedback.

* Fixed nits in gdb/solib.c and testsuite/gdb.base/sym-file.exp.

Changes between v5 and v6:

* Changed syntax of the command according to feedback:
    remove-symbol-file FILENAME
    remove-symbol-file -a ADDRESS

* Updated the documentation for the new syntax.

* Updated the test for the new syntax.

* Added check to only remove objfiles from the current program space.

Changes between v4 and v5:

* The address parameter can now be any address mapping into one of the sections
  of the file to remove. This is more flexible and more judicious because the symbol
  file may have no text section, as pointed out in some reviews.

* Move is_addr_in_objfile from breakpoint.c to objfiles.c. This new function
  is now used in both symfile.c and breakpoint.c.

* is_addr_in_objfile returns now 0 if OBJFILE is NULL.

* Updated the documentation to reflect the command change.

* Removed double blank lines.

* Reworded the log entries in the commit messages, as suggested.

* The test was simplified using prepare_for_testing, as suggested.

Changes between v3 and v4:

* gdb/symfile.c: add missing space character in output string.

* gdb/doc/gdb.texinfo: add usage example.

Changes between v2 and v3:

* gdb/breakpoints.c (disable_breakpoints_in_freed_objfile):
  Changed name of disable_breakpoints_in_free_objfile to disable_breakpoints_in_freed_objfile.
  Call observer_breakpoint_modified at most one time per breakpoint.

* gdb/objfiles.h (struct objfile): Add comment for low_addr.

* gdb/solib.c (remove_user_added_objfile): Don't check OBJF_SHARED anymore to avoid leaving dangling pointers.

* gdb/symfile.c (add_symbol_file_command): Parse and evaluate the address parameter only once.

* gdb/symfile.c (remove_symbol_file_command): Don't use gdb_buildargv anymore. Ask the user for confirmation before removing a file.

* gdb/doc/gdb.texinfo: The parameter of the command is now referred to as "the address of the text section".

* gdb/NEWS: Move the entry for remove-symbol-file to "Changes since GDB 7.6". The address parameter is now referred to as "the beginning of the text section".

* Fixed letter case of variables in comments.

* Fixed indentation typos.


Nicolas Blanc (5):
  New remove-symbol-file command.
  Test adding and removing a symbol file at runtime.
  Documentation for the remove-symbol-file command.
  'add-symbol-file' should update the current target sections.
  Test 'info files' after 'add-symbol-file' and 'remove-symbol-file'.

 gdb/NEWS                               |    6 +
 gdb/breakpoint.c                       |   67 ++++++-
 gdb/doc/gdb.texinfo                    |   26 ++-
 gdb/doc/observer.texi                  |    4 +
 gdb/objfiles.c                         |   23 ++
 gdb/objfiles.h                         |    2 +
 gdb/printcmd.c                         |   15 +-
 gdb/solib.c                            |   22 ++
 gdb/symfile.c                          |  153 +++++++++++++-
 gdb/testsuite/gdb.base/sym-file-lib.c  |   19 ++
 gdb/testsuite/gdb.base/sym-file-main.c |  365 ++++++++++++++++++++++++++++++++
 gdb/testsuite/gdb.base/sym-file.exp    |  155 ++++++++++++++
 12 files changed, 844 insertions(+), 13 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/sym-file-lib.c
 create mode 100644 gdb/testsuite/gdb.base/sym-file-main.c
 create mode 100644 gdb/testsuite/gdb.base/sym-file.exp

-- 
1.7.6.5

[patch v9 5/5] Test 'info files' after 'add-symbol-file' and 'remove-symbol-file'.

[Nicolas Blanc]

2013-17-06  Nicolas Blanc  <nicolas.blanc@intel.com>

gdb/testsuite
	* gdb.base/sym-file.exp: Test 'info files'.

Signed-off-by: Nicolas Blanc <nicolas.blanc@intel.com>
---
 gdb/testsuite/gdb.base/sym-file.exp |   44 ++++++++++++++++++++++------------
 1 files changed, 28 insertions(+), 16 deletions(-)

diff --git a/gdb/testsuite/gdb.base/sym-file.exp b/gdb/testsuite/gdb.base/sym-file.exp
index 873e488..9387b95 100644
--- a/gdb/testsuite/gdb.base/sym-file.exp
+++ b/gdb/testsuite/gdb.base/sym-file.exp
@@ -17,14 +17,16 @@
 # 1)  Run to gdb_add_symbol_file in $srcfile.
 # 2)  Set a pending breakpoint at bar in $libsrc.
 # 3)  Load $shlib_name using 'add-symbol-file'.
-# 4)  Continue to bar in $libsrc.
-# 5)  Set a breakpoint at foo in $librc.
-# 6)  Continue to foo in $libsrc.
-# 7)  Set a breakpoint at gdb_remove_symbol_file.
-# 8)  Continue to gdb_remove_symbol_file in $srcfile.
-# 9)  Remove $shlib_name using 'remove-symbol-file'.
-# 10) Check that the breakpoints at foo and bar are pending.
-# 11) Check that the execution can continue without error.
+# 4)  'info files' must display $libname.
+# 5)  Continue to bar in $libsrc.
+# 6)  Set a breakpoint at foo in $librc.
+# 7)  Continue to foo in $libsrc.
+# 8)  Set a breakpoint at gdb_remove_symbol_file.
+# 9)  Continue to gdb_remove_symbol_file in $srcfile.
+# 10) Remove $shlib_name using 'remove-symbol-file'.
+# 11) 'info files' must not display $libname, anymore.
+# 12) Check that the breakpoints at foo and bar are pending.
+# 13) Check that the execution can continue without error.
 
 if [skip_shlib_tests] {
     return 0
@@ -91,33 +93,38 @@ if { $result != 0 } then {
    return
 }
 
-# 4) Continue to bar in $libsrc to ensure that the breakpoint
+# 4) 'info files' must display $libname.
+gdb_test "info files" \
+	 "^(?=(.*${libname})).*" \
+	 "info files must display $libname"
+
+# 5) Continue to bar in $libsrc to ensure that the breakpoint
 #    was bound correctly after adding $shilb_name.
 set lnum_bar [gdb_get_line_number "break at bar" ${libfile}.c]
 gdb_continue_to_breakpoint bar ".*$libfile\\.c:$lnum_bar.*"
 
-# 5) Set a breakpoint at foo in $libsrc.
+# 6) Set a breakpoint at foo in $libsrc.
 set result [gdb_breakpoint foo]
 if { !$result } then {
     return
 }
 
-# 6) Continue to foo in $libsrc to ensure that the breakpoint
+# 7) Continue to foo in $libsrc to ensure that the breakpoint
 #    was bound correctly.
 set lnum_foo [gdb_get_line_number "break at foo" ${libfile}.c]
 gdb_continue_to_breakpoint foo ".*$libfile\\.c:$lnum_foo.*"
 
-# 7) Set a breakpoint at gdb_remove_symbol_file in $srcfile for
+# 8) Set a breakpoint at gdb_remove_symbol_file in $srcfile for
 #    removing $shlib_name.
 set result [gdb_breakpoint gdb_remove_symbol_file]
 if { !$result } then {
     return
 }
 
-# 8) Continue to gdb_remove_symbol_file in $srcfile.
+# 9) Continue to gdb_remove_symbol_file in $srcfile.
 gdb_continue_to_breakpoint gdb_remove_symbol_file
 
-# 9) Remove $shlib_name using 'remove-symbol-file'.
+# 10) Remove $shlib_name using 'remove-symbol-file'.
 set result [gdb_test "remove-symbol-file -a addr" \
 		     ""\
      		     "remove-symbol-file -a addr" \
@@ -128,7 +135,12 @@ if { $result != 0 } then {
     return
 }
 
-# 10) Check that the breakpoints at foo and bar are pending after removing
+# 11) 'info files' must not display $libname, anymore.
+gdb_test "info files" \
+	 "^(?!(.*${libname})).*" \
+	 "info files must not display ${libname}"
+
+# 12) Check that the breakpoints at foo and bar are pending after removing
 #     $shlib_name.
 gdb_test "info breakpoints 2" \
 	 ".*PENDING.*" \
@@ -138,6 +150,6 @@ gdb_test "info breakpoints 3" \
 	 ".*PENDING.*" \
 	 "check if Breakpoint 3 is pending."
 
-# 11) Check that the execution can continue without error.
+# 13) Check that the execution can continue without error.
 gdb_continue_to_end
 
-- 
1.7.6.5

[patch v9 2/5] Test adding and removing a symbol file at runtime.

[Nicolas Blanc]

This test exercises the commands 'add-symbol-file'
and 'remove-symbol-file'.

2013-04-04  Nicolas Blanc  <nicolas.blanc@intel.com>

gdb/testsuite
	* gdb.base/sym-file-lib.c: New file.
	* gdb.base/sym-file-main.c: New file.
	* gdb.base/sym-file.exp: New file.

Signed-off-by: Nicolas Blanc <nicolas.blanc@intel.com>
---
 gdb/testsuite/gdb.base/sym-file-lib.c  |   19 ++
 gdb/testsuite/gdb.base/sym-file-main.c |  365 ++++++++++++++++++++++++++++++++
 gdb/testsuite/gdb.base/sym-file.exp    |  143 +++++++++++++
 3 files changed, 527 insertions(+), 0 deletions(-)
 create mode 100644 gdb/testsuite/gdb.base/sym-file-lib.c
 create mode 100644 gdb/testsuite/gdb.base/sym-file-main.c
 create mode 100644 gdb/testsuite/gdb.base/sym-file.exp

diff --git a/gdb/testsuite/gdb.base/sym-file-lib.c b/gdb/testsuite/gdb.base/sym-file-lib.c
new file mode 100644
index 0000000..f9faf8a
--- /dev/null
+++ b/gdb/testsuite/gdb.base/sym-file-lib.c
@@ -0,0 +1,19 @@
+/* Copyright 2013 Free Software Foundation, Inc.
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+extern int bar () { return 1; }       /* gdb break at bar */
+
+extern int foo (int a) { return a; }  /* gdb break at foo */
+
diff --git a/gdb/testsuite/gdb.base/sym-file-main.c b/gdb/testsuite/gdb.base/sym-file-main.c
new file mode 100644
index 0000000..f692ec5
--- /dev/null
+++ b/gdb/testsuite/gdb.base/sym-file-main.c
@@ -0,0 +1,365 @@
+/* Copyright 2013 Free Software Foundation, Inc.
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+#include <fcntl.h>
+#include </usr/include/elf.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <sys/mman.h>
+
+#ifdef TARGET_LP64
+typedef Elf64_Phdr Elf_Phdr;
+typedef Elf64_Ehdr Elf_Ehdr;
+typedef Elf64_Shdr Elf_Shdr;
+typedef Elf64_Sym Elf_Sym;
+typedef Elf64_Word Elf_Word;
+
+unsigned char inline elf_st_type (unsigned char st_info)
+{
+  return ELF64_ST_TYPE (st_info);
+}
+#elif defined TARGET_ILP32
+typedef Elf32_Phdr Elf_Phdr;
+typedef Elf32_Ehdr Elf_Ehdr;
+typedef Elf32_Shdr Elf_Shdr;
+typedef Elf32_Sym Elf_Sym;
+typedef Elf32_Word Elf_Word;
+
+unsigned char inline elf_st_type (unsigned char st_info)
+{
+  return ELF32_ST_TYPE (st_info);
+}
+#endif
+
+void gdb_add_symbol_file (void* addr, const char* file)
+{
+  return;
+}
+
+void gdb_remove_symbol_file (void* addr)
+{
+  return;
+}
+
+struct segment
+{
+  char* mapped_addr;
+  Elf_Phdr* phdr;
+  struct segment* next;
+};
+
+/* Load a program segment.  */
+
+struct segment* load (char * addr, Elf_Phdr* phdr, struct segment* tail_seg)
+{
+  /* For the sake of simplicity all operations are permitted.  */
+  unsigned perm = PROT_READ | PROT_WRITE | PROT_EXEC;
+
+  char* mapped_addr = (char*) mmap ((void*) phdr->p_vaddr,
+				     phdr->p_memsz, perm,
+				     MAP_ANONYMOUS | MAP_PRIVATE,
+				     -1, 0);
+
+  void * from = (void*) (addr + phdr->p_offset);
+  void * to = (void*) mapped_addr;
+
+  memcpy (to, from, phdr->p_filesz);
+
+  struct segment* seg = (struct segment*) malloc (sizeof (struct segment));
+
+  if (seg == 0)
+    return 0;
+
+  seg->mapped_addr = mapped_addr;
+  seg->phdr = phdr;
+  seg->next = 0;
+
+  if (tail_seg != 0)
+    tail_seg->next = seg;
+
+  return seg;
+}
+
+/* Load a shared library without calling the standard loader.  */
+
+int load_shlib (const char *file, Elf_Ehdr **ehdr_out, struct segment **seg_out)
+{
+  unsigned i = 0;
+
+  /* Map the lib in memory for reading.  */
+  int fd = open (file, O_RDONLY);
+  if (fd  < 0)
+    {
+      perror ("fopen failed.");
+      return -1;
+    }
+
+  off_t fsize = lseek (fd, 0, SEEK_END);
+
+  if (fsize < 0)
+    {
+      perror ("lseek failed.");
+      return -1;
+    }
+
+   char* addr = (char*) mmap (NULL, fsize, PROT_READ, MAP_PRIVATE, fd, 0);
+   if (addr == (char*) -1)
+     {
+       perror ("mmap failed.");
+       return -1;
+     }
+
+  /* Check if the lib is an ELF file.  */
+  Elf_Ehdr* ehdr = (Elf_Ehdr*) addr;
+  if (ehdr->e_ident[EI_MAG0] != ELFMAG0
+      || ehdr->e_ident[EI_MAG1] != ELFMAG1
+      || ehdr->e_ident[EI_MAG2] != ELFMAG2
+      || ehdr->e_ident[EI_MAG3] != ELFMAG3)
+    {
+      printf ("Not an ELF file: %x\n", ehdr->e_ident[EI_MAG0]);
+      return -1;
+    }
+
+  if (ehdr->e_ident[EI_CLASS] == ELFCLASS32)
+    {
+      if (sizeof (int*) != 4)
+	{
+	  printf ("Architecture mismatch.");
+	  return -1;
+	}
+    }
+  else if (ehdr->e_ident[EI_CLASS] == ELFCLASS64)
+    {
+      if (sizeof (int*) != 8)
+	{
+	  printf ("Architecture mismatch.");
+	  return -1;
+	}
+    }
+
+  /* Load the program segments.  For the sake of simplicity
+     assume that no reallocation is needed.  */
+  Elf_Phdr* phdr = (Elf_Phdr*) (addr + ehdr->e_phoff);
+  struct segment* head_seg = 0;
+  struct segment* tail_seg = 0;
+  for (i=0; i < ehdr->e_phnum; i++, phdr++)
+    {
+      if (phdr->p_type == PT_LOAD)
+	{
+	  struct segment* next_seg = load (addr, phdr, tail_seg);
+	  if (next_seg == 0)
+	    continue;
+	  tail_seg = next_seg;
+	  if (head_seg == 0)
+	    head_seg = next_seg;
+	}
+    }
+  *ehdr_out = ehdr;
+  *seg_out = head_seg;
+  return 0;
+}
+
+/* Return the section-header table.  */
+
+Elf_Shdr* find_shdrtab (Elf_Ehdr *ehdr)
+{
+  return  (Elf_Shdr*) (((char*) ehdr) + ehdr->e_shoff);
+}
+
+/* Return the string table of the section headers.  */
+
+const char* find_shstrtab (Elf_Ehdr *ehdr, unsigned *size)
+{
+  const Elf_Shdr *shdr = find_shdrtab (ehdr);
+
+  if (ehdr->e_shnum <= ehdr->e_shstrndx)
+    {
+      printf ("The index of the string table is corrupt.");
+      return NULL;
+    }
+  const Elf_Shdr* shstr = &shdr[ehdr->e_shstrndx];
+  *size = shstr->sh_size;
+  return ((const char*) ehdr) + shstr->sh_offset;
+}
+
+/* Return the string table named SECTION.  */
+
+const char* find_strtab (Elf_Ehdr *ehdr,
+			 const char* shstrtab, unsigned shstrtab_size,
+			 const char* section, unsigned *strtab_size)
+{
+  const Elf_Shdr* shdr =  find_shdrtab (ehdr);
+  unsigned i = 0;
+  for (i=0; i < ehdr->e_shnum; i++)
+    {
+      Elf_Word name = shdr[i].sh_name;
+      if (shdr[i].sh_type == SHT_STRTAB && name <= shstrtab_size
+	  && strcmp ((const char*) &shstrtab[name], section) == 0)
+	{
+	  *strtab_size = shdr[i].sh_size;
+	  return ((const char*) ehdr) + shdr[i].sh_offset;
+	}
+
+    }
+  return NULL;
+}
+
+/* Return the section header named SECTION.  */
+
+Elf_Shdr* find_shdr (Elf_Ehdr* ehdr, const char *section,
+		     const char *shstrtab, unsigned shstrtab_size)
+{
+  Elf_Shdr *shdr = find_shdrtab (ehdr);
+  unsigned i = 0;
+  for (i=0; i < ehdr->e_shnum; i++)
+    {
+      Elf_Word name = shdr[i].sh_name;
+      if (name <= shstrtab_size)
+	{
+	  if (strcmp ((const char*) &shstrtab[name], section) == 0)
+	    return &shdr[i];
+	}
+
+    }
+  return NULL;
+}
+
+/* Return the symbol table.  */
+
+Elf_Sym* find_symtab (Elf_Ehdr* ehdr, unsigned *symtab_size)
+{
+  unsigned i = 0;
+  const Elf_Shdr *shdr = find_shdrtab (ehdr);
+  for (i=0; i < ehdr->e_shnum; i++)
+    {
+      if (shdr[i].sh_type == SHT_SYMTAB)
+	{
+	  *symtab_size = shdr[i].sh_size / sizeof (Elf_Sym);
+	  return (Elf_Sym*) (((const char*) ehdr) + shdr[i].sh_offset);
+	}
+    }
+  return NULL;
+}
+
+/* Lookup the offset of FUNC.  */
+
+int lookup_function (const char *func,
+		     Elf_Sym *symtab, unsigned symtab_size,
+		     const char *strtab, unsigned strtab_size,
+		     unsigned *offset)
+{
+  unsigned i = 0;
+  for (i=0; i < symtab_size; i++)
+    {
+      Elf_Sym* sym = &symtab[i];
+
+      if (elf_st_type (sym->st_info) != STT_FUNC)
+	continue;
+
+      if (sym->st_name < strtab_size)
+	{
+	  const char* name = &strtab[sym->st_name];
+	  if (strcmp (name, func) == 0)
+	    {
+	      *offset = (unsigned) sym->st_value;
+	      return 0;
+	    }
+       }
+    }
+
+  return -1;
+}
+
+/* Load a shared library without relying on the standard
+   loader to test GDB's commands for adding and removing
+   symbol files at runtime.  */
+
+int main (int argc, const char* argv[])
+{
+  const char *file = SHLIB_NAME;
+
+  Elf_Ehdr *ehdr = 0;
+  struct segment *head_seg = 0;
+
+  if (load_shlib (file, &ehdr, &head_seg) != 0)
+    return -1;
+
+  /* Get the string table for the section headers.  */
+  unsigned shstrtab_size = 0;
+  const char* shstrtab = find_shstrtab (ehdr, &shstrtab_size);
+
+  if (shstrtab == NULL)
+    return -1;
+
+  /* Get the text section.  */
+  Elf_Shdr* text = find_shdr (ehdr, ".text", shstrtab, shstrtab_size);
+  if (text == NULL)
+    return -1;
+
+  char* base_addr = head_seg->mapped_addr + text->sh_offset;
+
+  /* Notify GDB to add the symbol file.  */
+  gdb_add_symbol_file (base_addr, file);
+
+  /* Get the string table for the symbols.  */
+  unsigned strtab_size = 0;
+  const char* strtab = find_strtab (ehdr, shstrtab, shstrtab_size,
+				    ".strtab", &strtab_size);
+  if (strtab == NULL)
+    {
+      printf (".strtab not found.");
+      return -1;
+    }
+
+  /* Get the symbol table.  */
+  unsigned symtab_size = 0;
+  Elf_Sym* symtab = find_symtab (ehdr, &symtab_size);
+  if (symtab == NULL)
+    {
+      printf ("symtab not found.");
+      return -1;
+    }
+
+  /* Call bar from SHLIB_NAME.  */
+  unsigned bar_offset = 0;
+  if (lookup_function ("bar",
+		       symtab, symtab_size,
+		       strtab, strtab_size,
+		       &bar_offset) != 0)
+    return -1;
+
+  int (*pbar) () = (int (*) ()) (head_seg->mapped_addr + bar_offset);
+
+  int value1 = (*pbar) ();
+
+  /* Call foo from SHLIB_NAME.  */
+  unsigned foo_offset = 0;
+  if (lookup_function ("foo",
+		       symtab, symtab_size,
+		       strtab, strtab_size,
+		       &foo_offset) != 0)
+    return -1;
+
+  int (*pfoo) (int) =  (int (*) (int)) (head_seg->mapped_addr + foo_offset);
+
+  int value2 = (*pfoo) (2);
+
+  /* Notify GDB to remove the symbol file.  */
+  gdb_remove_symbol_file (base_addr);
+
+  return 0;
+}
+
diff --git a/gdb/testsuite/gdb.base/sym-file.exp b/gdb/testsuite/gdb.base/sym-file.exp
new file mode 100644
index 0000000..873e488
--- /dev/null
+++ b/gdb/testsuite/gdb.base/sym-file.exp
@@ -0,0 +1,143 @@
+# Copyright 2013 Free Software Foundation, Inc.
+
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+# Test adding and removing a symbol file dynamically:
+# 1)  Run to gdb_add_symbol_file in $srcfile.
+# 2)  Set a pending breakpoint at bar in $libsrc.
+# 3)  Load $shlib_name using 'add-symbol-file'.
+# 4)  Continue to bar in $libsrc.
+# 5)  Set a breakpoint at foo in $librc.
+# 6)  Continue to foo in $libsrc.
+# 7)  Set a breakpoint at gdb_remove_symbol_file.
+# 8)  Continue to gdb_remove_symbol_file in $srcfile.
+# 9)  Remove $shlib_name using 'remove-symbol-file'.
+# 10) Check that the breakpoints at foo and bar are pending.
+# 11) Check that the execution can continue without error.
+
+if [skip_shlib_tests] {
+    return 0
+}
+
+if [is_remote target] {
+    return 0
+}
+
+set target_size TARGET_UNKNOWN
+if [is_lp64_target] {
+    set target_size TARGET_LP64
+} elseif [is_ilp32_target] {
+   set target_size TARGET_ILP32
+} else {
+    return 0
+}
+
+set testfile sym-file.exp
+set mainfile sym-file-main
+set libfile sym-file-lib
+set srcfile ${mainfile}.c
+set libsrc "${srcdir}/${subdir}/${libfile}.c"
+set libname "${libfile}.so"
+set shlib_name "${objdir}/${subdir}/${libname}"
+set libobj "${objdir}/${subdir}/${libname}"
+set exec_opts [list debug "additional_flags=-D$target_size\
+ -DSHLIB_NAME\\=\"$shlib_name\""]
+
+if [get_compiler_info] {
+    return -1
+}
+
+if { [gdb_compile_shlib $libsrc $libobj {debug}] != "" } {
+    untested ${testfile}
+    return
+}
+
+if { [prepare_for_testing ${testfile} ${mainfile} ${srcfile} $exec_opts] } {
+    return
+}
+
+# 1) Run to GDB_ADD_SYMBOl_FILE in $srcfile for adding
+#    $shlib_name.
+set result [runto gdb_add_symbol_file]
+if { !$result } then {
+   return
+}
+
+# 2) Set a pending breakpoint at bar in $libsrc.
+set result [gdb_breakpoint bar allow-pending]
+if { !$result } then {
+   return
+}
+
+# 3) Add $shlib_name using 'add-symbol-file'.
+set result [gdb_test "add-symbol-file ${shlib_name} addr" \
+		     "Reading symbols from .*${shlib_name}\\.\\.\\.done\\." \
+		     "add-symbol-file ${shlib_name} addr" \
+		     "add symbol table from file \".*${shlib_name}\"\
+ at.*\\(y or n\\) " \
+		     "y"]
+if { $result != 0 } then {
+   return
+}
+
+# 4) Continue to bar in $libsrc to ensure that the breakpoint
+#    was bound correctly after adding $shilb_name.
+set lnum_bar [gdb_get_line_number "break at bar" ${libfile}.c]
+gdb_continue_to_breakpoint bar ".*$libfile\\.c:$lnum_bar.*"
+
+# 5) Set a breakpoint at foo in $libsrc.
+set result [gdb_breakpoint foo]
+if { !$result } then {
+    return
+}
+
+# 6) Continue to foo in $libsrc to ensure that the breakpoint
+#    was bound correctly.
+set lnum_foo [gdb_get_line_number "break at foo" ${libfile}.c]
+gdb_continue_to_breakpoint foo ".*$libfile\\.c:$lnum_foo.*"
+
+# 7) Set a breakpoint at gdb_remove_symbol_file in $srcfile for
+#    removing $shlib_name.
+set result [gdb_breakpoint gdb_remove_symbol_file]
+if { !$result } then {
+    return
+}
+
+# 8) Continue to gdb_remove_symbol_file in $srcfile.
+gdb_continue_to_breakpoint gdb_remove_symbol_file
+
+# 9) Remove $shlib_name using 'remove-symbol-file'.
+set result [gdb_test "remove-symbol-file -a addr" \
+		     ""\
+     		     "remove-symbol-file -a addr" \
+		     "Remove symbol table from file \".*${shlib_name}\"\\?\
+.*\\(y or n\\) " \
+		     "y"]
+if { $result != 0 } then {
+    return
+}
+
+# 10) Check that the breakpoints at foo and bar are pending after removing
+#     $shlib_name.
+gdb_test "info breakpoints 2" \
+	 ".*PENDING.*" \
+	 "check if Breakpoint 2 is pending."
+
+gdb_test "info breakpoints 3" \
+	 ".*PENDING.*" \
+	 "check if Breakpoint 3 is pending."
+
+# 11) Check that the execution can continue without error.
+gdb_continue_to_end
+
-- 
1.7.6.5

[patch v9 1/5] New remove-symbol-file command.

[Nicolas Blanc]

New command for removing symbol files added via
the add-symbol-file command.

2013-18-03  Nicolas Blanc  <nicolas.blanc@intel.com>

	* breakpoint.c (disable_breakpoints_in_freed_objfile): New function.
	* objfiles.c (free_objfile): Notify free_objfile.
	(is_addr_in_objfile): New function.
	* objfiles.h (is_addr_in_objfile): New declaration.
	* printcmd.c (clear_dangling_display_expressions): Act upon free_objfile
	events instead of solib_unloaded events.
	(_initialize_printcmd): Register observer for free_objfile instead
	of solib_unloaded notifications.
	* solib.c (remove_user_added_objfile): New function.
	* symfile.c (remove_symbol_file_command): New command.
	(_initialize_symfile): Add remove-symbol-file.
gdb/doc
	* observer.texi: New free_objfile event.

Signed-off-by: Nicolas Blanc <nicolas.blanc@intel.com>
---
 gdb/breakpoint.c      |   67 +++++++++++++++++++++++++++++++++++++--
 gdb/doc/observer.texi |    4 ++
 gdb/objfiles.c        |   23 +++++++++++++
 gdb/objfiles.h        |    2 +
 gdb/printcmd.c        |   15 +++++---
 gdb/solib.c           |   22 +++++++++++++
 gdb/symfile.c         |   84 +++++++++++++++++++++++++++++++++++++++++++++++++
 7 files changed, 208 insertions(+), 9 deletions(-)

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index d4ccc81..50284a0 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -7403,9 +7403,9 @@ disable_breakpoints_in_shlibs (void)
   }
 }
 
-/* Disable any breakpoints and tracepoints that are in an unloaded shared
-   library.  Only apply to enabled breakpoints, disabled ones can just stay
-   disabled.  */
+/* Disable any breakpoints and tracepoints that are in SOLIB upon
+   notification of unloaded_shlib.  Only apply to enabled breakpoints,
+   disabled ones can just stay disabled.  */
 
 static void
 disable_breakpoints_in_unloaded_shlib (struct so_list *solib)
@@ -7457,6 +7457,66 @@ disable_breakpoints_in_unloaded_shlib (struct so_list *solib)
   }
 }
 
+/* Disable any breakpoints and tracepoints in OBJFILE upon
+   notification of free_objfile.  Only apply to enabled breakpoints,
+   disabled ones can just stay disabled.  */
+
+static void
+disable_breakpoints_in_freed_objfile (struct objfile * objfile)
+{
+  struct breakpoint *b;
+
+  if (objfile == NULL)
+    return;
+
+  /* If the file is a shared library not loaded by the user then
+     solib_unloaded was notified and disable_breakpoints_in_unloaded_shlib
+     was called.  In that case there is no need to take action again.  */
+  if ((objfile->flags & OBJF_SHARED) && !(objfile->flags & OBJF_USERLOADED))
+    return;
+
+  ALL_BREAKPOINTS (b)
+  {
+    struct bp_location *loc;
+    int bp_modified = 0;
+
+    if (!is_breakpoint (b) && !is_tracepoint (b))
+      continue;
+
+    for (loc = b->loc; loc != NULL; loc = loc->next)
+      {
+	CORE_ADDR loc_addr = loc->address;
+
+	if (loc->loc_type != bp_loc_hardware_breakpoint
+	    && loc->loc_type != bp_loc_software_breakpoint)
+	  continue;
+
+	if (loc->shlib_disabled != 0)
+	  continue;
+
+	if (objfile->pspace != loc->pspace)
+	  continue;
+
+	if (loc->loc_type != bp_loc_hardware_breakpoint
+	    && loc->loc_type != bp_loc_software_breakpoint)
+	  continue;
+
+	if (is_addr_in_objfile (loc_addr, objfile))
+	  {
+	    loc->shlib_disabled = 1;
+	    loc->inserted = 0;
+
+	    mark_breakpoint_location_modified (loc);
+
+	    bp_modified = 1;
+	  }
+      }
+
+    if (bp_modified)
+      observer_notify_breakpoint_modified (b);
+  }
+}
+
 /* FORK & VFORK catchpoints.  */
 
 /* An instance of this type is used to represent a fork or vfork
@@ -15861,6 +15921,7 @@ _initialize_breakpoint (void)
   initialize_breakpoint_ops ();
 
   observer_attach_solib_unloaded (disable_breakpoints_in_unloaded_shlib);
+  observer_attach_free_objfile (disable_breakpoints_in_freed_objfile);
   observer_attach_inferior_exit (clear_syscall_counts);
   observer_attach_memory_changed (invalidate_bp_value_on_memory_change);
 
diff --git a/gdb/doc/observer.texi b/gdb/doc/observer.texi
index adb7085..f753965 100644
--- a/gdb/doc/observer.texi
+++ b/gdb/doc/observer.texi
@@ -138,6 +138,10 @@ Called with @var{objfile} equal to @code{NULL} to indicate
 previously loaded symbol table data has now been invalidated.
 @end deftypefun
 
+@deftypefun void free_objfile (struct objfile *@var{objfile})
+The object file specified by @var{objfile} is about to be freed.
+@end deftypefun
+
 @deftypefun void new_thread (struct thread_info *@var{t})
 The thread specified by @var{t} has been created.
 @end deftypefun
diff --git a/gdb/objfiles.c b/gdb/objfiles.c
index 1e1b7bc..6411380 100644
--- a/gdb/objfiles.c
+++ b/gdb/objfiles.c
@@ -539,6 +539,9 @@ free_objfile_separate_debug (struct objfile *objfile)
 void
 free_objfile (struct objfile *objfile)
 {
+  /* First notify observers that this objfile is about to be freed.  */
+  observer_notify_free_objfile (objfile);
+
   /* Free all separate debug objfiles.  */
   free_objfile_separate_debug (objfile);
 
@@ -1463,6 +1466,26 @@ resume_section_map_updates_cleanup (void *arg)
   resume_section_map_updates (arg);
 }
 
+/* Return 1 if ADDR maps into one of the sections of OBJFILE and 0
+   otherwise.  */
+
+int
+is_addr_in_objfile (CORE_ADDR addr, const struct objfile * objfile)
+{
+  struct obj_section *osect;
+
+  if (objfile == NULL)
+    return 0;
+
+  ALL_OBJFILE_OSECTIONS (objfile, osect)
+  {
+    if (obj_section_addr (osect) <= addr
+	&& addr < obj_section_endaddr (osect))
+      return 1;
+  }
+  return 0;
+}
+
 /* The default implementation for the "iterate_over_objfiles_in_search_order"
    gdbarch method.  It is equivalent to use the ALL_OBJFILES macro,
    searching the objfiles in the order they are stored internally,
diff --git a/gdb/objfiles.h b/gdb/objfiles.h
index adb1ef8..b25afb1 100644
--- a/gdb/objfiles.h
+++ b/gdb/objfiles.h
@@ -482,6 +482,8 @@ extern int have_full_symbols (void);
 
 extern void objfiles_changed (void);
 
+extern int is_addr_in_objfile (CORE_ADDR, const struct objfile *);
+
 /* This operation deletes all objfile entries that represent solibs that
    weren't explicitly loaded by the user, via e.g., the add-symbol-file
    command.  */
diff --git a/gdb/printcmd.c b/gdb/printcmd.c
index 99d4dba..1234135 100644
--- a/gdb/printcmd.c
+++ b/gdb/printcmd.c
@@ -1936,21 +1936,24 @@ disable_display_command (char *args, int from_tty)
    an item by re-parsing .exp_string field in the new execution context.  */
 
 static void
-clear_dangling_display_expressions (struct so_list *solib)
+clear_dangling_display_expressions (struct objfile *objfile)
 {
-  struct objfile *objfile = solib->objfile;
   struct display *d;
+  struct program_space *pspace;
 
   /* With no symbol file we cannot have a block or expression from it.  */
   if (objfile == NULL)
     return;
+  pspace = objfile->pspace;
   if (objfile->separate_debug_objfile_backlink)
-    objfile = objfile->separate_debug_objfile_backlink;
-  gdb_assert (objfile->pspace == solib->pspace);
+    {
+      objfile = objfile->separate_debug_objfile_backlink;
+      gdb_assert (objfile->pspace == pspace);
+    }
 
   for (d = display_chain; d != NULL; d = d->next)
     {
-      if (d->pspace != solib->pspace)
+      if (d->pspace != pspace)
 	continue;
 
       if (lookup_objfile_from_block (d->block) == objfile
@@ -2482,7 +2485,7 @@ _initialize_printcmd (void)
 
   current_display_number = -1;
 
-  observer_attach_solib_unloaded (clear_dangling_display_expressions);
+  observer_attach_free_objfile (clear_dangling_display_expressions);
 
   add_info ("address", address_info,
 	    _("Describe where symbol SYM is stored."));
diff --git a/gdb/solib.c b/gdb/solib.c
index c987fe5..7ceef29 100644
--- a/gdb/solib.c
+++ b/gdb/solib.c
@@ -1478,6 +1478,26 @@ gdb_bfd_lookup_symbol (bfd *abfd,
   return symaddr;
 }
 
+/* SO_LIST_HEAD may contain user-loaded object files that can be removed
+   out-of-band by the user.  So upon notification of free_objfile remove
+   any reference to any user-loaded file that is about to be freed.  */
+
+static void
+remove_user_added_objfile (struct objfile *objfile)
+{
+  struct so_list *so;
+
+  if (objfile == NULL)
+    return;
+
+  if (objfile->flags & OBJF_USERLOADED)
+    {
+      for (so = so_list_head; so != NULL; so = so->next)
+	if (so->objfile == objfile)
+	  so->objfile = NULL;
+    }
+}
+
 extern initialize_file_ftype _initialize_solib; /* -Wmissing-prototypes */
 
 void
@@ -1485,6 +1505,8 @@ _initialize_solib (void)
 {
   solib_data = gdbarch_data_register_pre_init (solib_init);
 
+  observer_attach_free_objfile (remove_user_added_objfile);
+
   add_com ("sharedlibrary", class_files, sharedlibrary_command,
 	   _("Load shared object library symbols for files matching REGEXP."));
   add_info ("sharedlibrary", info_sharedlibrary_command,
diff --git a/gdb/symfile.c b/gdb/symfile.c
index c2ad797..f7ad268 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -2330,6 +2330,81 @@ add_symbol_file_command (char *args, int from_tty)
 }
 \f
 
+/* This function removes a symbol file that was added via add-symbol-file.  */
+
+static void
+remove_symbol_file_command (char *args, int from_tty)
+{
+  char **argv;
+  struct objfile* objf = NULL;
+  struct cleanup *my_cleanups;
+  struct program_space *pspace = current_program_space;
+  struct gdbarch *gdbarch = get_current_arch ();
+
+  dont_repeat ();
+
+  if (args == NULL)
+    error (_("USAGE: remove-symbol-file FILENAME\n\
+       remove-symbol-file -a ADDRESS"));
+
+  my_cleanups = make_cleanup (null_cleanup, NULL);
+
+  argv = gdb_buildargv (args);
+
+  if (strcmp (argv[0], "-a") == 0)
+    {
+      /* Interpret the next argument as an address.  */
+      CORE_ADDR addr;
+
+      if (argv[1] == NULL)
+	error (_("Missing address argument"));
+
+      if (argv[2] != NULL)
+	error (_("Junk after %s"), argv[1]);
+
+      addr = parse_and_eval_address (argv[1]);
+
+      ALL_OBJFILES (objf)
+      {
+	if (objf->flags & OBJF_USERLOADED
+	    && objf->pspace == pspace
+	    && is_addr_in_objfile (addr, objf))
+	  break;
+      }
+    }
+  else if (argv[0] != NULL)
+    {
+      /* Interpret the current argument as a file name.  */
+      char *filename;
+
+      if (argv[1] != NULL)
+	error (_("Junk after %s"), argv[0]);
+
+      filename = tilde_expand (argv[0]);
+      make_cleanup (xfree, filename);
+
+      ALL_OBJFILES (objf)
+      {
+	if (objf->flags & OBJF_USERLOADED
+	    && objf->pspace == pspace
+	    && filename_cmp (filename, objf->name) == 0)
+	  break;
+      }
+    }
+
+  if (objf == NULL)
+    error (_("No symbol file found"));
+
+  if (from_tty
+      && !query (_("Remove symbol table from file \"%s\"? "), objf->name))
+    error (_("Not confirmed."));
+
+  free_objfile (objf);
+  clear_symtab_users (0);
+
+  do_cleanups (my_cleanups);
+}
+
 typedef struct objfile *objfilep;
 
 DEF_VEC_P (objfilep);
@@ -3744,6 +3819,15 @@ with the text.  SECT is a section name to be loaded at SECT_ADDR."),
 	       &cmdlist);
   set_cmd_completer (c, filename_completer);
 
+  c = add_cmd ("remove-symbol-file", class_files,
+	       remove_symbol_file_command, _("\
+Remove a symbol file added via the add-symbol-file command.\n\
+Usage: remove-symbol-file FILENAME\n\
+       remove-symbol-file -a ADDRESS\n\
+The file to remove can be identified by its filename or by an address\n\
+that lies within the boundaries of this symbol file in memory."),
+	       &cmdlist);
+
   c = add_cmd ("load", class_files, load_command, _("\
 Dynamically load FILE into the running program, and record its symbols\n\
 for access from GDB.\n\
-- 
1.7.6.5

[patch v9 4/5] 'add-symbol-file' should update the current target sections.

[Nicolas Blanc]

2013-17-06  Nicolas Blanc  <nicolas.blanc@intel.com>

	* symfile.c (add_target_sections_of_objfile): New function.
	(add_symbol_file_command): Update the current target sections.
	(symfile_free_objfile): New function.
	(_initialize_symfile): Attach observer for free_objfile.

Signed-off-by: Nicolas Blanc <nicolas.blanc@intel.com>
---
 gdb/symfile.c |   69 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 1 files changed, 67 insertions(+), 2 deletions(-)

diff --git a/gdb/symfile.c b/gdb/symfile.c
index f7ad268..33d0eda 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -57,6 +57,7 @@
 #include "stack.h"
 #include "gdb_bfd.h"
 #include "cli/cli-utils.h"
+#include "target.h"
 
 #include <sys/types.h>
 #include <fcntl.h>
@@ -2162,6 +2163,52 @@ print_transfer_performance (struct ui_file *stream,
   ui_out_text (uiout, ".\n");
 }
 
+/* Add the sections of OBJFILE to the current set of target sections.  */
+
+static void
+add_target_sections_of_objfile (struct objfile* objfile)
+{
+  struct target_section_table *table = current_target_sections;
+  struct obj_section *osect;
+  int space;
+  unsigned count = 0;
+  struct target_section* ts;
+
+  if (objfile == NULL)
+    return;
+
+  /* Compute the number of sections to add.  */
+  ALL_OBJFILE_OSECTIONS (objfile, osect)
+  {
+    if (bfd_get_section_size (osect->the_bfd_section) == 0)
+      continue;
+    count++;
+  }
+
+  if (count == 0)
+    return;
+
+  space = resize_section_table (table, count);
+
+  ts = table->sections + space;
+
+  ALL_OBJFILE_OSECTIONS (objfile, osect)
+  {
+    if (bfd_get_section_size (osect->the_bfd_section) == 0)
+      continue;
+
+    gdb_assert (ts < table->sections + space + count);
+
+    ts->addr = obj_section_addr (osect);
+    ts->endaddr = obj_section_endaddr (osect);
+    ts->the_bfd_section = osect->the_bfd_section;
+    ts->key = (void*) objfile;
+    ts->bfd = objfile->obfd;
+
+    ts++;
+  }
+}
+
 /* This function allows the addition of incrementally linked object files.
    It does not modify any state in the target, only in the debugger.  */
 /* Note: ezannoni 2000-04-13 This function/command used to have a
@@ -2185,6 +2232,7 @@ add_symbol_file_command (char *args, int from_tty)
   int expecting_sec_name = 0;
   int expecting_sec_addr = 0;
   char **argv;
+  struct objfile *objf;
 
   struct sect_opt
   {
@@ -2320,8 +2368,10 @@ add_symbol_file_command (char *args, int from_tty)
   if (from_tty && (!query ("%s", "")))
     error (_("Not confirmed."));
 
-  symbol_file_add (filename, from_tty ? SYMFILE_VERBOSE : 0,
-                   section_addrs, flags);
+  objf = symbol_file_add (filename, from_tty ? SYMFILE_VERBOSE : 0,
+			  section_addrs, flags);
+
+  add_target_sections_of_objfile (objf);
 
   /* Getting new symbols may change our opinion about what is
      frameless.  */
@@ -3798,11 +3848,26 @@ symfile_find_segment_sections (struct objfile *objfile)
   free_symfile_segment_data (data);
 }
 
+/* Listen for free_objfile events.  */
+
+static void
+symfile_free_objfile (struct objfile *objfile)
+{
+  if (objfile == NULL)
+    return;
+
+  /* Remove the target sections of user-added objfiles.  */
+  if (objfile->flags & OBJF_USERLOADED && objfile->obfd)
+    remove_target_sections ((void*)objfile, objfile->obfd);
+}
+
 void
 _initialize_symfile (void)
 {
   struct cmd_list_element *c;
 
+  observer_attach_free_objfile (symfile_free_objfile);
+
   c = add_cmd ("symbol-file", class_files, symbol_file_command, _("\
 Load symbol table from executable file FILE.\n\
 The `file' command can also load symbol tables, as well as setting the file\n\
-- 
1.7.6.5

Re: [patch v9 3/5] Documentation for the remove-symbol-file command.

[Eli Zaretskii]

> From: Nicolas Blanc <nicolas.blanc@intel.com>
> Cc: nicolas.blanc@intel.com
> Date: Tue, 18 Jun 2013 16:47:11 +0200
> 
> 2013-04-05  Nicolas Blanc  <nicolas.blanc@intel.com>
> 
> 	* NEWS: Add description of the remove-symbol-file command.
> gdb/doc
> 	* gdb.texinfo (Commands to Specify Files): Add description
> 	of the remove-symbol-file command.

This is OK, thanks.

Re: [patch v9 1/5] New remove-symbol-file command.

[Luis Machado]

Found a few more nits.

> @@ -7457,6 +7457,66 @@ disable_breakpoints_in_unloaded_shlib (struct so_list *solib)
>    }
>  }
>
> +/* Disable any breakpoints and tracepoints in OBJFILE upon
> +   notification of free_objfile.  Only apply to enabled breakpoints,
> +   disabled ones can just stay disabled.  */
> +
> +static void
> +disable_breakpoints_in_freed_objfile (struct objfile * objfile)

struct objfile *objfile

> +{
> +  struct breakpoint *b;
> +
> +  if (objfile == NULL)
> +    return;
> +
> +  /* If the file is a shared library not loaded by the user then
> +     solib_unloaded was notified and disable_breakpoints_in_unloaded_shlib
> +     was called.  In that case there is no need to take action again.  */
> +  if ((objfile->flags & OBJF_SHARED) && !(objfile->flags & OBJF_USERLOADED))
> +    return;
> +
> +  ALL_BREAKPOINTS (b)
> +  {

Identation is odd here. Should be further in.

> @@ -1463,6 +1466,26 @@ resume_section_map_updates_cleanup (void *arg)
>    resume_section_map_updates (arg);
>  }
>
> +/* Return 1 if ADDR maps into one of the sections of OBJFILE and 0
> +   otherwise.  */
> +
> +int
> +is_addr_in_objfile (CORE_ADDR addr, const struct objfile * objfile)

const struct objfile *objfile

> +{
> +  struct obj_section *osect;
> +
> +  if (objfile == NULL)
> +    return 0;
> +
> +  ALL_OBJFILE_OSECTIONS (objfile, osect)
> +  {

Identation off as well. Should be further in.

> diff --git a/gdb/objfiles.h b/gdb/objfiles.h
> index adb1ef8..b25afb1 100644
> --- a/gdb/objfiles.h
> +++ b/gdb/objfiles.h
> @@ -482,6 +482,8 @@ extern int have_full_symbols (void);
>
>  extern void objfiles_changed (void);
>
> +extern int is_addr_in_objfile (CORE_ADDR, const struct objfile *);
> +

Prototype arguments should be named as in the rest of the prototypes of
this header file.

> diff --git a/gdb/solib.c b/gdb/solib.c
> index c987fe5..7ceef29 100644
> --- a/gdb/solib.c
> +++ b/gdb/solib.c
> @@ -1478,6 +1478,26 @@ gdb_bfd_lookup_symbol (bfd *abfd,
>    return symaddr;
>  }
>
> +/* SO_LIST_HEAD may contain user-loaded object files that can be removed
> +   out-of-band by the user.  So upon notification of free_objfile remove
> +   any reference to any user-loaded file that is about to be freed.  */
> +


while at it, "any references to any user-loaded...".

> diff --git a/gdb/symfile.c b/gdb/symfile.c
> index c2ad797..f7ad268 100644
> --- a/gdb/symfile.c
> +++ b/gdb/symfile.c
> @@ -2330,6 +2330,81 @@ add_symbol_file_command (char *args, int from_tty)
>  }
>  ^L
>
> +/* This function removes a symbol file that was added via add-symbol-file.  */
> +
> +static void
> +remove_symbol_file_command (char *args, int from_tty)
> +{
> +  char **argv;
> +  struct objfile* objf = NULL;
> +  struct cleanup *my_cleanups;
> +  struct program_space *pspace = current_program_space;
> +  struct gdbarch *gdbarch = get_current_arch ();
> +
> +  dont_repeat ();
> +
> +  if (args == NULL)
> +    error (_("USAGE: remove-symbol-file FILENAME\n\
> +       remove-symbol-file -a ADDRESS"));

I discovered something odd. The only two commands using "USAGE" in help
texts are this one and add-symbol-file. I think we should drop it.

Moreover, add-symbol-file prints this when ran without arguments:

(gdb) add-symbol-file
add-symbol-file takes a file name and an address


And this when ran with more arguments than it should:

USAGE: add-symbol-file <filename> <textaddress> [-readnow]
[-s <secname> <addr>]*

So it is a little odd. We should probably fix this in another patch. For 
this
one i think we should only drop USAGE.

> +
> +  my_cleanups = make_cleanup (null_cleanup, NULL);
> +
> +  argv = gdb_buildargv (args);
> +
> +  if (strcmp (argv[0], "-a") == 0)
> +    {
> +      /* Interpret the next argument as an address.  */
> +      CORE_ADDR addr;
> +
> +      if (argv[1] == NULL)
> +       error (_("Missing address argument"));
> +
> +      if (argv[2] != NULL)
> +       error (_("Junk after %s"), argv[1]);
> +
> +      addr = parse_and_eval_address (argv[1]);
> +
> +      ALL_OBJFILES (objf)
> +      {

Identation off here. Should be further in.

> +       if (objf->flags & OBJF_USERLOADED
> +           && objf->pspace == pspace
> +           && is_addr_in_objfile (addr, objf))
> +         break;
> +      }
> +    }
> +  else if (argv[0] != NULL)
> +    {
> +      /* Interpret the current argument as a file name.  */
> +      char *filename;
> +
> +      if (argv[1] != NULL)
> +       error (_("Junk after %s"), argv[0]);
> +
> +      filename = tilde_expand (argv[0]);
> +      make_cleanup (xfree, filename);
> +
> +      ALL_OBJFILES (objf)
> +      {

Identation off as well. Should be further in.

Re: [patch v9 2/5] Test adding and removing a symbol file at runtime.

[Luis Machado]

Looks good to me.

On 06/18/2013 11:47 AM, Nicolas Blanc wrote:
> This test exercises the commands 'add-symbol-file'
> and 'remove-symbol-file'.
>
> 2013-04-04  Nicolas Blanc  <nicolas.blanc@intel.com>
>
> gdb/testsuite
> 	* gdb.base/sym-file-lib.c: New file.
> 	* gdb.base/sym-file-main.c: New file.
> 	* gdb.base/sym-file.exp: New file.
>
> Signed-off-by: Nicolas Blanc <nicolas.blanc@intel.com>
> ---
>   gdb/testsuite/gdb.base/sym-file-lib.c  |   19 ++
>   gdb/testsuite/gdb.base/sym-file-main.c |  365 ++++++++++++++++++++++++++++++++
>   gdb/testsuite/gdb.base/sym-file.exp    |  143 +++++++++++++
>   3 files changed, 527 insertions(+), 0 deletions(-)
>   create mode 100644 gdb/testsuite/gdb.base/sym-file-lib.c
>   create mode 100644 gdb/testsuite/gdb.base/sym-file-main.c
>   create mode 100644 gdb/testsuite/gdb.base/sym-file.exp
>
> diff --git a/gdb/testsuite/gdb.base/sym-file-lib.c b/gdb/testsuite/gdb.base/sym-file-lib.c
> new file mode 100644
> index 0000000..f9faf8a
> --- /dev/null
> +++ b/gdb/testsuite/gdb.base/sym-file-lib.c
> @@ -0,0 +1,19 @@
> +/* Copyright 2013 Free Software Foundation, Inc.
> +   This program is free software; you can redistribute it and/or modify
> +   it under the terms of the GNU General Public License as published by
> +   the Free Software Foundation; either version 3 of the License, or
> +   (at your option) any later version.
> +
> +   This program is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +   GNU General Public License for more details.
> +
> +   You should have received a copy of the GNU General Public License
> +   along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +*/
> +
> +extern int bar () { return 1; }       /* gdb break at bar */
> +
> +extern int foo (int a) { return a; }  /* gdb break at foo */
> +
> diff --git a/gdb/testsuite/gdb.base/sym-file-main.c b/gdb/testsuite/gdb.base/sym-file-main.c
> new file mode 100644
> index 0000000..f692ec5
> --- /dev/null
> +++ b/gdb/testsuite/gdb.base/sym-file-main.c
> @@ -0,0 +1,365 @@
> +/* Copyright 2013 Free Software Foundation, Inc.
> +   This program is free software; you can redistribute it and/or modify
> +   it under the terms of the GNU General Public License as published by
> +   the Free Software Foundation; either version 3 of the License, or
> +   (at your option) any later version.
> +
> +   This program is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +   GNU General Public License for more details.
> +
> +   You should have received a copy of the GNU General Public License
> +   along with this program.  If not, see <http://www.gnu.org/licenses/>.
> +*/
> +
> +#include <fcntl.h>
> +#include </usr/include/elf.h>
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <string.h>
> +#include <sys/mman.h>
> +
> +#ifdef TARGET_LP64
> +typedef Elf64_Phdr Elf_Phdr;
> +typedef Elf64_Ehdr Elf_Ehdr;
> +typedef Elf64_Shdr Elf_Shdr;
> +typedef Elf64_Sym Elf_Sym;
> +typedef Elf64_Word Elf_Word;
> +
> +unsigned char inline elf_st_type (unsigned char st_info)
> +{
> +  return ELF64_ST_TYPE (st_info);
> +}
> +#elif defined TARGET_ILP32
> +typedef Elf32_Phdr Elf_Phdr;
> +typedef Elf32_Ehdr Elf_Ehdr;
> +typedef Elf32_Shdr Elf_Shdr;
> +typedef Elf32_Sym Elf_Sym;
> +typedef Elf32_Word Elf_Word;
> +
> +unsigned char inline elf_st_type (unsigned char st_info)
> +{
> +  return ELF32_ST_TYPE (st_info);
> +}
> +#endif
> +
> +void gdb_add_symbol_file (void* addr, const char* file)
> +{
> +  return;
> +}
> +
> +void gdb_remove_symbol_file (void* addr)
> +{
> +  return;
> +}
> +
> +struct segment
> +{
> +  char* mapped_addr;
> +  Elf_Phdr* phdr;
> +  struct segment* next;
> +};
> +
> +/* Load a program segment.  */
> +
> +struct segment* load (char * addr, Elf_Phdr* phdr, struct segment* tail_seg)
> +{
> +  /* For the sake of simplicity all operations are permitted.  */
> +  unsigned perm = PROT_READ | PROT_WRITE | PROT_EXEC;
> +
> +  char* mapped_addr = (char*) mmap ((void*) phdr->p_vaddr,
> +				     phdr->p_memsz, perm,
> +				     MAP_ANONYMOUS | MAP_PRIVATE,
> +				     -1, 0);
> +
> +  void * from = (void*) (addr + phdr->p_offset);
> +  void * to = (void*) mapped_addr;
> +
> +  memcpy (to, from, phdr->p_filesz);
> +
> +  struct segment* seg = (struct segment*) malloc (sizeof (struct segment));
> +
> +  if (seg == 0)
> +    return 0;
> +
> +  seg->mapped_addr = mapped_addr;
> +  seg->phdr = phdr;
> +  seg->next = 0;
> +
> +  if (tail_seg != 0)
> +    tail_seg->next = seg;
> +
> +  return seg;
> +}
> +
> +/* Load a shared library without calling the standard loader.  */
> +
> +int load_shlib (const char *file, Elf_Ehdr **ehdr_out, struct segment **seg_out)
> +{
> +  unsigned i = 0;
> +
> +  /* Map the lib in memory for reading.  */
> +  int fd = open (file, O_RDONLY);
> +  if (fd  < 0)
> +    {
> +      perror ("fopen failed.");
> +      return -1;
> +    }
> +
> +  off_t fsize = lseek (fd, 0, SEEK_END);
> +
> +  if (fsize < 0)
> +    {
> +      perror ("lseek failed.");
> +      return -1;
> +    }
> +
> +   char* addr = (char*) mmap (NULL, fsize, PROT_READ, MAP_PRIVATE, fd, 0);
> +   if (addr == (char*) -1)
> +     {
> +       perror ("mmap failed.");
> +       return -1;
> +     }
> +
> +  /* Check if the lib is an ELF file.  */
> +  Elf_Ehdr* ehdr = (Elf_Ehdr*) addr;
> +  if (ehdr->e_ident[EI_MAG0] != ELFMAG0
> +      || ehdr->e_ident[EI_MAG1] != ELFMAG1
> +      || ehdr->e_ident[EI_MAG2] != ELFMAG2
> +      || ehdr->e_ident[EI_MAG3] != ELFMAG3)
> +    {
> +      printf ("Not an ELF file: %x\n", ehdr->e_ident[EI_MAG0]);
> +      return -1;
> +    }
> +
> +  if (ehdr->e_ident[EI_CLASS] == ELFCLASS32)
> +    {
> +      if (sizeof (int*) != 4)
> +	{
> +	  printf ("Architecture mismatch.");
> +	  return -1;
> +	}
> +    }
> +  else if (ehdr->e_ident[EI_CLASS] == ELFCLASS64)
> +    {
> +      if (sizeof (int*) != 8)
> +	{
> +	  printf ("Architecture mismatch.");
> +	  return -1;
> +	}
> +    }
> +
> +  /* Load the program segments.  For the sake of simplicity
> +     assume that no reallocation is needed.  */
> +  Elf_Phdr* phdr = (Elf_Phdr*) (addr + ehdr->e_phoff);
> +  struct segment* head_seg = 0;
> +  struct segment* tail_seg = 0;
> +  for (i=0; i < ehdr->e_phnum; i++, phdr++)
> +    {
> +      if (phdr->p_type == PT_LOAD)
> +	{
> +	  struct segment* next_seg = load (addr, phdr, tail_seg);
> +	  if (next_seg == 0)
> +	    continue;
> +	  tail_seg = next_seg;
> +	  if (head_seg == 0)
> +	    head_seg = next_seg;
> +	}
> +    }
> +  *ehdr_out = ehdr;
> +  *seg_out = head_seg;
> +  return 0;
> +}
> +
> +/* Return the section-header table.  */
> +
> +Elf_Shdr* find_shdrtab (Elf_Ehdr *ehdr)
> +{
> +  return  (Elf_Shdr*) (((char*) ehdr) + ehdr->e_shoff);
> +}
> +
> +/* Return the string table of the section headers.  */
> +
> +const char* find_shstrtab (Elf_Ehdr *ehdr, unsigned *size)
> +{
> +  const Elf_Shdr *shdr = find_shdrtab (ehdr);
> +
> +  if (ehdr->e_shnum <= ehdr->e_shstrndx)
> +    {
> +      printf ("The index of the string table is corrupt.");
> +      return NULL;
> +    }
> +  const Elf_Shdr* shstr = &shdr[ehdr->e_shstrndx];
> +  *size = shstr->sh_size;
> +  return ((const char*) ehdr) + shstr->sh_offset;
> +}
> +
> +/* Return the string table named SECTION.  */
> +
> +const char* find_strtab (Elf_Ehdr *ehdr,
> +			 const char* shstrtab, unsigned shstrtab_size,
> +			 const char* section, unsigned *strtab_size)
> +{
> +  const Elf_Shdr* shdr =  find_shdrtab (ehdr);
> +  unsigned i = 0;
> +  for (i=0; i < ehdr->e_shnum; i++)
> +    {
> +      Elf_Word name = shdr[i].sh_name;
> +      if (shdr[i].sh_type == SHT_STRTAB && name <= shstrtab_size
> +	  && strcmp ((const char*) &shstrtab[name], section) == 0)
> +	{
> +	  *strtab_size = shdr[i].sh_size;
> +	  return ((const char*) ehdr) + shdr[i].sh_offset;
> +	}
> +
> +    }
> +  return NULL;
> +}
> +
> +/* Return the section header named SECTION.  */
> +
> +Elf_Shdr* find_shdr (Elf_Ehdr* ehdr, const char *section,
> +		     const char *shstrtab, unsigned shstrtab_size)
> +{
> +  Elf_Shdr *shdr = find_shdrtab (ehdr);
> +  unsigned i = 0;
> +  for (i=0; i < ehdr->e_shnum; i++)
> +    {
> +      Elf_Word name = shdr[i].sh_name;
> +      if (name <= shstrtab_size)
> +	{
> +	  if (strcmp ((const char*) &shstrtab[name], section) == 0)
> +	    return &shdr[i];
> +	}
> +
> +    }
> +  return NULL;
> +}
> +
> +/* Return the symbol table.  */
> +
> +Elf_Sym* find_symtab (Elf_Ehdr* ehdr, unsigned *symtab_size)
> +{
> +  unsigned i = 0;
> +  const Elf_Shdr *shdr = find_shdrtab (ehdr);
> +  for (i=0; i < ehdr->e_shnum; i++)
> +    {
> +      if (shdr[i].sh_type == SHT_SYMTAB)
> +	{
> +	  *symtab_size = shdr[i].sh_size / sizeof (Elf_Sym);
> +	  return (Elf_Sym*) (((const char*) ehdr) + shdr[i].sh_offset);
> +	}
> +    }
> +  return NULL;
> +}
> +
> +/* Lookup the offset of FUNC.  */
> +
> +int lookup_function (const char *func,
> +		     Elf_Sym *symtab, unsigned symtab_size,
> +		     const char *strtab, unsigned strtab_size,
> +		     unsigned *offset)
> +{
> +  unsigned i = 0;
> +  for (i=0; i < symtab_size; i++)
> +    {
> +      Elf_Sym* sym = &symtab[i];
> +
> +      if (elf_st_type (sym->st_info) != STT_FUNC)
> +	continue;
> +
> +      if (sym->st_name < strtab_size)
> +	{
> +	  const char* name = &strtab[sym->st_name];
> +	  if (strcmp (name, func) == 0)
> +	    {
> +	      *offset = (unsigned) sym->st_value;
> +	      return 0;
> +	    }
> +       }
> +    }
> +
> +  return -1;
> +}
> +
> +/* Load a shared library without relying on the standard
> +   loader to test GDB's commands for adding and removing
> +   symbol files at runtime.  */
> +
> +int main (int argc, const char* argv[])
> +{
> +  const char *file = SHLIB_NAME;
> +
> +  Elf_Ehdr *ehdr = 0;
> +  struct segment *head_seg = 0;
> +
> +  if (load_shlib (file, &ehdr, &head_seg) != 0)
> +    return -1;
> +
> +  /* Get the string table for the section headers.  */
> +  unsigned shstrtab_size = 0;
> +  const char* shstrtab = find_shstrtab (ehdr, &shstrtab_size);
> +
> +  if (shstrtab == NULL)
> +    return -1;
> +
> +  /* Get the text section.  */
> +  Elf_Shdr* text = find_shdr (ehdr, ".text", shstrtab, shstrtab_size);
> +  if (text == NULL)
> +    return -1;
> +
> +  char* base_addr = head_seg->mapped_addr + text->sh_offset;
> +
> +  /* Notify GDB to add the symbol file.  */
> +  gdb_add_symbol_file (base_addr, file);
> +
> +  /* Get the string table for the symbols.  */
> +  unsigned strtab_size = 0;
> +  const char* strtab = find_strtab (ehdr, shstrtab, shstrtab_size,
> +				    ".strtab", &strtab_size);
> +  if (strtab == NULL)
> +    {
> +      printf (".strtab not found.");
> +      return -1;
> +    }
> +
> +  /* Get the symbol table.  */
> +  unsigned symtab_size = 0;
> +  Elf_Sym* symtab = find_symtab (ehdr, &symtab_size);
> +  if (symtab == NULL)
> +    {
> +      printf ("symtab not found.");
> +      return -1;
> +    }
> +
> +  /* Call bar from SHLIB_NAME.  */
> +  unsigned bar_offset = 0;
> +  if (lookup_function ("bar",
> +		       symtab, symtab_size,
> +		       strtab, strtab_size,
> +		       &bar_offset) != 0)
> +    return -1;
> +
> +  int (*pbar) () = (int (*) ()) (head_seg->mapped_addr + bar_offset);
> +
> +  int value1 = (*pbar) ();
> +
> +  /* Call foo from SHLIB_NAME.  */
> +  unsigned foo_offset = 0;
> +  if (lookup_function ("foo",
> +		       symtab, symtab_size,
> +		       strtab, strtab_size,
> +		       &foo_offset) != 0)
> +    return -1;
> +
> +  int (*pfoo) (int) =  (int (*) (int)) (head_seg->mapped_addr + foo_offset);
> +
> +  int value2 = (*pfoo) (2);
> +
> +  /* Notify GDB to remove the symbol file.  */
> +  gdb_remove_symbol_file (base_addr);
> +
> +  return 0;
> +}
> +
> diff --git a/gdb/testsuite/gdb.base/sym-file.exp b/gdb/testsuite/gdb.base/sym-file.exp
> new file mode 100644
> index 0000000..873e488
> --- /dev/null
> +++ b/gdb/testsuite/gdb.base/sym-file.exp
> @@ -0,0 +1,143 @@
> +# Copyright 2013 Free Software Foundation, Inc.
> +
> +# This program is free software; you can redistribute it and/or modify
> +# it under the terms of the GNU General Public License as published by
> +# the Free Software Foundation; either version 3 of the License, or
> +# (at your option) any later version.
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
> +
> +# Test adding and removing a symbol file dynamically:
> +# 1)  Run to gdb_add_symbol_file in $srcfile.
> +# 2)  Set a pending breakpoint at bar in $libsrc.
> +# 3)  Load $shlib_name using 'add-symbol-file'.
> +# 4)  Continue to bar in $libsrc.
> +# 5)  Set a breakpoint at foo in $librc.
> +# 6)  Continue to foo in $libsrc.
> +# 7)  Set a breakpoint at gdb_remove_symbol_file.
> +# 8)  Continue to gdb_remove_symbol_file in $srcfile.
> +# 9)  Remove $shlib_name using 'remove-symbol-file'.
> +# 10) Check that the breakpoints at foo and bar are pending.
> +# 11) Check that the execution can continue without error.
> +
> +if [skip_shlib_tests] {
> +    return 0
> +}
> +
> +if [is_remote target] {
> +    return 0
> +}
> +
> +set target_size TARGET_UNKNOWN
> +if [is_lp64_target] {
> +    set target_size TARGET_LP64
> +} elseif [is_ilp32_target] {
> +   set target_size TARGET_ILP32
> +} else {
> +    return 0
> +}
> +
> +set testfile sym-file.exp
> +set mainfile sym-file-main
> +set libfile sym-file-lib
> +set srcfile ${mainfile}.c
> +set libsrc "${srcdir}/${subdir}/${libfile}.c"
> +set libname "${libfile}.so"
> +set shlib_name "${objdir}/${subdir}/${libname}"
> +set libobj "${objdir}/${subdir}/${libname}"
> +set exec_opts [list debug "additional_flags=-D$target_size\
> + -DSHLIB_NAME\\=\"$shlib_name\""]
> +
> +if [get_compiler_info] {
> +    return -1
> +}
> +
> +if { [gdb_compile_shlib $libsrc $libobj {debug}] != "" } {
> +    untested ${testfile}
> +    return
> +}
> +
> +if { [prepare_for_testing ${testfile} ${mainfile} ${srcfile} $exec_opts] } {
> +    return
> +}
> +
> +# 1) Run to GDB_ADD_SYMBOl_FILE in $srcfile for adding
> +#    $shlib_name.
> +set result [runto gdb_add_symbol_file]
> +if { !$result } then {
> +   return
> +}
> +
> +# 2) Set a pending breakpoint at bar in $libsrc.
> +set result [gdb_breakpoint bar allow-pending]
> +if { !$result } then {
> +   return
> +}
> +
> +# 3) Add $shlib_name using 'add-symbol-file'.
> +set result [gdb_test "add-symbol-file ${shlib_name} addr" \
> +		     "Reading symbols from .*${shlib_name}\\.\\.\\.done\\." \
> +		     "add-symbol-file ${shlib_name} addr" \
> +		     "add symbol table from file \".*${shlib_name}\"\
> + at.*\\(y or n\\) " \
> +		     "y"]
> +if { $result != 0 } then {
> +   return
> +}
> +
> +# 4) Continue to bar in $libsrc to ensure that the breakpoint
> +#    was bound correctly after adding $shilb_name.
> +set lnum_bar [gdb_get_line_number "break at bar" ${libfile}.c]
> +gdb_continue_to_breakpoint bar ".*$libfile\\.c:$lnum_bar.*"
> +
> +# 5) Set a breakpoint at foo in $libsrc.
> +set result [gdb_breakpoint foo]
> +if { !$result } then {
> +    return
> +}
> +
> +# 6) Continue to foo in $libsrc to ensure that the breakpoint
> +#    was bound correctly.
> +set lnum_foo [gdb_get_line_number "break at foo" ${libfile}.c]
> +gdb_continue_to_breakpoint foo ".*$libfile\\.c:$lnum_foo.*"
> +
> +# 7) Set a breakpoint at gdb_remove_symbol_file in $srcfile for
> +#    removing $shlib_name.
> +set result [gdb_breakpoint gdb_remove_symbol_file]
> +if { !$result } then {
> +    return
> +}
> +
> +# 8) Continue to gdb_remove_symbol_file in $srcfile.
> +gdb_continue_to_breakpoint gdb_remove_symbol_file
> +
> +# 9) Remove $shlib_name using 'remove-symbol-file'.
> +set result [gdb_test "remove-symbol-file -a addr" \
> +		     ""\
> +     		     "remove-symbol-file -a addr" \
> +		     "Remove symbol table from file \".*${shlib_name}\"\\?\
> +.*\\(y or n\\) " \
> +		     "y"]
> +if { $result != 0 } then {
> +    return
> +}
> +
> +# 10) Check that the breakpoints at foo and bar are pending after removing
> +#     $shlib_name.
> +gdb_test "info breakpoints 2" \
> +	 ".*PENDING.*" \
> +	 "check if Breakpoint 2 is pending."
> +
> +gdb_test "info breakpoints 3" \
> +	 ".*PENDING.*" \
> +	 "check if Breakpoint 3 is pending."
> +
> +# 11) Check that the execution can continue without error.
> +gdb_continue_to_end
> +
>

Re: [patch v9 4/5] 'add-symbol-file' should update the current target sections.

[Luis Machado]

On 06/18/2013 11:47 AM, Nicolas Blanc wrote:
> 2013-17-06  Nicolas Blanc  <nicolas.blanc@intel.com>
>
> 	* symfile.c (add_target_sections_of_objfile): New function.
> 	(add_symbol_file_command): Update the current target sections.
> 	(symfile_free_objfile): New function.
> 	(_initialize_symfile): Attach observer for free_objfile.
>
> Signed-off-by: Nicolas Blanc <nicolas.blanc@intel.com>
> ---
>   gdb/symfile.c |   69 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>   1 files changed, 67 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/symfile.c b/gdb/symfile.c
> index f7ad268..33d0eda 100644
> --- a/gdb/symfile.c
> +++ b/gdb/symfile.c
> @@ -57,6 +57,7 @@
>   #include "stack.h"
>   #include "gdb_bfd.h"
>   #include "cli/cli-utils.h"
> +#include "target.h"
>
>   #include <sys/types.h>
>   #include <fcntl.h>
> @@ -2162,6 +2163,52 @@ print_transfer_performance (struct ui_file *stream,
>     ui_out_text (uiout, ".\n");
>   }
>
> +/* Add the sections of OBJFILE to the current set of target sections.  */
> +
> +static void
> +add_target_sections_of_objfile (struct objfile* objfile)

struct objfile *objfile?

> +{
> +  struct target_section_table *table = current_target_sections;
> +  struct obj_section *osect;
> +  int space;
> +  unsigned count = 0;
> +  struct target_section* ts;
> +
> +  if (objfile == NULL)
> +    return;
> +
> +  /* Compute the number of sections to add.  */
> +  ALL_OBJFILE_OSECTIONS (objfile, osect)
> +  {

Identation off.

> +    if (bfd_get_section_size (osect->the_bfd_section) == 0)
> +      continue;
> +    count++;
> +  }
> +
> +  if (count == 0)
> +    return;
> +
> +  space = resize_section_table (table, count);
> +
> +  ts = table->sections + space;
> +
> +  ALL_OBJFILE_OSECTIONS (objfile, osect)
> +  {

Identation off.

> +    if (bfd_get_section_size (osect->the_bfd_section) == 0)
> +      continue;
> +
> +    gdb_assert (ts < table->sections + space + count);
> +
> +    ts->addr = obj_section_addr (osect);
> +    ts->endaddr = obj_section_endaddr (osect);
> +    ts->the_bfd_section = osect->the_bfd_section;
> +    ts->key = (void*) objfile;
> +    ts->bfd = objfile->obfd;
> +
> +    ts++;
> +  }
> +}
> +
>   /* This function allows the addition of incrementally linked object files.
>      It does not modify any state in the target, only in the debugger.  */
>   /* Note: ezannoni 2000-04-13 This function/command used to have a
> @@ -2185,6 +2232,7 @@ add_symbol_file_command (char *args, int from_tty)
>     int expecting_sec_name = 0;
>     int expecting_sec_addr = 0;
>     char **argv;
> +  struct objfile *objf;
>
>     struct sect_opt
>     {
> @@ -2320,8 +2368,10 @@ add_symbol_file_command (char *args, int from_tty)
>     if (from_tty && (!query ("%s", "")))
>       error (_("Not confirmed."));
>
> -  symbol_file_add (filename, from_tty ? SYMFILE_VERBOSE : 0,
> -                   section_addrs, flags);
> +  objf = symbol_file_add (filename, from_tty ? SYMFILE_VERBOSE : 0,
> +			  section_addrs, flags);
> +
> +  add_target_sections_of_objfile (objf);
>
>     /* Getting new symbols may change our opinion about what is
>        frameless.  */
> @@ -3798,11 +3848,26 @@ symfile_find_segment_sections (struct objfile *objfile)
>     free_symfile_segment_data (data);
>   }
>
> +/* Listen for free_objfile events.  */
> +
> +static void
> +symfile_free_objfile (struct objfile *objfile)
> +{
> +  if (objfile == NULL)
> +    return;
> +
> +  /* Remove the target sections of user-added objfiles.  */
> +  if (objfile->flags & OBJF_USERLOADED && objfile->obfd)
> +    remove_target_sections ((void*)objfile, objfile->obfd);
> +}
> +
>   void
>   _initialize_symfile (void)
>   {
>     struct cmd_list_element *c;
>
> +  observer_attach_free_objfile (symfile_free_objfile);
> +
>     c = add_cmd ("symbol-file", class_files, symbol_file_command, _("\
>   Load symbol table from executable file FILE.\n\
>   The `file' command can also load symbol tables, as well as setting the file\n\
>

The rest looks good to me.

Re: [patch v9 5/5] Test 'info files' after 'add-symbol-file' and 'remove-symbol-file'.

[Luis Machado]

I don't have comments on this one.

On 06/18/2013 11:47 AM, Nicolas Blanc wrote:
> 2013-17-06  Nicolas Blanc  <nicolas.blanc@intel.com>
>
> gdb/testsuite
> 	* gdb.base/sym-file.exp: Test 'info files'.
>
> Signed-off-by: Nicolas Blanc <nicolas.blanc@intel.com>
> ---
>   gdb/testsuite/gdb.base/sym-file.exp |   44 ++++++++++++++++++++++------------
>   1 files changed, 28 insertions(+), 16 deletions(-)
>
> diff --git a/gdb/testsuite/gdb.base/sym-file.exp b/gdb/testsuite/gdb.base/sym-file.exp
> index 873e488..9387b95 100644
> --- a/gdb/testsuite/gdb.base/sym-file.exp
> +++ b/gdb/testsuite/gdb.base/sym-file.exp
> @@ -17,14 +17,16 @@
>   # 1)  Run to gdb_add_symbol_file in $srcfile.
>   # 2)  Set a pending breakpoint at bar in $libsrc.
>   # 3)  Load $shlib_name using 'add-symbol-file'.
> -# 4)  Continue to bar in $libsrc.
> -# 5)  Set a breakpoint at foo in $librc.
> -# 6)  Continue to foo in $libsrc.
> -# 7)  Set a breakpoint at gdb_remove_symbol_file.
> -# 8)  Continue to gdb_remove_symbol_file in $srcfile.
> -# 9)  Remove $shlib_name using 'remove-symbol-file'.
> -# 10) Check that the breakpoints at foo and bar are pending.
> -# 11) Check that the execution can continue without error.
> +# 4)  'info files' must display $libname.
> +# 5)  Continue to bar in $libsrc.
> +# 6)  Set a breakpoint at foo in $librc.
> +# 7)  Continue to foo in $libsrc.
> +# 8)  Set a breakpoint at gdb_remove_symbol_file.
> +# 9)  Continue to gdb_remove_symbol_file in $srcfile.
> +# 10) Remove $shlib_name using 'remove-symbol-file'.
> +# 11) 'info files' must not display $libname, anymore.
> +# 12) Check that the breakpoints at foo and bar are pending.
> +# 13) Check that the execution can continue without error.
>
>   if [skip_shlib_tests] {
>       return 0
> @@ -91,33 +93,38 @@ if { $result != 0 } then {
>      return
>   }
>
> -# 4) Continue to bar in $libsrc to ensure that the breakpoint
> +# 4) 'info files' must display $libname.
> +gdb_test "info files" \
> +	 "^(?=(.*${libname})).*" \
> +	 "info files must display $libname"
> +
> +# 5) Continue to bar in $libsrc to ensure that the breakpoint
>   #    was bound correctly after adding $shilb_name.
>   set lnum_bar [gdb_get_line_number "break at bar" ${libfile}.c]
>   gdb_continue_to_breakpoint bar ".*$libfile\\.c:$lnum_bar.*"
>
> -# 5) Set a breakpoint at foo in $libsrc.
> +# 6) Set a breakpoint at foo in $libsrc.
>   set result [gdb_breakpoint foo]
>   if { !$result } then {
>       return
>   }
>
> -# 6) Continue to foo in $libsrc to ensure that the breakpoint
> +# 7) Continue to foo in $libsrc to ensure that the breakpoint
>   #    was bound correctly.
>   set lnum_foo [gdb_get_line_number "break at foo" ${libfile}.c]
>   gdb_continue_to_breakpoint foo ".*$libfile\\.c:$lnum_foo.*"
>
> -# 7) Set a breakpoint at gdb_remove_symbol_file in $srcfile for
> +# 8) Set a breakpoint at gdb_remove_symbol_file in $srcfile for
>   #    removing $shlib_name.
>   set result [gdb_breakpoint gdb_remove_symbol_file]
>   if { !$result } then {
>       return
>   }
>
> -# 8) Continue to gdb_remove_symbol_file in $srcfile.
> +# 9) Continue to gdb_remove_symbol_file in $srcfile.
>   gdb_continue_to_breakpoint gdb_remove_symbol_file
>
> -# 9) Remove $shlib_name using 'remove-symbol-file'.
> +# 10) Remove $shlib_name using 'remove-symbol-file'.
>   set result [gdb_test "remove-symbol-file -a addr" \
>   		     ""\
>        		     "remove-symbol-file -a addr" \
> @@ -128,7 +135,12 @@ if { $result != 0 } then {
>       return
>   }
>
> -# 10) Check that the breakpoints at foo and bar are pending after removing
> +# 11) 'info files' must not display $libname, anymore.
> +gdb_test "info files" \
> +	 "^(?!(.*${libname})).*" \
> +	 "info files must not display ${libname}"
> +
> +# 12) Check that the breakpoints at foo and bar are pending after removing
>   #     $shlib_name.
>   gdb_test "info breakpoints 2" \
>   	 ".*PENDING.*" \
> @@ -138,6 +150,6 @@ gdb_test "info breakpoints 3" \
>   	 ".*PENDING.*" \
>   	 "check if Breakpoint 3 is pending."
>
> -# 11) Check that the execution can continue without error.
> +# 13) Check that the execution can continue without error.
>   gdb_continue_to_end
>
>

RE: [patch v9 1/5] New remove-symbol-file command.

[Blanc, Nicolas]

Hi Luis,

A colleague of mine pointed out the gdb_indent.sh script for fixing indentation issues.
So I run the script over my code and fixed the issues that it reported, but the tool did not complain about
the indentation of "macro" loops, such as below. In addition, the indentation these of loops is inconsistent in
GDB, which is really confusing.

So are you sure that the indentation below is incorrect?

Thanks,

Nicolas


>> +{
>> +  struct breakpoint *b;
>> +
>> +  if (objfile == NULL)
>> +    return;
>> +
>> +  /* If the file is a shared library not loaded by the user then
>> +     solib_unloaded was notified and disable_breakpoints_in_unloaded_shlib
>> +     was called.  In that case there is no need to take action again.  
>> + */  if ((objfile->flags & OBJF_SHARED) && !(objfile->flags & OBJF_USERLOADED))
>> +    return;
>> +
>> +  ALL_BREAKPOINTS (b)
>> +  {
>
> Identation is odd here. Should be further in.

Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052

Re: [patch v9 1/5] New remove-symbol-file command.

[Luis Machado]

On 06/19/2013 09:18 AM, Blanc, Nicolas wrote:
> Hi Luis,
>
> A colleague of mine pointed out the gdb_indent.sh script for fixing indentation issues.
> So I run the script over my code and fixed the issues that it reported, but the tool did not complain about
> the indentation of "macro" loops, such as below. In addition, the indentation these of loops is inconsistent in
> GDB, which is really confusing.
>
> So are you sure that the indentation below is incorrect?

Their use is indeed inconsistent throughout GDB. I always go with 
further identation. But i don't have a strong opinion here.

Not a blocker from a patch reviewing perspective on my part.

Thanks,
Luis