From: Luis Machado <lgustavo@codesourcery.com>
To: "Blanc, Nicolas" <nicolas.blanc@intel.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"Hafiz_Abid@mentor.com" <Hafiz_Abid@mentor.com>,
"palves@redhat.com" <palves@redhat.com>,
"tromey@redhat.com" <tromey@redhat.com>,
"eliz@gnu.org" <eliz@gnu.org>,
"yao@codesourcery.com" <yao@codesourcery.com>,
"dje@google.com" <dje@google.com>
Subject: Re: [patch v9 1/5] New remove-symbol-file command.
Date: Wed, 19 Jun 2013 13:07:00 -0000 [thread overview]
Message-ID: <51C1A2BB.6010406@codesourcery.com> (raw)
In-Reply-To: <388084C8C1E6A64FA36AD1D656E485661A7A5125@IRSMSX106.ger.corp.intel.com>
On 06/19/2013 09:18 AM, Blanc, Nicolas wrote:
> Hi Luis,
>
> A colleague of mine pointed out the gdb_indent.sh script for fixing indentation issues.
> So I run the script over my code and fixed the issues that it reported, but the tool did not complain about
> the indentation of "macro" loops, such as below. In addition, the indentation these of loops is inconsistent in
> GDB, which is really confusing.
>
> So are you sure that the indentation below is incorrect?
Their use is indeed inconsistent throughout GDB. I always go with
further identation. But i don't have a strong opinion here.
Not a blocker from a patch reviewing perspective on my part.
Thanks,
Luis
next prev parent reply other threads:[~2013-06-19 12:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 14:47 [patch v9 0/5] remove-symbol-file Nicolas Blanc
2013-06-18 14:47 ` [patch v9 1/5] New remove-symbol-file command Nicolas Blanc
2013-06-18 17:26 ` Luis Machado
2013-06-19 12:23 ` Blanc, Nicolas
2013-06-19 13:07 ` Luis Machado [this message]
2013-06-18 14:47 ` [patch v9 5/5] Test 'info files' after 'add-symbol-file' and 'remove-symbol-file' Nicolas Blanc
2013-06-18 17:53 ` Luis Machado
2013-06-18 14:47 ` [patch v9 2/5] Test adding and removing a symbol file at runtime Nicolas Blanc
2013-06-18 17:28 ` Luis Machado
2013-06-18 14:47 ` [patch v9 3/5] Documentation for the remove-symbol-file command Nicolas Blanc
2013-06-18 16:23 ` Eli Zaretskii
2013-06-18 15:04 ` [patch v9 4/5] 'add-symbol-file' should update the current target sections Nicolas Blanc
2013-06-18 17:29 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C1A2BB.6010406@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=Hafiz_Abid@mentor.com \
--cc=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=nicolas.blanc@intel.com \
--cc=palves@redhat.com \
--cc=tromey@redhat.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox