From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15952 invoked by alias); 19 Jun 2013 12:23:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15927 invoked by uid 89); 19 Jun 2013 12:23:33 -0000 X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL autolearn=ham version=3.3.1 Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 19 Jun 2013 12:23:32 +0000 Received: from svr-orw-exc-10.mgc.mentorg.com ([147.34.98.58]) by relay1.mentorg.com with esmtp id 1UpHQ9-00042t-Nj from Luis_Gustavo@mentor.com ; Wed, 19 Jun 2013 05:23:29 -0700 Received: from NA1-MAIL.mgc.mentorg.com ([147.34.98.181]) by SVR-ORW-EXC-10.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.4675); Wed, 19 Jun 2013 05:23:29 -0700 Received: from [172.30.14.165] ([172.30.14.165]) by NA1-MAIL.mgc.mentorg.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 19 Jun 2013 05:23:28 -0700 Message-ID: <51C1A2BB.6010406@codesourcery.com> Date: Wed, 19 Jun 2013 13:07:00 -0000 From: Luis Machado Reply-To: lgustavo@codesourcery.com User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: "Blanc, Nicolas" CC: "gdb-patches@sourceware.org" , "Hafiz_Abid@mentor.com" , "palves@redhat.com" , "tromey@redhat.com" , "eliz@gnu.org" , "yao@codesourcery.com" , "dje@google.com" Subject: Re: [patch v9 1/5] New remove-symbol-file command. References: <1371566833-4713-1-git-send-email-nicolas.blanc@intel.com> <1371566833-4713-2-git-send-email-nicolas.blanc@intel.com> <51C0982C.7080203@codesourcery.com> <388084C8C1E6A64FA36AD1D656E485661A7A5125@IRSMSX106.ger.corp.intel.com> In-Reply-To: <388084C8C1E6A64FA36AD1D656E485661A7A5125@IRSMSX106.ger.corp.intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2013-06/txt/msg00487.txt.bz2 On 06/19/2013 09:18 AM, Blanc, Nicolas wrote: > Hi Luis, > > A colleague of mine pointed out the gdb_indent.sh script for fixing indentation issues. > So I run the script over my code and fixed the issues that it reported, but the tool did not complain about > the indentation of "macro" loops, such as below. In addition, the indentation these of loops is inconsistent in > GDB, which is really confusing. > > So are you sure that the indentation below is incorrect? Their use is indeed inconsistent throughout GDB. I always go with further identation. But i don't have a strong opinion here. Not a blocker from a patch reviewing perspective on my part. Thanks, Luis