From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14533 invoked by alias); 19 Jun 2013 12:20:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14465 invoked by uid 89); 19 Jun 2013 12:20:42 -0000 X-Spam-SWARE-Status: No, score=-6.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.1 Received: from mga14.intel.com (HELO mga14.intel.com) (143.182.124.37) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 19 Jun 2013 12:20:41 +0000 Received: from azsmga002.ch.intel.com ([10.2.17.35]) by azsmga102.ch.intel.com with ESMTP; 19 Jun 2013 05:20:38 -0700 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by AZSMGA002.ch.intel.com with ESMTP; 19 Jun 2013 05:20:36 -0700 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.91]) by IRSMSX101.ger.corp.intel.com ([169.254.1.204]) with mapi id 14.03.0123.003; Wed, 19 Jun 2013 13:18:59 +0100 From: "Blanc, Nicolas" To: "lgustavo@codesourcery.com" CC: "gdb-patches@sourceware.org" , "Hafiz_Abid@mentor.com" , "palves@redhat.com" , "tromey@redhat.com" , "eliz@gnu.org" , "yao@codesourcery.com" , "dje@google.com" Subject: RE: [patch v9 1/5] New remove-symbol-file command. Date: Wed, 19 Jun 2013 12:23:00 -0000 Message-ID: <388084C8C1E6A64FA36AD1D656E485661A7A5125@IRSMSX106.ger.corp.intel.com> References: <1371566833-4713-1-git-send-email-nicolas.blanc@intel.com> <1371566833-4713-2-git-send-email-nicolas.blanc@intel.com> <51C0982C.7080203@codesourcery.com> In-Reply-To: <51C0982C.7080203@codesourcery.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-06/txt/msg00486.txt.bz2 Hi Luis, A colleague of mine pointed out the gdb_indent.sh script for fixing indenta= tion issues. So I run the script over my code and fixed the issues that it reported, but= the tool did not complain about the indentation of "macro" loops, such as below. In addition, the indentati= on these of loops is inconsistent in GDB, which is really confusing. So are you sure that the indentation below is incorrect? Thanks, Nicolas >> +{ >> + struct breakpoint *b; >> + >> + if (objfile =3D=3D NULL) >> + return; >> + >> + /* If the file is a shared library not loaded by the user then >> + solib_unloaded was notified and disable_breakpoints_in_unloaded_sh= lib >> + was called. In that case there is no need to take action again.= =20=20 >> + */ if ((objfile->flags & OBJF_SHARED) && !(objfile->flags & OBJF_USER= LOADED)) >> + return; >> + >> + ALL_BREAKPOINTS (b) >> + { > > Identation is odd here. Should be further in. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052