Re: [PATCH 3/4] testsuite, gdb.btrace: skip multi-inferior.exp on gdbserver targets

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2020-12-17 10:12 a.m., Markus Metzger via Gdb-patches wrote:
> The gdb.btrace/multi-inferior.exp test creates multiple inferiors to check
> that recording is per-inferior.
> 
> When run with the native-gdbserver board, this test hangs when trying to
> add the second inferior over the remote connection.  Skip the test.
> 
> Note that the test runs fine with the native-extended-gdbserver board file
> and we want to keep testing that configuration.
> 
> gdb/testsuite/ChangeLog:
> 2020-12-11  Markus Metzger  <markus.t.metzger@intel.com>
> 
> 	* gdb.btrace/multi-inferior.exp: Skip for gdbserver targets.
> ---
>  gdb/testsuite/gdb.btrace/multi-inferior.exp | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/gdb/testsuite/gdb.btrace/multi-inferior.exp b/gdb/testsuite/gdb.btrace/multi-inferior.exp
> index 23bc852c565..015c46634e5 100644
> --- a/gdb/testsuite/gdb.btrace/multi-inferior.exp
> +++ b/gdb/testsuite/gdb.btrace/multi-inferior.exp
> @@ -27,6 +27,13 @@ if { [skip_btrace_tests] } {
>      return -1
>  }
>  
> +# This test creates multiple inferiors.  This won't work with all
> +# gdbserver board files.

The comment sounds a bit confusing.  It may be interpreted as "this test
doesn't work with any gdbserver board files", but you mean "this test works
with some gdbserver board files but not all".

I think just saying "Test test creates multiple inferiors." is enough to
explain the [use_gdb_stub] check.  Stub configurations can't spawn inferiors.

Although I think it wouldn't hurt to improve the documentation of the
use_gdb_stub procedure to explain what it means, as it's a pretty opaque
concept if you don't already know it.

Otherwise, the patch LGTM.

Simon