From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bTj7G94H3V8jegAAWB0awg (envelope-from ) for ; Fri, 18 Dec 2020 14:49:50 -0500 Received: by simark.ca (Postfix, from userid 112) id 611861F0AA; Fri, 18 Dec 2020 14:49:50 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0C1C71E590 for ; Fri, 18 Dec 2020 14:49:50 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 845033938C3A; Fri, 18 Dec 2020 19:49:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 845033938C3A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1608320989; bh=E6AagUYSp/mwlx5+LRO85OJVUXXXUsSXcMeHH3xS5Fk=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=HToMPtFiIlMPOXpT6/zboWuw0bJDjw0TS/zefz8aPRxqNQSc+1WA4ijM2axhgeFuz qGfvFbT753LrpHyC3qqijFC28MRRswkUXoOT8foZ9qZwKEMkrjllxqmH73hurBQTIv LU3YXIbJQ458VjaFmkRdFmZn+PfWUEgvUPbPXXIM= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 6F9743939C21 for ; Fri, 18 Dec 2020 19:49:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6F9743939C21 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 0BIJneg5009080 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Dec 2020 14:49:45 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 0BIJneg5009080 Received: from [10.0.0.213] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E473E1E590; Fri, 18 Dec 2020 14:49:39 -0500 (EST) Subject: Re: [PATCH 3/4] testsuite, gdb.btrace: skip multi-inferior.exp on gdbserver targets To: Markus Metzger , gdb-patches@sourceware.org References: <20201217151212.1179058-1-markus.t.metzger@intel.com> <20201217151212.1179058-4-markus.t.metzger@intel.com> Message-ID: <285009da-86dc-2075-f7c8-61378948083b@polymtl.ca> Date: Fri, 18 Dec 2020 14:49:39 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <20201217151212.1179058-4-markus.t.metzger@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 18 Dec 2020 19:49:40 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-12-17 10:12 a.m., Markus Metzger via Gdb-patches wrote: > The gdb.btrace/multi-inferior.exp test creates multiple inferiors to check > that recording is per-inferior. > > When run with the native-gdbserver board, this test hangs when trying to > add the second inferior over the remote connection. Skip the test. > > Note that the test runs fine with the native-extended-gdbserver board file > and we want to keep testing that configuration. > > gdb/testsuite/ChangeLog: > 2020-12-11 Markus Metzger > > * gdb.btrace/multi-inferior.exp: Skip for gdbserver targets. > --- > gdb/testsuite/gdb.btrace/multi-inferior.exp | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/gdb/testsuite/gdb.btrace/multi-inferior.exp b/gdb/testsuite/gdb.btrace/multi-inferior.exp > index 23bc852c565..015c46634e5 100644 > --- a/gdb/testsuite/gdb.btrace/multi-inferior.exp > +++ b/gdb/testsuite/gdb.btrace/multi-inferior.exp > @@ -27,6 +27,13 @@ if { [skip_btrace_tests] } { > return -1 > } > > +# This test creates multiple inferiors. This won't work with all > +# gdbserver board files. The comment sounds a bit confusing. It may be interpreted as "this test doesn't work with any gdbserver board files", but you mean "this test works with some gdbserver board files but not all". I think just saying "Test test creates multiple inferiors." is enough to explain the [use_gdb_stub] check. Stub configurations can't spawn inferiors. Although I think it wouldn't hurt to improve the documentation of the use_gdb_stub procedure to explain what it means, as it's a pretty opaque concept if you don't already know it. Otherwise, the patch LGTM. Simon