RE: [PATCH 4/4] testsuite, gdb.btrace: fix 32-bit PIE false positives

["Metzger, Markus T via Gdb-patches" <gdb-patches@sourceware.org>]

Hello Simon,

Thanks for your review.

> > +# We expect a specific function call history.  This gets messed up with
> > +# PIE on 32-bit.
> >  standard_testfile exception.cc
> > -if [prepare_for_testing "failed to prepare" $testfile $srcfile {c++ debug}] {
> > +if [prepare_for_testing "failed to prepare" $testfile $srcfile \
> > +	{additional_flags=-fno-pie ldflags=-no-pie c++ debug}] {
> >      return -1
> >  }
> 
> There's the "nopie" option you can pass to gdb_compile to disable PIE.  Although
> from
> what I see, it doesn't add -fno-pie to compilation options, just adds -no-pie to link
> options.  I suppose you need both?  If so, it could be preferable in the long run to
> teach gdb_compile to pass -fno-pie to the compilation step as well.

Indeed, older GCC require -fno-pie in addition to -no-pie, e.g. GCC 7.5 on Ubuntu 18.04.

I changed the test to use nopie and I'll submit a new patch to add -fno-pie to the
nopie handling of gdb_compile.

Regards,
Markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928