Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Markus Metzger <markus.t.metzger@intel.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/4] testsuite, gdb.btrace: make test names unique
Date: Fri, 18 Dec 2020 14:34:10 -0500	[thread overview]
Message-ID: <05abf717-c170-79b3-1109-5eb90c712467@polymtl.ca> (raw)
In-Reply-To: <20201217151212.1179058-2-markus.t.metzger@intel.com>


> @@ -60,13 +60,13 @@ proc gdb_cont_to { threads cmd line nthreads } {
>      # the prompt precedes any further output except some errors.
>      gdb_test_multiple "$full_cmd &" "$full_cmd: prompt" {
>          -re "$gdb_prompt " {
> -            pass "$full_cmd: prompt"
> +            pass "$full_cmd ($message): prompt"
>          }
>      }

It would be preferable to use

  gdb_test_multiple "$full_cmd &" "$full_cmd ($message): prompt" {

and $gdb_test_name inside the "-re" clause, to make sure the test name
is the same regardless of the outcome.

And just a nit, I would prefer if the message was used for a
"with_test_prefix" for the whole proc, instead of putting the context
in parenthesis.

Otherwise, that all looks good to me, thanks for doing this.

Simon

  reply	other threads:[~2020-12-18 19:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17 15:12 [PATCH] gdb, record: rephrase the 'not recording' error message Markus Metzger via Gdb-patches
2020-12-17 15:12 ` [PATCH 1/4] testsuite, gdb.btrace: make test names unique Markus Metzger via Gdb-patches
2020-12-18 19:34   ` Simon Marchi via Gdb-patches [this message]
2020-12-21  7:26     ` Metzger, Markus T via Gdb-patches
2020-12-17 15:12 ` [PATCH 2/4] testsuite, gdb.python: make py-record-*.exp " Markus Metzger via Gdb-patches
2020-12-18 19:35   ` Simon Marchi via Gdb-patches
2020-12-17 15:12 ` [PATCH 3/4] testsuite, gdb.btrace: skip multi-inferior.exp on gdbserver targets Markus Metzger via Gdb-patches
2020-12-18 19:49   ` Simon Marchi via Gdb-patches
2020-12-21  7:27     ` Metzger, Markus T via Gdb-patches
2020-12-21 13:50       ` Simon Marchi via Gdb-patches
2020-12-17 15:12 ` [PATCH 4/4] testsuite, gdb.btrace: fix 32-bit PIE false positives Markus Metzger via Gdb-patches
2020-12-18 20:01   ` Simon Marchi via Gdb-patches
2020-12-21  7:27     ` Metzger, Markus T via Gdb-patches
2020-12-18 19:18 ` [PATCH] gdb, record: rephrase the 'not recording' error message Simon Marchi via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05abf717-c170-79b3-1109-5eb90c712467@polymtl.ca \
    --to=gdb-patches@sourceware.org \
    --cc=markus.t.metzger@intel.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox