From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CrVeMD4E3V+MeQAAWB0awg (envelope-from ) for ; Fri, 18 Dec 2020 14:34:22 -0500 Received: by simark.ca (Postfix, from userid 112) id B94EC1F0AA; Fri, 18 Dec 2020 14:34:22 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 57F3A1E590 for ; Fri, 18 Dec 2020 14:34:22 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A36963857004; Fri, 18 Dec 2020 19:34:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A36963857004 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1608320061; bh=oLCn9mVKrDuXhl00WtFr801i8lvuOyJAFD5Vo0BcCS4=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=h4sSNcOJ6sA4eZOq4pJgQ2KLCDFVEl56h1uEWwyMFqPaiFbI528GfpMqxEcZFrBAB /DveLBDEMzqfIDv3f4cMNX7EnujUF9ha7x61aazaVszcV0zizYDF5u7J/XdNWPEKe0 aaQytWcym1XzbKfRIZq5aqKMdBM1NjqyUo82jG1I= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id DD9753857004 for ; Fri, 18 Dec 2020 19:34:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DD9753857004 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 0BIJYAF1029042 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 18 Dec 2020 14:34:15 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 0BIJYAF1029042 Received: from [10.0.0.213] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 7658A1E590; Fri, 18 Dec 2020 14:34:10 -0500 (EST) Subject: Re: [PATCH 1/4] testsuite, gdb.btrace: make test names unique To: Markus Metzger , gdb-patches@sourceware.org References: <20201217151212.1179058-1-markus.t.metzger@intel.com> <20201217151212.1179058-2-markus.t.metzger@intel.com> Message-ID: <05abf717-c170-79b3-1109-5eb90c712467@polymtl.ca> Date: Fri, 18 Dec 2020 14:34:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <20201217151212.1179058-2-markus.t.metzger@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 18 Dec 2020 19:34:10 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > @@ -60,13 +60,13 @@ proc gdb_cont_to { threads cmd line nthreads } { > # the prompt precedes any further output except some errors. > gdb_test_multiple "$full_cmd &" "$full_cmd: prompt" { > -re "$gdb_prompt " { > - pass "$full_cmd: prompt" > + pass "$full_cmd ($message): prompt" > } > } It would be preferable to use gdb_test_multiple "$full_cmd &" "$full_cmd ($message): prompt" { and $gdb_test_name inside the "-re" clause, to make sure the test name is the same regardless of the outcome. And just a nit, I would prefer if the message was used for a "with_test_prefix" for the whole proc, instead of putting the context in parenthesis. Otherwise, that all looks good to me, thanks for doing this. Simon