RE: [PATCH 3/4] testsuite, gdb.btrace: skip multi-inferior.exp on gdbserver targets

["Metzger, Markus T via Gdb-patches" <gdb-patches@sourceware.org>]

Hello Simon,

Thanks for your review.

> > --- a/gdb/testsuite/gdb.btrace/multi-inferior.exp
> > +++ b/gdb/testsuite/gdb.btrace/multi-inferior.exp
> > @@ -27,6 +27,13 @@ if { [skip_btrace_tests] } {
> >      return -1
> >  }
> >
> > +# This test creates multiple inferiors.  This won't work with all
> > +# gdbserver board files.
> 
> The comment sounds a bit confusing.  It may be interpreted as "this test
> doesn't work with any gdbserver board files", but you mean "this test works
> with some gdbserver board files but not all".
> 
> I think just saying "Test test creates multiple inferiors." is enough to
> explain the [use_gdb_stub] check.  Stub configurations can't spawn inferiors.

I removed the comment altogether given that it now merely duplicates the code.


> Although I think it wouldn't hurt to improve the documentation of the
> use_gdb_stub procedure to explain what it means, as it's a pretty opaque
> concept if you don't already know it.

How about this [1]?  I'll send a separate patch for it.

Regards,
Markus.

[1]
---

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index e812237d67a..21c822f26a6 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -3589,6 +3589,9 @@ proc gdb_is_target_native { } {
 # This is the preferred way of checking use_gdb_stub, since it allows to check
 # the value before the gdb has been spawned and it will return the correct value
 # even when it was overriden by the test.
+#
+# Note that stub targets are not able to spawn new inferiors.  Use this
+# check for skipping respective tests.
 
 proc use_gdb_stub {} {
   global use_gdb_stub
Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928