Re: [PATCH 3/4] gdb: gdb-gdb.gdb and gdb-gdb.py in distclean

[Tom de Vries <tdevries@suse.de>]

On 9/3/26 7:37 PM, Simon Marchi wrote:
> Both gdb-gdb.gdb and gdb-gdb.py are created by configure through
> AC_CONFIG_LINKS.  When building in-tree, this does nothing.  When
> building out-of-tree, AC_CONFIG_LINKS created a link or a copy.  Either
> way, distclean should delete them but only when building out of tree.
> 

Hi Simon,

thanks for cleaning up the fallout of my two rename patches.

I've reproduced the issue:
- did in-tree build
- ran make distclean
- saw git status mention gdb/gdb-gdb.gdb as deleted

The fix LGTM.

Approved-By: Tom de Vries <tdevries@suse.de>

FWIW, I found that a further cleanup related to the rename was needed in 
the all target ( 
https://sourceware.org/pipermail/gdb-patches/2026-September/230054.html ).

Thanks,
- Tom

> Change-Id: Iceca0a6b131c97028ecbc79650f451e83a2c5aed
> ---
>   gdb/Makefile.in | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index 6fd528c71c5f..f159a510dd6d 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -2423,7 +2423,9 @@ distclean: clean
>   	@$(MAKE) $(FLAGS_TO_PASS) DO=distclean "DODIRS=$(CLEANDIRS)" subdir_do
>   	rm -f nm.h config.status config.h stamp-h b jit-reader.h stamp-nmh
>   	rm -f gcore.in gstack.in gdb-add-index.in
> -	rm -f gdb-gdb.gdb
> +	if test "$(srcdir)" != "."; then \
> +		rm -f gdb-gdb.gdb gdb-gdb.py; \
> +	fi
>   	rm -f y.output yacc.acts yacc.tmp y.tab.h
>   	rm -f config.log config.cache
>   	rm -f config.lt libtool