From: Simon Marchi <simark@simark.ca>
To: Tom de Vries <tdevries@suse.de>,
Simon Marchi <simon.marchi@efficios.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH 3/4] gdb: gdb-gdb.gdb and gdb-gdb.py in distclean
Date: Fri, 4 Sep 2026 10:07:52 -0400 [thread overview]
Message-ID: <08ae5dfb-ff15-4a86-a018-ad057057ed8c@simark.ca> (raw)
In-Reply-To: <2769f2f7-9b4d-4205-972c-a9fca2e55b8b@suse.de>
On 2026-09-04 06:48, Tom de Vries wrote:
> On 9/3/26 7:37 PM, Simon Marchi wrote:
>> Both gdb-gdb.gdb and gdb-gdb.py are created by configure through
>> AC_CONFIG_LINKS. When building in-tree, this does nothing. When
>> building out-of-tree, AC_CONFIG_LINKS created a link or a copy. Either
>> way, distclean should delete them but only when building out of tree.
>>
>
> Hi Simon,
>
> thanks for cleaning up the fallout of my two rename patches.
>
> I've reproduced the issue:
> - did in-tree build
> - ran make distclean
> - saw git status mention gdb/gdb-gdb.gdb as deleted
>
> The fix LGTM.
>
> Approved-By: Tom de Vries <tdevries@suse.de>
Thanks for testing, I pushed the series.
>
> FWIW, I found that a further cleanup related to the rename was needed in the all target ( https://sourceware.org/pipermail/gdb-patches/2026-September/230054.html ).
I'll check that.
Simon
next prev parent reply other threads:[~2026-09-04 14:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 17:37 [PATCH 0/4] Some Makefile clean target cleanups Simon Marchi
2026-09-03 17:37 ` [PATCH 1/4] gdb: remove gcore, gstack and gdb-add-index in the clean target Simon Marchi
2026-09-04 11:18 ` Tom de Vries
2026-09-03 17:37 ` [PATCH 2/4] gdbserver: remove undefined ADD_FILES from " Simon Marchi
2026-09-04 10:55 ` Tom de Vries
2026-09-03 17:37 ` [PATCH 3/4] gdb: gdb-gdb.gdb and gdb-gdb.py in distclean Simon Marchi
2026-09-04 10:48 ` Tom de Vries
2026-09-04 14:07 ` Simon Marchi [this message]
2026-09-03 17:37 ` [PATCH 4/4] gdb: remove stray "b" from the distclean target Simon Marchi
2026-09-04 10:50 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08ae5dfb-ff15-4a86-a018-ad057057ed8c@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox