Re: [PATCH 1/4] gdb: remove gcore, gstack and gdb-add-index in the clean target

[Tom de Vries <tdevries@suse.de>]

On 9/3/26 7:37 PM, Simon Marchi wrote:
> Those are created by "make", so remove them in the clean target.
> 
> On the other hand, gcore.in and gdb-add-index.in are created at
> configure time, so delete them in the distclean target (like gstack.in).
> 

LGTM.

Approved-By: Tom de Vries <tdevries@suse.de>

Thanks,
- Tom

> Change-Id: Ie5557b4e1039641dd0ff837788ff57e0e3bb30de
> ---
>   gdb/Makefile.in | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index 767f92808644..6fd528c71c5f 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -2408,6 +2408,7 @@ clean mostlyclean: $(CONFIG_CLEAN)
>   	rm -f gdb$(EXEEXT) core make.log
>   	rm -f gdb[0-9]$(EXEEXT)
>   	rm -f xml-builtin.c stamp-xml
> +	rm -f gcore gstack gdb-add-index
>   	rm -f $(addsuffix /*.o,$(CONFIG_SRC_SUBDIR))
>   	rm -f $(addsuffix /*,$(ALL_DEPDIRS))
>   	for d in $(ALL_DEPDIRS); do \
> @@ -2420,7 +2421,8 @@ clean mostlyclean: $(CONFIG_CLEAN)
>   # functionality described is if the distributed files are unmodified.
>   distclean: clean
>   	@$(MAKE) $(FLAGS_TO_PASS) DO=distclean "DODIRS=$(CLEANDIRS)" subdir_do
> -	rm -f nm.h config.status config.h stamp-h b jit-reader.h gcore gstack gstack.in stamp-nmh
> +	rm -f nm.h config.status config.h stamp-h b jit-reader.h stamp-nmh
> +	rm -f gcore.in gstack.in gdb-add-index.in
>   	rm -f gdb-gdb.gdb
>   	rm -f y.output yacc.acts yacc.tmp y.tab.h
>   	rm -f config.log config.cache