From: Tom de Vries <tdevries@suse.de>
To: Simon Marchi <simon.marchi@efficios.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] gdbserver: remove undefined ADD_FILES from the clean target
Date: Fri, 4 Sep 2026 12:55:47 +0200 [thread overview]
Message-ID: <a7bd6df7-e2d8-4538-aebd-7dc30e29840f@suse.de> (raw)
In-Reply-To: <20260903173854.416876-3-simon.marchi@efficios.com>
On 9/3/26 7:37 PM, Simon Marchi wrote:
> ADD_FILES is not defined anywhere in gdbserver, so it expands to
> nothing, drop it.
>
LGTM.
Approved-By: Tom de Vries <tdevries@suse.de>
Thanks,
- Tom
> Change-Id: I792aec1977a8daf6ce3e438c78a324b8fae4d9f0
> ---
> gdbserver/Makefile.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdbserver/Makefile.in b/gdbserver/Makefile.in
> index 5c3252d64454..aac8742a9231 100644
> --- a/gdbserver/Makefile.in
> +++ b/gdbserver/Makefile.in
> @@ -423,7 +423,7 @@ TAGS: ${TAGFILES}
> tags: TAGS
>
> mostlyclean clean:
> - rm -f *.o ${ADD_FILES} *~
> + rm -f *.o *~
> rm -f gdbserver$(EXEEXT) gdbreplay$(EXEEXT) core make.log
> rm -f $(IPA_LIB)
> rm -f *-generated.cc
next prev parent reply other threads:[~2026-09-04 10:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 17:37 [PATCH 0/4] Some Makefile clean target cleanups Simon Marchi
2026-09-03 17:37 ` [PATCH 1/4] gdb: remove gcore, gstack and gdb-add-index in the clean target Simon Marchi
2026-09-04 11:18 ` Tom de Vries
2026-09-03 17:37 ` [PATCH 2/4] gdbserver: remove undefined ADD_FILES from " Simon Marchi
2026-09-04 10:55 ` Tom de Vries [this message]
2026-09-03 17:37 ` [PATCH 3/4] gdb: gdb-gdb.gdb and gdb-gdb.py in distclean Simon Marchi
2026-09-04 10:48 ` Tom de Vries
2026-09-04 14:07 ` Simon Marchi
2026-09-03 17:37 ` [PATCH 4/4] gdb: remove stray "b" from the distclean target Simon Marchi
2026-09-04 10:50 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7bd6df7-e2d8-4538-aebd-7dc30e29840f@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox