From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id G1i1BQ+immryHigAWB0awg (envelope-from ) for ; Fri, 04 Sep 2026 06:48:47 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=DzA2tpJw; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+2cGesKl; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=dA5JRMSu; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=RwUbcKZj; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 013831E09B; Fri, 04 Sep 2026 06:48:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 236AD1E09B for ; Fri, 04 Sep 2026 06:48:46 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9A7EF46BE2CE for ; Fri, 4 Sep 2026 10:48:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9A7EF46BE2CE Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=DzA2tpJw; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+2cGesKl; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=dA5JRMSu; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=RwUbcKZj Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 992D34BCA2C9 for ; Fri, 4 Sep 2026 10:48:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 992D34BCA2C9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 992D34BCA2C9 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788518900; cv=none; b=M2+u/+vnmrPDVE5J9CnzoDqA8KHHIIyBDHDYkvE1aPbDkT99II4HtilRGa6T9AvTnT1zlxu3ZnMogcvUazVv13dnLoaiaTkTAUKsieKPPvr8qUrTJZvesejzzn9nlvgoOGVg6bLMmkD0QLO7dLZQINqBQbXlRIhpb7gh39tDGT4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788518900; c=relaxed/simple; bh=iMDBrXbaNnvPSMNIr3JW1rjSlBHYoDWqaha6Scnsx8E=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=MuOSU3eROTHvlXE+YwUjBCdzlY9gu23HzhAfUWAMiEgorNK7u1HGRjDomB0CeiAP1Hf0COo1oOJbtL0RLKprDDvXSFaof184CTLngfE95W5VKhRT9qq75K9kCDSjWRBQXbOZnu4Y5gSRXGUXJH4rllAavqmTuOWKdMkg8EJBfa4= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=DzA2tpJw; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+2cGesKl; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=dA5JRMSu; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=RwUbcKZj DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 992D34BCA2C9 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7C08D1FCE2; Fri, 4 Sep 2026 10:48:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788518895; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JOmxCJmW+4kMdFXyRjCETAmy61es9iOXlSg3r+Hahj0=; b=DzA2tpJwcAHOM83j92ANa1Yw9g+JGO8OeHPsCG12IsJvXhSeKwKVeWdls69ahhKRKfEs1o x0l/zgc6sSFBgTQEqoGYytKGBV+jgm8KNimEE/+lWzqGUekvr4kXoiYlAxY9ebLtclMVrA KDHExU2Q8G7acX6/gGojV4EhkXjwKnY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788518895; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JOmxCJmW+4kMdFXyRjCETAmy61es9iOXlSg3r+Hahj0=; b=+2cGesKlWbq9J/V7OtTZRDq2QWWVhYhnofpHWH8Ap32tUVeDrXpeM7eZWNK/qINGTI2ASX +bvij26AyZu0WbBw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1788518891; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JOmxCJmW+4kMdFXyRjCETAmy61es9iOXlSg3r+Hahj0=; b=dA5JRMSuxX+sVAsp9AM/27i/pi8kdQO3MdShfD3EKuOnso31yafldx3pGzOK1olmZZ2ch6 ekUp7LFnJ6BVWX04bwy+cYfaP7J0kO3VJGIwqFWHyb2XTdVXO0PQ3dNmPTCXSRiSsi/eLk VMAskw09KMWLkhZPlRC3ODvK60QZ6WE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1788518891; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JOmxCJmW+4kMdFXyRjCETAmy61es9iOXlSg3r+Hahj0=; b=RwUbcKZjE9+CWhusBkK4V+OYwGQt3czzpEekxnCpe38zemBFVc8O34YiSjE5SICWoZZcGi YEyZg72wbHpZEIDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5009D13736; Fri, 4 Sep 2026 10:48:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id I01PEuuhmmqFYQAAD6G6ig (envelope-from ); Fri, 04 Sep 2026 10:48:11 +0000 Message-ID: <2769f2f7-9b4d-4205-972c-a9fca2e55b8b@suse.de> Date: Fri, 4 Sep 2026 12:48:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/4] gdb: gdb-gdb.gdb and gdb-gdb.py in distclean To: Simon Marchi , gdb-patches@sourceware.org References: <20260903173854.416876-1-simon.marchi@efficios.com> <20260903173854.416876-4-simon.marchi@efficios.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20260903173854.416876-4-simon.marchi@efficios.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.996]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, suse.de:mid, suse.de:email] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 9/3/26 7:37 PM, Simon Marchi wrote: > Both gdb-gdb.gdb and gdb-gdb.py are created by configure through > AC_CONFIG_LINKS. When building in-tree, this does nothing. When > building out-of-tree, AC_CONFIG_LINKS created a link or a copy. Either > way, distclean should delete them but only when building out of tree. > Hi Simon, thanks for cleaning up the fallout of my two rename patches. I've reproduced the issue: - did in-tree build - ran make distclean - saw git status mention gdb/gdb-gdb.gdb as deleted The fix LGTM. Approved-By: Tom de Vries FWIW, I found that a further cleanup related to the rename was needed in the all target ( https://sourceware.org/pipermail/gdb-patches/2026-September/230054.html ). Thanks, - Tom > Change-Id: Iceca0a6b131c97028ecbc79650f451e83a2c5aed > --- > gdb/Makefile.in | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/gdb/Makefile.in b/gdb/Makefile.in > index 6fd528c71c5f..f159a510dd6d 100644 > --- a/gdb/Makefile.in > +++ b/gdb/Makefile.in > @@ -2423,7 +2423,9 @@ distclean: clean > @$(MAKE) $(FLAGS_TO_PASS) DO=distclean "DODIRS=$(CLEANDIRS)" subdir_do > rm -f nm.h config.status config.h stamp-h b jit-reader.h stamp-nmh > rm -f gcore.in gstack.in gdb-add-index.in > - rm -f gdb-gdb.gdb > + if test "$(srcdir)" != "."; then \ > + rm -f gdb-gdb.gdb gdb-gdb.py; \ > + fi > rm -f y.output yacc.acts yacc.tmp y.tab.h > rm -f config.log config.cache > rm -f config.lt libtool