* [PATCH] gdb/testsuite: fix comment in gdb.threads/non-ldr-exit.exp
@ 2020-12-01 4:50 Simon Marchi via Gdb-patches
2020-12-01 9:54 ` Tom de Vries
0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi via Gdb-patches @ 2020-12-01 4:50 UTC (permalink / raw)
To: gdb-patches
Maybe there's something I don't understand in that test, but the comment
seems wrong. It checks what happens when the non-leader thread does an
exit, not the leader.
gdb/testsuite/ChangeLog:
* gdb.threads/non-ldr-exit.exp: Fix comment.
Change-Id: I35c96a70c097fa9529737874f54f3f78036008a4
---
gdb/testsuite/gdb.threads/non-ldr-exit.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.threads/non-ldr-exit.exp b/gdb/testsuite/gdb.threads/non-ldr-exit.exp
index 234d74dda1a3..522ddf602093 100644
--- a/gdb/testsuite/gdb.threads/non-ldr-exit.exp
+++ b/gdb/testsuite/gdb.threads/non-ldr-exit.exp
@@ -13,7 +13,7 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-# Exit of the thread group leader should not break GDB.
+# Exit by a thread group non-leader should not break GDB.
standard_testfile
set executable ${testfile}
--
2.29.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gdb/testsuite: fix comment in gdb.threads/non-ldr-exit.exp
2020-12-01 4:50 [PATCH] gdb/testsuite: fix comment in gdb.threads/non-ldr-exit.exp Simon Marchi via Gdb-patches
@ 2020-12-01 9:54 ` Tom de Vries
2020-12-01 15:31 ` Simon Marchi via Gdb-patches
0 siblings, 1 reply; 3+ messages in thread
From: Tom de Vries @ 2020-12-01 9:54 UTC (permalink / raw)
To: Simon Marchi, gdb-patches
On 12/1/20 5:50 AM, Simon Marchi via Gdb-patches wrote:
> Maybe there's something I don't understand in that test, but the comment
> seems wrong. It checks what happens when the non-leader thread does an
> exit, not the leader.
>
I've checked both the semantics of the test-case and the commit log for
the commit adding the test-case, both agree with your observation, so LGTM.
Thanks,
- Tom
> gdb/testsuite/ChangeLog:
>
> * gdb.threads/non-ldr-exit.exp: Fix comment.
>
> Change-Id: I35c96a70c097fa9529737874f54f3f78036008a4
> ---
> gdb/testsuite/gdb.threads/non-ldr-exit.exp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.threads/non-ldr-exit.exp b/gdb/testsuite/gdb.threads/non-ldr-exit.exp
> index 234d74dda1a3..522ddf602093 100644
> --- a/gdb/testsuite/gdb.threads/non-ldr-exit.exp
> +++ b/gdb/testsuite/gdb.threads/non-ldr-exit.exp
> @@ -13,7 +13,7 @@
> # You should have received a copy of the GNU General Public License
> # along with this program. If not, see <http://www.gnu.org/licenses/>.
>
> -# Exit of the thread group leader should not break GDB.
> +# Exit by a thread group non-leader should not break GDB.
>
> standard_testfile
> set executable ${testfile}
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gdb/testsuite: fix comment in gdb.threads/non-ldr-exit.exp
2020-12-01 9:54 ` Tom de Vries
@ 2020-12-01 15:31 ` Simon Marchi via Gdb-patches
0 siblings, 0 replies; 3+ messages in thread
From: Simon Marchi via Gdb-patches @ 2020-12-01 15:31 UTC (permalink / raw)
To: Tom de Vries, gdb-patches
On 2020-12-01 4:54 a.m., Tom de Vries wrote:
>> Maybe there's something I don't understand in that test, but the comment
>> seems wrong. It checks what happens when the non-leader thread does an
>> exit, not the leader.
>>
> I've checked both the semantics of the test-case and the commit log for
> the commit adding the test-case, both agree with your observation, so LGTM.
>
> Thanks,
> - Tom
>
Thanks, I'm pushing it.
Simon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-01 15:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-01 4:50 [PATCH] gdb/testsuite: fix comment in gdb.threads/non-ldr-exit.exp Simon Marchi via Gdb-patches
2020-12-01 9:54 ` Tom de Vries
2020-12-01 15:31 ` Simon Marchi via Gdb-patches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox