Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/testsuite: fix comment in gdb.threads/non-ldr-exit.exp
Date: Tue, 1 Dec 2020 10:31:41 -0500	[thread overview]
Message-ID: <0bc25072-454e-9d4c-3494-1fbbc4d45ce4@polymtl.ca> (raw)
In-Reply-To: <0665b4b2-f704-4b85-df33-49e9a6301edc@suse.de>

On 2020-12-01 4:54 a.m., Tom de Vries wrote:
>> Maybe there's something I don't understand in that test, but the comment
>> seems wrong.  It checks what happens when the non-leader thread does an
>> exit, not the leader.
>>
> I've checked both the semantics of the test-case and the commit log for
> the commit adding the test-case, both agree with your observation, so LGTM.
> 
> Thanks,
> - Tom
> 

Thanks, I'm pushing it.

Simon

      reply	other threads:[~2020-12-01 15:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-01  4:50 Simon Marchi via Gdb-patches
2020-12-01  9:54 ` Tom de Vries
2020-12-01 15:31   ` Simon Marchi via Gdb-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0bc25072-454e-9d4c-3494-1fbbc4d45ce4@polymtl.ca \
    --to=gdb-patches@sourceware.org \
    --cc=simon.marchi@polymtl.ca \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox