From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id RISCLedhxl+OSQAAWB0awg (envelope-from ) for ; Tue, 01 Dec 2020 10:31:51 -0500 Received: by simark.ca (Postfix, from userid 112) id ADA5E1F0AB; Tue, 1 Dec 2020 10:31:51 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1E9621E58E for ; Tue, 1 Dec 2020 10:31:51 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C88C33857C46; Tue, 1 Dec 2020 15:31:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C88C33857C46 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1606836710; bh=ktWr3v5c8Flnmd0UMiGP9UEl0JcN3eb3Pmqk7dZE5Y4=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=KT+T5EF9i9FvyPlxVloT87oeiUIOAAg3PY7d3+AdJ65/7IE38A6kXrbkJVk47kR1f GFsQfUYQe5eW9vnbvXhyCX4pILIsZUxeAoJETYpqcEgyjgqgfBOi/XA2I0q7CsiKQV DleCYLQjvf14x8HsErZgUh6AmKznUrw0KEsgYAlk= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 7FAA43857009 for ; Tue, 1 Dec 2020 15:31:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7FAA43857009 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 0B1FVfLl003260 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 1 Dec 2020 10:31:46 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 0B1FVfLl003260 Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 7B7D51E58E; Tue, 1 Dec 2020 10:31:41 -0500 (EST) Subject: Re: [PATCH] gdb/testsuite: fix comment in gdb.threads/non-ldr-exit.exp To: Tom de Vries , gdb-patches@sourceware.org References: <20201201045035.1206222-1-simon.marchi@polymtl.ca> <0665b4b2-f704-4b85-df33-49e9a6301edc@suse.de> Message-ID: <0bc25072-454e-9d4c-3494-1fbbc4d45ce4@polymtl.ca> Date: Tue, 1 Dec 2020 10:31:41 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <0665b4b2-f704-4b85-df33-49e9a6301edc@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 1 Dec 2020 15:31:41 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-12-01 4:54 a.m., Tom de Vries wrote: >> Maybe there's something I don't understand in that test, but the comment >> seems wrong. It checks what happens when the non-leader thread does an >> exit, not the leader. >> > I've checked both the semantics of the test-case and the commit log for > the commit adding the test-case, both agree with your observation, so LGTM. > > Thanks, > - Tom > Thanks, I'm pushing it. Simon