From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id o7jZJL8Sxl87QgAAWB0awg (envelope-from ) for ; Tue, 01 Dec 2020 04:54:07 -0500 Received: by simark.ca (Postfix, from userid 112) id 8A6C91F0AB; Tue, 1 Dec 2020 04:54:07 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D57131E590 for ; Tue, 1 Dec 2020 04:54:06 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C41BD393D024; Tue, 1 Dec 2020 09:54:05 +0000 (GMT) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by sourceware.org (Postfix) with ESMTPS id 31BD1393D024 for ; Tue, 1 Dec 2020 09:54:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 31BD1393D024 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tdevries@suse.de X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 44DE1ACD5; Tue, 1 Dec 2020 09:54:02 +0000 (UTC) Subject: Re: [PATCH] gdb/testsuite: fix comment in gdb.threads/non-ldr-exit.exp To: Simon Marchi , gdb-patches@sourceware.org References: <20201201045035.1206222-1-simon.marchi@polymtl.ca> From: Tom de Vries Message-ID: <0665b4b2-f704-4b85-df33-49e9a6301edc@suse.de> Date: Tue, 1 Dec 2020 10:54:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201201045035.1206222-1-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 12/1/20 5:50 AM, Simon Marchi via Gdb-patches wrote: > Maybe there's something I don't understand in that test, but the comment > seems wrong. It checks what happens when the non-leader thread does an > exit, not the leader. > I've checked both the semantics of the test-case and the commit log for the commit adding the test-case, both agree with your observation, so LGTM. Thanks, - Tom > gdb/testsuite/ChangeLog: > > * gdb.threads/non-ldr-exit.exp: Fix comment. > > Change-Id: I35c96a70c097fa9529737874f54f3f78036008a4 > --- > gdb/testsuite/gdb.threads/non-ldr-exit.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.threads/non-ldr-exit.exp b/gdb/testsuite/gdb.threads/non-ldr-exit.exp > index 234d74dda1a3..522ddf602093 100644 > --- a/gdb/testsuite/gdb.threads/non-ldr-exit.exp > +++ b/gdb/testsuite/gdb.threads/non-ldr-exit.exp > @@ -13,7 +13,7 @@ > # You should have received a copy of the GNU General Public License > # along with this program. If not, see . > > -# Exit of the thread group leader should not break GDB. > +# Exit by a thread group non-leader should not break GDB. > > standard_testfile > set executable ${testfile} >