* [review] Move readline to the readline/readline subdirectory
@ 2019-10-21 18:02 Tom Tromey (Code Review)
2019-10-21 18:26 ` Simon Marchi (Code Review)
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: Tom Tromey (Code Review) @ 2019-10-21 18:02 UTC (permalink / raw)
To: gdb-patches
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180
......................................................................
Move readline to the readline/readline subdirectory
readline turns out to be a bit of a stumbling block for the project to
move gdbsupport (and then gdbserver) to the top-level.
The issue is that readline headers are intended to be included with
names like "readline/readline.h". To support this, gdb effectively
adds a -I option pointing to the top-level source directory -- but,
importantly, this option is not used when the system readline is used.
For gdbsupport, a -I option like this would always be needed, but that
in turn would break the system readline case. This was PR build/17077,
fixed in commit a8a5dbcab8df0b3a9e04745d4fe8d64740acb323.
Previously, we had discussed this on the gdb-patches list in terms of
removing readline from the tree
https://sourceware.org/ml/gdb-patches/2019-09/msg00317.html
However, Eli expressed some concerns, and Joel did as well (off-list).
Given those concerns, and the fact that a patch-free local readline is
relatively new in gdb (it was locally patched for years), I changed my
mind and decided to handle this situation by moving the readline
sources down a level.
That is, upstream readline is now in readline/readline, and the
top-level readline directory just contains the minimal configury
needed to build that.
This fixes the problem because, when gdb unconditionally adds a
-I$(top_srcdir), this will not find readline headers. A separate -I
will be needed instead, which is exactly what's needed for
--with-system-readline.
gdb/ChangeLog
2019-10-21 Tom Tromey <tom@tromey.com>
* Makefile.in (READLINE_DIR): Update.
gdb/doc/ChangeLog
2019-10-21 Tom Tromey <tom@tromey.com>
* Makefile.in (READLINE_DIR): Update.
readline/ChangeLog
2019-10-21 Tom Tromey <tom@tromey.com>
Move old contents to readline/ subdirectory.
* aclocal.m4, configure, configure.ac, .gitignore, Makefile.am,
Makefile.in, README: New files.
Change-Id: Ice156a2ee09ea68722b48f64d97146d7428ea9e4
---
M gdb/ChangeLog
M gdb/Makefile.in
M gdb/doc/ChangeLog
M gdb/doc/Makefile.in
M readline/.gitignore
A readline/ChangeLog
A readline/Makefile.am
M readline/Makefile.in
M readline/README
M readline/aclocal.m4
M readline/configure
M readline/configure.ac
A readline/readline/.gitignore
R readline/readline/CHANGELOG
R readline/readline/CHANGES
R readline/readline/COPYING
R readline/readline/ChangeLog.gdb
R readline/readline/INSTALL
R readline/readline/MANIFEST
A readline/readline/Makefile.in
R readline/readline/NEWS
A readline/readline/README
R readline/readline/USAGE
A readline/readline/aclocal.m4
R readline/readline/ansi_stdlib.h
R readline/readline/bind.c
R readline/readline/callback.c
R readline/readline/chardefs.h
R readline/readline/colors.c
R readline/readline/colors.h
R readline/readline/compat.c
R readline/readline/complete.c
R readline/readline/config.h.in
A readline/readline/configure
A readline/readline/configure.ac
R readline/readline/cross-build/cygwin.cache
R readline/readline/display.c
R readline/readline/doc/ChangeLog.gdb
R readline/readline/doc/Makefile.in
R readline/readline/doc/fdl.texi
R readline/readline/doc/history.3
R readline/readline/doc/history.texi
R readline/readline/doc/hstech.texi
R readline/readline/doc/hsuser.texi
R readline/readline/doc/readline.3
R readline/readline/doc/rlman.texi
R readline/readline/doc/rltech.texi
R readline/readline/doc/rluser.texi
R readline/readline/doc/rluserman.texi
R readline/readline/doc/texi2dvi
R readline/readline/doc/texi2html
R readline/readline/doc/version.texi
R readline/readline/emacs_keymap.c
R readline/readline/examples/ChangeLog.gdb
R readline/readline/examples/Inputrc
R readline/readline/examples/Makefile.in
R readline/readline/examples/autoconf/BASH_CHECK_LIB_TERMCAP
R readline/readline/examples/autoconf/RL_LIB_READLINE_VERSION
R readline/readline/examples/autoconf/wi_LIB_READLINE
R readline/readline/examples/excallback.c
R readline/readline/examples/fileman.c
R readline/readline/examples/hist_erasedups.c
R readline/readline/examples/hist_purgecmd.c
R readline/readline/examples/histexamp.c
R readline/readline/examples/manexamp.c
R readline/readline/examples/readlinebuf.h
R readline/readline/examples/rl-callbacktest.c
R readline/readline/examples/rl-fgets.c
R readline/readline/examples/rl.c
R readline/readline/examples/rlbasic.c
R readline/readline/examples/rlcat.c
R readline/readline/examples/rlevent.c
R readline/readline/examples/rlfe/ChangeLog
R readline/readline/examples/rlfe/ChangeLog.gdb
R readline/readline/examples/rlfe/Makefile.in
R readline/readline/examples/rlfe/README
R readline/readline/examples/rlfe/config.h.in
R readline/readline/examples/rlfe/configure
R readline/readline/examples/rlfe/configure.in
R readline/readline/examples/rlfe/extern.h
R readline/readline/examples/rlfe/os.h
R readline/readline/examples/rlfe/pty.c
R readline/readline/examples/rlfe/rlfe.c
R readline/readline/examples/rlfe/screen.h
R readline/readline/examples/rlkeymaps.c
R readline/readline/examples/rlptytest.c
R readline/readline/examples/rltest.c
R readline/readline/examples/rlversion.c
R readline/readline/funmap.c
R readline/readline/histexpand.c
R readline/readline/histfile.c
R readline/readline/histlib.h
R readline/readline/history.c
R readline/readline/history.h
R readline/readline/histsearch.c
R readline/readline/input.c
R readline/readline/isearch.c
R readline/readline/keymaps.c
R readline/readline/keymaps.h
R readline/readline/kill.c
R readline/readline/macro.c
R readline/readline/mbutil.c
R readline/readline/misc.c
R readline/readline/nls.c
R readline/readline/parens.c
R readline/readline/parse-colors.c
R readline/readline/parse-colors.h
R readline/readline/patchlevel
R readline/readline/posixdir.h
R readline/readline/posixjmp.h
R readline/readline/posixselect.h
R readline/readline/posixstat.h
R readline/readline/readline.c
R readline/readline/readline.h
R readline/readline/readline.pc.in
R readline/readline/rlconf.h
R readline/readline/rldefs.h
R readline/readline/rlmbutil.h
R readline/readline/rlprivate.h
R readline/readline/rlshell.h
R readline/readline/rlstdc.h
R readline/readline/rltty.c
R readline/readline/rltty.h
R readline/readline/rltypedefs.h
R readline/readline/rlwinsize.h
R readline/readline/savestring.c
R readline/readline/search.c
R readline/readline/shell.c
R readline/readline/shlib/Makefile.in
R readline/readline/signals.c
R readline/readline/support/config.guess
R readline/readline/support/config.rpath
R readline/readline/support/config.sub
R readline/readline/support/install.sh
R readline/readline/support/mkdirs
R readline/readline/support/mkdist
R readline/readline/support/mkinstalldirs
R readline/readline/support/shlib-install
R readline/readline/support/shobj-conf
R readline/readline/support/wcwidth.c
R readline/readline/tcap.h
R readline/readline/terminal.c
R readline/readline/text.c
R readline/readline/tilde.c
R readline/readline/tilde.h
R readline/readline/undo.c
R readline/readline/util.c
R readline/readline/vi_keymap.c
R readline/readline/vi_mode.c
R readline/readline/xfree.c
R readline/readline/xmalloc.c
R readline/readline/xmalloc.h
152 files changed, 15,590 insertions(+), 10,519 deletions(-)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [review] Move readline to the readline/readline subdirectory
2019-10-21 18:02 [review] Move readline to the readline/readline subdirectory Tom Tromey (Code Review)
@ 2019-10-21 18:26 ` Simon Marchi (Code Review)
2019-10-21 22:55 ` Tom Tromey (Code Review)
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Simon Marchi (Code Review) @ 2019-10-21 18:26 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180
......................................................................
Patch Set 1:
(1 comment)
I was able to do a build from scratch. However, when I tried to apply this patch, then type "make" or "make clean" in an existing build directory, I get:
make[2]: Entering directory '/home/smarchi/build/binutils-gdb/readline'
Making all in readline
/bin/bash: line 20: cd: readline: No such file or directory
Makefile:295: recipe for target 'all-recursive' failed
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory '/home/smarchi/build/binutils-gdb/readline'
Makefile:8132: recipe for target 'all-readline' failed
make[1]: *** [all-readline] Error 2
And I couldn't find what to do to "repair" my build directory, to make it work without having to start from scratch. Is there a way to make this case "just work", so hopefully people don't need to do anything special when they fetch this change?
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180/1/readline/README
File readline/README:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180/1/readline/README@1
PS1, Line 1: gnulib
gnulib?
^ permalink raw reply [flat|nested] 7+ messages in thread
* [review] Move readline to the readline/readline subdirectory
2019-10-21 18:02 [review] Move readline to the readline/readline subdirectory Tom Tromey (Code Review)
2019-10-21 18:26 ` Simon Marchi (Code Review)
@ 2019-10-21 22:55 ` Tom Tromey (Code Review)
2019-10-21 22:56 ` [review v2] " Tom Tromey (Code Review)
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Tom Tromey (Code Review) @ 2019-10-21 22:55 UTC (permalink / raw)
To: gdb-patches; +Cc: Simon Marchi
Tom Tromey has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180
......................................................................
Patch Set 1:
(1 comment)
> And I couldn't find what to do to "repair" my build directory, to make it work without having to start from scratch. Is there a way to make this case "just work", so hopefully people don't need to do anything special when they fetch this change?
Based on some basic testing, this seems to be an autoconf issue.
IMO it should configure the new subdirectory in this scenario, but it does not.
So, a clean build seems like the only way to go, I'm afraid.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180/1/readline/README
File readline/README:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180/1/readline/README@1
PS1, Line 1: gnulib
> gnulib?
Oops, I fixed this.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [review v2] Move readline to the readline/readline subdirectory
2019-10-21 18:02 [review] Move readline to the readline/readline subdirectory Tom Tromey (Code Review)
2019-10-21 18:26 ` Simon Marchi (Code Review)
2019-10-21 22:55 ` Tom Tromey (Code Review)
@ 2019-10-21 22:56 ` Tom Tromey (Code Review)
2019-10-21 23:00 ` Simon Marchi (Code Review)
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Tom Tromey (Code Review) @ 2019-10-21 22:56 UTC (permalink / raw)
To: gdb-patches; +Cc: Simon Marchi
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180
......................................................................
Move readline to the readline/readline subdirectory
readline turns out to be a bit of a stumbling block for the project to
move gdbsupport (and then gdbserver) to the top-level.
The issue is that readline headers are intended to be included with
names like "readline/readline.h". To support this, gdb effectively
adds a -I option pointing to the top-level source directory -- but,
importantly, this option is not used when the system readline is used.
For gdbsupport, a -I option like this would always be needed, but that
in turn would break the system readline case. This was PR build/17077,
fixed in commit a8a5dbcab8df0b3a9e04745d4fe8d64740acb323.
Previously, we had discussed this on the gdb-patches list in terms of
removing readline from the tree
https://sourceware.org/ml/gdb-patches/2019-09/msg00317.html
However, Eli expressed some concerns, and Joel did as well (off-list).
Given those concerns, and the fact that a patch-free local readline is
relatively new in gdb (it was locally patched for years), I changed my
mind and decided to handle this situation by moving the readline
sources down a level.
That is, upstream readline is now in readline/readline, and the
top-level readline directory just contains the minimal configury
needed to build that.
This fixes the problem because, when gdb unconditionally adds a
-I$(top_srcdir), this will not find readline headers. A separate -I
will be needed instead, which is exactly what's needed for
--with-system-readline.
gdb/ChangeLog
2019-10-21 Tom Tromey <tom@tromey.com>
* Makefile.in (READLINE_DIR): Update.
gdb/doc/ChangeLog
2019-10-21 Tom Tromey <tom@tromey.com>
* Makefile.in (READLINE_DIR): Update.
readline/ChangeLog
2019-10-21 Tom Tromey <tom@tromey.com>
Move old contents to readline/ subdirectory.
* aclocal.m4, configure, configure.ac, .gitignore, Makefile.am,
Makefile.in, README: New files.
Change-Id: Ice156a2ee09ea68722b48f64d97146d7428ea9e4
---
M gdb/ChangeLog
M gdb/Makefile.in
M gdb/doc/ChangeLog
M gdb/doc/Makefile.in
M readline/.gitignore
A readline/ChangeLog
A readline/Makefile.am
M readline/Makefile.in
M readline/README
M readline/aclocal.m4
M readline/configure
M readline/configure.ac
A readline/readline/.gitignore
R readline/readline/CHANGELOG
R readline/readline/CHANGES
R readline/readline/COPYING
R readline/readline/ChangeLog.gdb
R readline/readline/INSTALL
R readline/readline/MANIFEST
A readline/readline/Makefile.in
R readline/readline/NEWS
A readline/readline/README
R readline/readline/USAGE
A readline/readline/aclocal.m4
R readline/readline/ansi_stdlib.h
R readline/readline/bind.c
R readline/readline/callback.c
R readline/readline/chardefs.h
R readline/readline/colors.c
R readline/readline/colors.h
R readline/readline/compat.c
R readline/readline/complete.c
R readline/readline/config.h.in
A readline/readline/configure
A readline/readline/configure.ac
R readline/readline/cross-build/cygwin.cache
R readline/readline/display.c
R readline/readline/doc/ChangeLog.gdb
R readline/readline/doc/Makefile.in
R readline/readline/doc/fdl.texi
R readline/readline/doc/history.3
R readline/readline/doc/history.texi
R readline/readline/doc/hstech.texi
R readline/readline/doc/hsuser.texi
R readline/readline/doc/readline.3
R readline/readline/doc/rlman.texi
R readline/readline/doc/rltech.texi
R readline/readline/doc/rluser.texi
R readline/readline/doc/rluserman.texi
R readline/readline/doc/texi2dvi
R readline/readline/doc/texi2html
R readline/readline/doc/version.texi
R readline/readline/emacs_keymap.c
R readline/readline/examples/ChangeLog.gdb
R readline/readline/examples/Inputrc
R readline/readline/examples/Makefile.in
R readline/readline/examples/autoconf/BASH_CHECK_LIB_TERMCAP
R readline/readline/examples/autoconf/RL_LIB_READLINE_VERSION
R readline/readline/examples/autoconf/wi_LIB_READLINE
R readline/readline/examples/excallback.c
R readline/readline/examples/fileman.c
R readline/readline/examples/hist_erasedups.c
R readline/readline/examples/hist_purgecmd.c
R readline/readline/examples/histexamp.c
R readline/readline/examples/manexamp.c
R readline/readline/examples/readlinebuf.h
R readline/readline/examples/rl-callbacktest.c
R readline/readline/examples/rl-fgets.c
R readline/readline/examples/rl.c
R readline/readline/examples/rlbasic.c
R readline/readline/examples/rlcat.c
R readline/readline/examples/rlevent.c
R readline/readline/examples/rlfe/ChangeLog
R readline/readline/examples/rlfe/ChangeLog.gdb
R readline/readline/examples/rlfe/Makefile.in
R readline/readline/examples/rlfe/README
R readline/readline/examples/rlfe/config.h.in
R readline/readline/examples/rlfe/configure
R readline/readline/examples/rlfe/configure.in
R readline/readline/examples/rlfe/extern.h
R readline/readline/examples/rlfe/os.h
R readline/readline/examples/rlfe/pty.c
R readline/readline/examples/rlfe/rlfe.c
R readline/readline/examples/rlfe/screen.h
R readline/readline/examples/rlkeymaps.c
R readline/readline/examples/rlptytest.c
R readline/readline/examples/rltest.c
R readline/readline/examples/rlversion.c
R readline/readline/funmap.c
R readline/readline/histexpand.c
R readline/readline/histfile.c
R readline/readline/histlib.h
R readline/readline/history.c
R readline/readline/history.h
R readline/readline/histsearch.c
R readline/readline/input.c
R readline/readline/isearch.c
R readline/readline/keymaps.c
R readline/readline/keymaps.h
R readline/readline/kill.c
R readline/readline/macro.c
R readline/readline/mbutil.c
R readline/readline/misc.c
R readline/readline/nls.c
R readline/readline/parens.c
R readline/readline/parse-colors.c
R readline/readline/parse-colors.h
R readline/readline/patchlevel
R readline/readline/posixdir.h
R readline/readline/posixjmp.h
R readline/readline/posixselect.h
R readline/readline/posixstat.h
R readline/readline/readline.c
R readline/readline/readline.h
R readline/readline/readline.pc.in
R readline/readline/rlconf.h
R readline/readline/rldefs.h
R readline/readline/rlmbutil.h
R readline/readline/rlprivate.h
R readline/readline/rlshell.h
R readline/readline/rlstdc.h
R readline/readline/rltty.c
R readline/readline/rltty.h
R readline/readline/rltypedefs.h
R readline/readline/rlwinsize.h
R readline/readline/savestring.c
R readline/readline/search.c
R readline/readline/shell.c
R readline/readline/shlib/Makefile.in
R readline/readline/signals.c
R readline/readline/support/config.guess
R readline/readline/support/config.rpath
R readline/readline/support/config.sub
R readline/readline/support/install.sh
R readline/readline/support/mkdirs
R readline/readline/support/mkdist
R readline/readline/support/mkinstalldirs
R readline/readline/support/shlib-install
R readline/readline/support/shobj-conf
R readline/readline/support/wcwidth.c
R readline/readline/tcap.h
R readline/readline/terminal.c
R readline/readline/text.c
R readline/readline/tilde.c
R readline/readline/tilde.h
R readline/readline/undo.c
R readline/readline/util.c
R readline/readline/vi_keymap.c
R readline/readline/vi_mode.c
R readline/readline/xfree.c
R readline/readline/xmalloc.c
R readline/readline/xmalloc.h
152 files changed, 15,591 insertions(+), 10,519 deletions(-)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [review v2] Move readline to the readline/readline subdirectory
2019-10-21 18:02 [review] Move readline to the readline/readline subdirectory Tom Tromey (Code Review)
` (2 preceding siblings ...)
2019-10-21 22:56 ` [review v2] " Tom Tromey (Code Review)
@ 2019-10-21 23:00 ` Simon Marchi (Code Review)
2019-10-23 21:40 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-10-23 21:40 ` Sourceware to Gerrit sync (Code Review)
5 siblings, 0 replies; 7+ messages in thread
From: Simon Marchi (Code Review) @ 2019-10-21 23:00 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
> Patch Set 1:
> Based on some basic testing, this seems to be an autoconf issue.
> IMO it should configure the new subdirectory in this scenario, but it does not.
> So, a clean build seems like the only way to go, I'm afraid.
Ah, too bad :(.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180/1/readline/README
File readline/README:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180/1/readline/README@1
PS1, Line 1: gnulib
> Oops, I fixed this.
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [pushed] Move readline to the readline/readline subdirectory
2019-10-21 18:02 [review] Move readline to the readline/readline subdirectory Tom Tromey (Code Review)
` (3 preceding siblings ...)
2019-10-21 23:00 ` Simon Marchi (Code Review)
@ 2019-10-23 21:40 ` Sourceware to Gerrit sync (Code Review)
2019-10-23 21:40 ` Sourceware to Gerrit sync (Code Review)
5 siblings, 0 replies; 7+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-10-23 21:40 UTC (permalink / raw)
To: Tom Tromey, gdb-patches; +Cc: Simon Marchi
Sourceware to Gerrit sync has submitted this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180
......................................................................
Move readline to the readline/readline subdirectory
readline turns out to be a bit of a stumbling block for the project to
move gdbsupport (and then gdbserver) to the top-level.
The issue is that readline headers are intended to be included with
names like "readline/readline.h". To support this, gdb effectively
adds a -I option pointing to the top-level source directory -- but,
importantly, this option is not used when the system readline is used.
For gdbsupport, a -I option like this would always be needed, but that
in turn would break the system readline case. This was PR build/17077,
fixed in commit a8a5dbcab8df0b3a9e04745d4fe8d64740acb323.
Previously, we had discussed this on the gdb-patches list in terms of
removing readline from the tree
https://sourceware.org/ml/gdb-patches/2019-09/msg00317.html
However, Eli expressed some concerns, and Joel did as well (off-list).
Given those concerns, and the fact that a patch-free local readline is
relatively new in gdb (it was locally patched for years), I changed my
mind and decided to handle this situation by moving the readline
sources down a level.
That is, upstream readline is now in readline/readline, and the
top-level readline directory just contains the minimal configury
needed to build that.
This fixes the problem because, when gdb unconditionally adds a
-I$(top_srcdir), this will not find readline headers. A separate -I
will be needed instead, which is exactly what's needed for
--with-system-readline.
gdb/ChangeLog
2019-10-23 Tom Tromey <tom@tromey.com>
* Makefile.in (READLINE_DIR): Update.
gdb/doc/ChangeLog
2019-10-23 Tom Tromey <tom@tromey.com>
* Makefile.in (READLINE_DIR): Update.
readline/ChangeLog
2019-10-23 Tom Tromey <tom@tromey.com>
Move old contents to readline/ subdirectory.
* aclocal.m4, configure, configure.ac, .gitignore, Makefile.am,
Makefile.in, README: New files.
Change-Id: Ice156a2ee09ea68722b48f64d97146d7428ea9e4
---
M gdb/ChangeLog
M gdb/Makefile.in
M gdb/doc/ChangeLog
M gdb/doc/Makefile.in
M readline/.gitignore
A readline/ChangeLog
A readline/Makefile.am
M readline/Makefile.in
M readline/README
M readline/aclocal.m4
M readline/configure
M readline/configure.ac
A readline/readline/.gitignore
R readline/readline/CHANGELOG
R readline/readline/CHANGES
R readline/readline/COPYING
R readline/readline/ChangeLog.gdb
R readline/readline/INSTALL
R readline/readline/MANIFEST
A readline/readline/Makefile.in
R readline/readline/NEWS
A readline/readline/README
R readline/readline/USAGE
A readline/readline/aclocal.m4
R readline/readline/ansi_stdlib.h
R readline/readline/bind.c
R readline/readline/callback.c
R readline/readline/chardefs.h
R readline/readline/colors.c
R readline/readline/colors.h
R readline/readline/compat.c
R readline/readline/complete.c
R readline/readline/config.h.in
A readline/readline/configure
A readline/readline/configure.ac
R readline/readline/cross-build/cygwin.cache
R readline/readline/display.c
R readline/readline/doc/ChangeLog.gdb
R readline/readline/doc/Makefile.in
R readline/readline/doc/fdl.texi
R readline/readline/doc/history.3
R readline/readline/doc/history.texi
R readline/readline/doc/hstech.texi
R readline/readline/doc/hsuser.texi
R readline/readline/doc/readline.3
R readline/readline/doc/rlman.texi
R readline/readline/doc/rltech.texi
R readline/readline/doc/rluser.texi
R readline/readline/doc/rluserman.texi
R readline/readline/doc/texi2dvi
R readline/readline/doc/texi2html
R readline/readline/doc/version.texi
R readline/readline/emacs_keymap.c
R readline/readline/examples/ChangeLog.gdb
R readline/readline/examples/Inputrc
R readline/readline/examples/Makefile.in
R readline/readline/examples/autoconf/BASH_CHECK_LIB_TERMCAP
R readline/readline/examples/autoconf/RL_LIB_READLINE_VERSION
R readline/readline/examples/autoconf/wi_LIB_READLINE
R readline/readline/examples/excallback.c
R readline/readline/examples/fileman.c
R readline/readline/examples/hist_erasedups.c
R readline/readline/examples/hist_purgecmd.c
R readline/readline/examples/histexamp.c
R readline/readline/examples/manexamp.c
R readline/readline/examples/readlinebuf.h
R readline/readline/examples/rl-callbacktest.c
R readline/readline/examples/rl-fgets.c
R readline/readline/examples/rl.c
R readline/readline/examples/rlbasic.c
R readline/readline/examples/rlcat.c
R readline/readline/examples/rlevent.c
R readline/readline/examples/rlfe/ChangeLog
R readline/readline/examples/rlfe/ChangeLog.gdb
R readline/readline/examples/rlfe/Makefile.in
R readline/readline/examples/rlfe/README
R readline/readline/examples/rlfe/config.h.in
R readline/readline/examples/rlfe/configure
R readline/readline/examples/rlfe/configure.in
R readline/readline/examples/rlfe/extern.h
R readline/readline/examples/rlfe/os.h
R readline/readline/examples/rlfe/pty.c
R readline/readline/examples/rlfe/rlfe.c
R readline/readline/examples/rlfe/screen.h
R readline/readline/examples/rlkeymaps.c
R readline/readline/examples/rlptytest.c
R readline/readline/examples/rltest.c
R readline/readline/examples/rlversion.c
R readline/readline/funmap.c
R readline/readline/histexpand.c
R readline/readline/histfile.c
R readline/readline/histlib.h
R readline/readline/history.c
R readline/readline/history.h
R readline/readline/histsearch.c
R readline/readline/input.c
R readline/readline/isearch.c
R readline/readline/keymaps.c
R readline/readline/keymaps.h
R readline/readline/kill.c
R readline/readline/macro.c
R readline/readline/mbutil.c
R readline/readline/misc.c
R readline/readline/nls.c
R readline/readline/parens.c
R readline/readline/parse-colors.c
R readline/readline/parse-colors.h
R readline/readline/patchlevel
R readline/readline/posixdir.h
R readline/readline/posixjmp.h
R readline/readline/posixselect.h
R readline/readline/posixstat.h
R readline/readline/readline.c
R readline/readline/readline.h
R readline/readline/readline.pc.in
R readline/readline/rlconf.h
R readline/readline/rldefs.h
R readline/readline/rlmbutil.h
R readline/readline/rlprivate.h
R readline/readline/rlshell.h
R readline/readline/rlstdc.h
R readline/readline/rltty.c
R readline/readline/rltty.h
R readline/readline/rltypedefs.h
R readline/readline/rlwinsize.h
R readline/readline/savestring.c
R readline/readline/search.c
R readline/readline/shell.c
R readline/readline/shlib/Makefile.in
R readline/readline/signals.c
R readline/readline/support/config.guess
R readline/readline/support/config.rpath
R readline/readline/support/config.sub
R readline/readline/support/install.sh
R readline/readline/support/mkdirs
R readline/readline/support/mkdist
R readline/readline/support/mkinstalldirs
R readline/readline/support/shlib-install
R readline/readline/support/shobj-conf
R readline/readline/support/wcwidth.c
R readline/readline/tcap.h
R readline/readline/terminal.c
R readline/readline/text.c
R readline/readline/tilde.c
R readline/readline/tilde.h
R readline/readline/undo.c
R readline/readline/util.c
R readline/readline/vi_keymap.c
R readline/readline/vi_mode.c
R readline/readline/xfree.c
R readline/readline/xmalloc.c
R readline/readline/xmalloc.h
152 files changed, 15,591 insertions(+), 10,519 deletions(-)
^ permalink raw reply [flat|nested] 7+ messages in thread
* [pushed] Move readline to the readline/readline subdirectory
2019-10-21 18:02 [review] Move readline to the readline/readline subdirectory Tom Tromey (Code Review)
` (4 preceding siblings ...)
2019-10-23 21:40 ` [pushed] " Sourceware to Gerrit sync (Code Review)
@ 2019-10-23 21:40 ` Sourceware to Gerrit sync (Code Review)
5 siblings, 0 replies; 7+ messages in thread
From: Sourceware to Gerrit sync (Code Review) @ 2019-10-23 21:40 UTC (permalink / raw)
To: Tom Tromey, Simon Marchi, gdb-patches
The original change was created by Tom Tromey.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180
......................................................................
Move readline to the readline/readline subdirectory
readline turns out to be a bit of a stumbling block for the project to
move gdbsupport (and then gdbserver) to the top-level.
The issue is that readline headers are intended to be included with
names like "readline/readline.h". To support this, gdb effectively
adds a -I option pointing to the top-level source directory -- but,
importantly, this option is not used when the system readline is used.
For gdbsupport, a -I option like this would always be needed, but that
in turn would break the system readline case. This was PR build/17077,
fixed in commit a8a5dbcab8df0b3a9e04745d4fe8d64740acb323.
Previously, we had discussed this on the gdb-patches list in terms of
removing readline from the tree
https://sourceware.org/ml/gdb-patches/2019-09/msg00317.html
However, Eli expressed some concerns, and Joel did as well (off-list).
Given those concerns, and the fact that a patch-free local readline is
relatively new in gdb (it was locally patched for years), I changed my
mind and decided to handle this situation by moving the readline
sources down a level.
That is, upstream readline is now in readline/readline, and the
top-level readline directory just contains the minimal configury
needed to build that.
This fixes the problem because, when gdb unconditionally adds a
-I$(top_srcdir), this will not find readline headers. A separate -I
will be needed instead, which is exactly what's needed for
--with-system-readline.
gdb/ChangeLog
2019-10-23 Tom Tromey <tom@tromey.com>
* Makefile.in (READLINE_DIR): Update.
gdb/doc/ChangeLog
2019-10-23 Tom Tromey <tom@tromey.com>
* Makefile.in (READLINE_DIR): Update.
readline/ChangeLog
2019-10-23 Tom Tromey <tom@tromey.com>
Move old contents to readline/ subdirectory.
* aclocal.m4, configure, configure.ac, .gitignore, Makefile.am,
Makefile.in, README: New files.
Change-Id: Ice156a2ee09ea68722b48f64d97146d7428ea9e4
---
M gdb/ChangeLog
M gdb/Makefile.in
M gdb/doc/ChangeLog
M gdb/doc/Makefile.in
M readline/.gitignore
A readline/ChangeLog
A readline/Makefile.am
M readline/Makefile.in
M readline/README
M readline/aclocal.m4
M readline/configure
M readline/configure.ac
A readline/readline/.gitignore
R readline/readline/CHANGELOG
R readline/readline/CHANGES
R readline/readline/COPYING
R readline/readline/ChangeLog.gdb
R readline/readline/INSTALL
R readline/readline/MANIFEST
A readline/readline/Makefile.in
R readline/readline/NEWS
A readline/readline/README
R readline/readline/USAGE
A readline/readline/aclocal.m4
R readline/readline/ansi_stdlib.h
R readline/readline/bind.c
R readline/readline/callback.c
R readline/readline/chardefs.h
R readline/readline/colors.c
R readline/readline/colors.h
R readline/readline/compat.c
R readline/readline/complete.c
R readline/readline/config.h.in
A readline/readline/configure
A readline/readline/configure.ac
R readline/readline/cross-build/cygwin.cache
R readline/readline/display.c
R readline/readline/doc/ChangeLog.gdb
R readline/readline/doc/Makefile.in
R readline/readline/doc/fdl.texi
R readline/readline/doc/history.3
R readline/readline/doc/history.texi
R readline/readline/doc/hstech.texi
R readline/readline/doc/hsuser.texi
R readline/readline/doc/readline.3
R readline/readline/doc/rlman.texi
R readline/readline/doc/rltech.texi
R readline/readline/doc/rluser.texi
R readline/readline/doc/rluserman.texi
R readline/readline/doc/texi2dvi
R readline/readline/doc/texi2html
R readline/readline/doc/version.texi
R readline/readline/emacs_keymap.c
R readline/readline/examples/ChangeLog.gdb
R readline/readline/examples/Inputrc
R readline/readline/examples/Makefile.in
R readline/readline/examples/autoconf/BASH_CHECK_LIB_TERMCAP
R readline/readline/examples/autoconf/RL_LIB_READLINE_VERSION
R readline/readline/examples/autoconf/wi_LIB_READLINE
R readline/readline/examples/excallback.c
R readline/readline/examples/fileman.c
R readline/readline/examples/hist_erasedups.c
R readline/readline/examples/hist_purgecmd.c
R readline/readline/examples/histexamp.c
R readline/readline/examples/manexamp.c
R readline/readline/examples/readlinebuf.h
R readline/readline/examples/rl-callbacktest.c
R readline/readline/examples/rl-fgets.c
R readline/readline/examples/rl.c
R readline/readline/examples/rlbasic.c
R readline/readline/examples/rlcat.c
R readline/readline/examples/rlevent.c
R readline/readline/examples/rlfe/ChangeLog
R readline/readline/examples/rlfe/ChangeLog.gdb
R readline/readline/examples/rlfe/Makefile.in
R readline/readline/examples/rlfe/README
R readline/readline/examples/rlfe/config.h.in
R readline/readline/examples/rlfe/configure
R readline/readline/examples/rlfe/configure.in
R readline/readline/examples/rlfe/extern.h
R readline/readline/examples/rlfe/os.h
R readline/readline/examples/rlfe/pty.c
R readline/readline/examples/rlfe/rlfe.c
R readline/readline/examples/rlfe/screen.h
R readline/readline/examples/rlkeymaps.c
R readline/readline/examples/rlptytest.c
R readline/readline/examples/rltest.c
R readline/readline/examples/rlversion.c
R readline/readline/funmap.c
R readline/readline/histexpand.c
R readline/readline/histfile.c
R readline/readline/histlib.h
R readline/readline/history.c
R readline/readline/history.h
R readline/readline/histsearch.c
R readline/readline/input.c
R readline/readline/isearch.c
R readline/readline/keymaps.c
R readline/readline/keymaps.h
R readline/readline/kill.c
R readline/readline/macro.c
R readline/readline/mbutil.c
R readline/readline/misc.c
R readline/readline/nls.c
R readline/readline/parens.c
R readline/readline/parse-colors.c
R readline/readline/parse-colors.h
R readline/readline/patchlevel
R readline/readline/posixdir.h
R readline/readline/posixjmp.h
R readline/readline/posixselect.h
R readline/readline/posixstat.h
R readline/readline/readline.c
R readline/readline/readline.h
R readline/readline/readline.pc.in
R readline/readline/rlconf.h
R readline/readline/rldefs.h
R readline/readline/rlmbutil.h
R readline/readline/rlprivate.h
R readline/readline/rlshell.h
R readline/readline/rlstdc.h
R readline/readline/rltty.c
R readline/readline/rltty.h
R readline/readline/rltypedefs.h
R readline/readline/rlwinsize.h
R readline/readline/savestring.c
R readline/readline/search.c
R readline/readline/shell.c
R readline/readline/shlib/Makefile.in
R readline/readline/signals.c
R readline/readline/support/config.guess
R readline/readline/support/config.rpath
R readline/readline/support/config.sub
R readline/readline/support/install.sh
R readline/readline/support/mkdirs
R readline/readline/support/mkdist
R readline/readline/support/mkinstalldirs
R readline/readline/support/shlib-install
R readline/readline/support/shobj-conf
R readline/readline/support/wcwidth.c
R readline/readline/tcap.h
R readline/readline/terminal.c
R readline/readline/text.c
R readline/readline/tilde.c
R readline/readline/tilde.h
R readline/readline/undo.c
R readline/readline/util.c
R readline/readline/vi_keymap.c
R readline/readline/vi_mode.c
R readline/readline/xfree.c
R readline/readline/xmalloc.c
R readline/readline/xmalloc.h
152 files changed, 15,591 insertions(+), 10,519 deletions(-)
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-10-23 21:40 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-21 18:02 [review] Move readline to the readline/readline subdirectory Tom Tromey (Code Review)
2019-10-21 18:26 ` Simon Marchi (Code Review)
2019-10-21 22:55 ` Tom Tromey (Code Review)
2019-10-21 22:56 ` [review v2] " Tom Tromey (Code Review)
2019-10-21 23:00 ` Simon Marchi (Code Review)
2019-10-23 21:40 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-10-23 21:40 ` Sourceware to Gerrit sync (Code Review)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox