From: "Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom Tromey <tromey@sourceware.org>, gdb-patches@sourceware.org
Subject: [review v2] Move readline to the readline/readline subdirectory
Date: Mon, 21 Oct 2019 23:00:00 -0000 [thread overview]
Message-ID: <20191021230037.0CED021926@gnutoolchain-gerrit.osci.io> (raw)
In-Reply-To: <gerrit.1571680926000.Ice156a2ee09ea68722b48f64d97146d7428ea9e4@gnutoolchain-gerrit.osci.io>
Simon Marchi has posted comments on this change.
Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
> Patch Set 1:
> Based on some basic testing, this seems to be an autoconf issue.
> IMO it should configure the new subdirectory in this scenario, but it does not.
> So, a clean build seems like the only way to go, I'm afraid.
Ah, too bad :(.
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180/1/readline/README
File readline/README:
https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180/1/readline/README@1
PS1, Line 1: gnulib
> Oops, I fixed this.
Thanks.
next prev parent reply other threads:[~2019-10-21 23:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 18:02 [review] " Tom Tromey (Code Review)
2019-10-21 18:26 ` Simon Marchi (Code Review)
2019-10-21 22:55 ` Tom Tromey (Code Review)
2019-10-21 22:56 ` [review v2] " Tom Tromey (Code Review)
2019-10-21 23:00 ` Simon Marchi (Code Review) [this message]
2019-10-23 21:40 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-10-23 21:40 ` Sourceware to Gerrit sync (Code Review)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191021230037.0CED021926@gnutoolchain-gerrit.osci.io \
--to=gerrit@gnutoolchain-gerrit.osci.io \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tromey@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox