From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-159935-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16520 invoked by alias); 21 Oct 2019 23:00:43 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 16452 invoked by uid 89); 21 Oct 2019 23:00:43 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-7.9 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.1 spammy=HContent-Transfer-Encoding:8bit
X-HELO: mx1.osci.io
Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Oct 2019 23:00:41 +0000
Received: by mx1.osci.io (Postfix, from userid 994)	id 68ECC2022D; Mon, 21 Oct 2019 19:00:40 -0400 (EDT)
Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [8.43.85.239])	by mx1.osci.io (Postfix) with ESMTP id 47C932018E;	Mon, 21 Oct 2019 19:00:37 -0400 (EDT)
Received: from localhost (localhost [127.0.0.1])	by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 0CED021926;	Mon, 21 Oct 2019 19:00:37 -0400 (EDT)
X-Gerrit-PatchSet: 2
Date: Mon, 21 Oct 2019 23:00:00 -0000
From: "Simon Marchi (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
To: Tom Tromey <tromey@sourceware.org>, gdb-patches@sourceware.org
Auto-Submitted: auto-generated
X-Gerrit-MessageType: comment
Subject: [review v2] Move readline to the readline/readline subdirectory
X-Gerrit-Change-Id: Ice156a2ee09ea68722b48f64d97146d7428ea9e4
X-Gerrit-Change-Number: 180
X-Gerrit-ChangeURL: <https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180>
X-Gerrit-Commit: b994172c1c1b08507809ee29eae794e681bbe8ef
In-Reply-To: <gerrit.1571680926000.Ice156a2ee09ea68722b48f64d97146d7428ea9e4@gnutoolchain-gerrit.osci.io>
References: <gerrit.1571680926000.Ice156a2ee09ea68722b48f64d97146d7428ea9e4@gnutoolchain-gerrit.osci.io>
X-Gerrit-Comment-Date: Mon, 21 Oct 2019 19:00:36 -0400
Reply-To: simon.marchi@polymtl.ca, tromey@sourceware.org, gdb-patches@sourceware.org
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/3.0.3
Content-Type: text/plain; charset=UTF-8
Message-Id: <20191021230037.0CED021926@gnutoolchain-gerrit.osci.io>
X-SW-Source: 2019-10/txt/msg00767.txt.bz2

Simon Marchi has posted comments on this change.

Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

> Patch Set 1:
> Based on some basic testing, this seems to be an autoconf issue.
> IMO it should configure the new subdirectory in this scenario, but it does not.
> So, a clean build seems like the only way to go, I'm afraid.

Ah, too bad :(.

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180/1/readline/README 
File readline/README:

https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180/1/readline/README@1 
PS1, Line 1: gnulib
> Oops, I fixed this.
Thanks.