From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38651 invoked by alias); 21 Oct 2019 18:26:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38639 invoked by uid 89); 21 Oct 2019 18:26:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=Entering, HContent-Transfer-Encoding:8bit X-HELO: mx1.osci.io Received: from polly.osci.io (HELO mx1.osci.io) (8.43.85.229) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Oct 2019 18:26:56 +0000 Received: by mx1.osci.io (Postfix, from userid 994) id C3C7320293; Mon, 21 Oct 2019 14:26:54 -0400 (EDT) Received: from gnutoolchain-gerrit.osci.io (gnutoolchain-gerrit.osci.io [IPv6:2620:52:3:1:5054:ff:fe06:16ca]) by mx1.osci.io (Postfix) with ESMTP id 9A44B20172; Mon, 21 Oct 2019 14:26:53 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by gnutoolchain-gerrit.osci.io (Postfix) with ESMTP id 72D0D21926; Mon, 21 Oct 2019 14:26:53 -0400 (EDT) X-Gerrit-PatchSet: 1 Date: Mon, 21 Oct 2019 18:26:00 -0000 From: "Simon Marchi (Code Review)" To: Tom Tromey , gdb-patches@sourceware.org Auto-Submitted: auto-generated X-Gerrit-MessageType: comment Subject: [review] Move readline to the readline/readline subdirectory X-Gerrit-Change-Id: Ice156a2ee09ea68722b48f64d97146d7428ea9e4 X-Gerrit-Change-Number: 180 X-Gerrit-ChangeURL: X-Gerrit-Commit: 18f9f9c7fa332e8e99dfb6eace6a7802f14c6381 In-Reply-To: References: X-Gerrit-Comment-Date: Mon, 21 Oct 2019 14:26:53 -0400 Reply-To: simon.marchi@polymtl.ca, tromey@sourceware.org, gdb-patches@sourceware.org MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/3.0.3 Content-Type: text/plain; charset=UTF-8 Message-Id: <20191021182653.72D0D21926@gnutoolchain-gerrit.osci.io> X-SW-Source: 2019-10/txt/msg00736.txt.bz2 Simon Marchi has posted comments on this change. Change URL: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180 ...................................................................... Patch Set 1: (1 comment) I was able to do a build from scratch. However, when I tried to apply this patch, then type "make" or "make clean" in an existing build directory, I get: make[2]: Entering directory '/home/smarchi/build/binutils-gdb/readline' Making all in readline /bin/bash: line 20: cd: readline: No such file or directory Makefile:295: recipe for target 'all-recursive' failed make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory '/home/smarchi/build/binutils-gdb/readline' Makefile:8132: recipe for target 'all-readline' failed make[1]: *** [all-readline] Error 2 And I couldn't find what to do to "repair" my build directory, to make it work without having to start from scratch. Is there a way to make this case "just work", so hopefully people don't need to do anything special when they fetch this change? https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180/1/readline/README File readline/README: https://gnutoolchain-gerrit.osci.io/r/c/binutils-gdb/+/180/1/readline/README@1 PS1, Line 1: gnulib gnulib?