* [PATCH v3] Fix PTRACE_GETREGSET failure for compat inferiors on arm64
@ 2017-01-19 21:00 Kees Cook
2017-01-26 19:43 ` Kees Cook
2017-01-26 23:23 ` Yao Qi
0 siblings, 2 replies; 5+ messages in thread
From: Kees Cook @ 2017-01-19 21:00 UTC (permalink / raw)
To: gdb-patches; +Cc: Yao Qi, Doug Evans, brian.murray, matthias.klose
When running a 32-bit ARM inferior with a 32-bit ARM GDB on a 64-bit
AArch64 host, only VFP registers (NT_ARM_VFP) are available. The FPA
registers (NT_PRFPREG) are not available so GDB must not request them, as
this will fail with -EINVAL. This is most noticeably exposed when running
"generate-core-file":
(gdb) generate-core-file myprog.core
Unable to fetch the floating point registers.: Invalid argument.
ptrace(PTRACE_GETREGSET, 27642, NT_FPREGSET, 0xffcc67f0) = -1 EINVAL (Invalid argument)
gdb/ChangeLog:
2016-12-19 Kees Cook <keescook@google.com>
* gdb/arm-linux-nat.c: Skip soft-float registers when using hard-float.
---
v3:
- argh, actually drop needless other change.
v2:
- check have_fpa_registers instead, dropped needless other change: qiyaoltc
---
gdb/arm-linux-nat.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/gdb/arm-linux-nat.c b/gdb/arm-linux-nat.c
index d11bdc6..4fa5204 100644
--- a/gdb/arm-linux-nat.c
+++ b/gdb/arm-linux-nat.c
@@ -384,13 +384,14 @@ arm_linux_fetch_inferior_registers (struct target_ops *ops,
if (-1 == regno)
{
fetch_regs (regcache);
- fetch_fpregs (regcache);
if (tdep->have_wmmx_registers)
fetch_wmmx_regs (regcache);
if (tdep->vfp_register_count > 0)
fetch_vfp_regs (regcache);
+ if (tdep->have_fpa_registers)
+ fetch_fpregs (regcache);
}
- else
+ else
{
if (regno < ARM_F0_REGNUM || regno == ARM_PS_REGNUM)
fetch_regs (regcache);
@@ -420,11 +421,12 @@ arm_linux_store_inferior_registers (struct target_ops *ops,
if (-1 == regno)
{
store_regs (regcache);
- store_fpregs (regcache);
if (tdep->have_wmmx_registers)
store_wmmx_regs (regcache);
if (tdep->vfp_register_count > 0)
store_vfp_regs (regcache);
+ if (tdep->have_fpa_registers)
+ store_fpregs (regcache);
}
else
{
--
2.7.4
--
Kees Cook
Nexus Security
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3] Fix PTRACE_GETREGSET failure for compat inferiors on arm64
2017-01-19 21:00 [PATCH v3] Fix PTRACE_GETREGSET failure for compat inferiors on arm64 Kees Cook
@ 2017-01-26 19:43 ` Kees Cook
2017-01-26 23:23 ` Yao Qi
1 sibling, 0 replies; 5+ messages in thread
From: Kees Cook @ 2017-01-26 19:43 UTC (permalink / raw)
To: gdb-patches; +Cc: Yao Qi, Doug Evans, Brian Murray, Matthias Klose
On Thu, Jan 19, 2017 at 1:00 PM, Kees Cook <keescook@chromium.org> wrote:
> When running a 32-bit ARM inferior with a 32-bit ARM GDB on a 64-bit
> AArch64 host, only VFP registers (NT_ARM_VFP) are available. The FPA
> registers (NT_PRFPREG) are not available so GDB must not request them, as
> this will fail with -EINVAL. This is most noticeably exposed when running
> "generate-core-file":
>
> (gdb) generate-core-file myprog.core
> Unable to fetch the floating point registers.: Invalid argument.
>
> ptrace(PTRACE_GETREGSET, 27642, NT_FPREGSET, 0xffcc67f0) = -1 EINVAL (Invalid argument)
>
> gdb/ChangeLog:
>
> 2016-12-19 Kees Cook <keescook@google.com>
>
> * gdb/arm-linux-nat.c: Skip soft-float registers when using hard-float.
Hi! Friendly ping on this patch. Are there any corrections to be made,
or can someone commit it?
Thanks!
-Kees
> ---
> v3:
> - argh, actually drop needless other change.
> v2:
> - check have_fpa_registers instead, dropped needless other change: qiyaoltc
> ---
> gdb/arm-linux-nat.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/gdb/arm-linux-nat.c b/gdb/arm-linux-nat.c
> index d11bdc6..4fa5204 100644
> --- a/gdb/arm-linux-nat.c
> +++ b/gdb/arm-linux-nat.c
> @@ -384,13 +384,14 @@ arm_linux_fetch_inferior_registers (struct target_ops *ops,
> if (-1 == regno)
> {
> fetch_regs (regcache);
> - fetch_fpregs (regcache);
> if (tdep->have_wmmx_registers)
> fetch_wmmx_regs (regcache);
> if (tdep->vfp_register_count > 0)
> fetch_vfp_regs (regcache);
> + if (tdep->have_fpa_registers)
> + fetch_fpregs (regcache);
> }
> - else
> + else
> {
> if (regno < ARM_F0_REGNUM || regno == ARM_PS_REGNUM)
> fetch_regs (regcache);
> @@ -420,11 +421,12 @@ arm_linux_store_inferior_registers (struct target_ops *ops,
> if (-1 == regno)
> {
> store_regs (regcache);
> - store_fpregs (regcache);
> if (tdep->have_wmmx_registers)
> store_wmmx_regs (regcache);
> if (tdep->vfp_register_count > 0)
> store_vfp_regs (regcache);
> + if (tdep->have_fpa_registers)
> + store_fpregs (regcache);
> }
> else
> {
> --
> 2.7.4
>
>
> --
> Kees Cook
> Nexus Security
--
Kees Cook
Nexus Security
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3] Fix PTRACE_GETREGSET failure for compat inferiors on arm64
2017-01-19 21:00 [PATCH v3] Fix PTRACE_GETREGSET failure for compat inferiors on arm64 Kees Cook
2017-01-26 19:43 ` Kees Cook
@ 2017-01-26 23:23 ` Yao Qi
2017-01-26 23:37 ` Kees Cook
[not found] ` <20170127112807.GA24676@E107787-LIN>
1 sibling, 2 replies; 5+ messages in thread
From: Yao Qi @ 2017-01-26 23:23 UTC (permalink / raw)
To: Kees Cook; +Cc: gdb-patches, Doug Evans, Brian Murray, Matthias Klose
On Thu, Jan 19, 2017 at 9:00 PM, Kees Cook <keescook@chromium.org> wrote:
>
The patch is good to me, some nits below,
> gdb/ChangeLog:
>
> 2016-12-19 Kees Cook <keescook@google.com>
>
> * gdb/arm-linux-nat.c: Skip soft-float registers when using hard-float.
* gdb/arm-linux-nat.c (arm_linux_fetch_inferior_registers): Call fetch_fpregs
if target has fpa registers.
(arm_linux_store_inferior_registers): Call store_fpregs if target has
fpa registers.
> }
> - else
> + else
> {
Unnecessary change. I'll push your patch in tomorrow.
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v3] Fix PTRACE_GETREGSET failure for compat inferiors on arm64
2017-01-26 23:23 ` Yao Qi
@ 2017-01-26 23:37 ` Kees Cook
[not found] ` <20170127112807.GA24676@E107787-LIN>
1 sibling, 0 replies; 5+ messages in thread
From: Kees Cook @ 2017-01-26 23:37 UTC (permalink / raw)
To: Yao Qi; +Cc: gdb-patches, Doug Evans, Brian Murray, Matthias Klose
On Thu, Jan 26, 2017 at 3:23 PM, Yao Qi <qiyaoltc@gmail.com> wrote:
> On Thu, Jan 19, 2017 at 9:00 PM, Kees Cook <keescook@chromium.org> wrote:
>>
>
> The patch is good to me, some nits below,
>
>> gdb/ChangeLog:
>>
>> 2016-12-19 Kees Cook <keescook@google.com>
>>
>> * gdb/arm-linux-nat.c: Skip soft-float registers when using hard-float.
>
> * gdb/arm-linux-nat.c (arm_linux_fetch_inferior_registers): Call fetch_fpregs
> if target has fpa registers.
> (arm_linux_store_inferior_registers): Call store_fpregs if target has
> fpa registers.
Ah-ha, thanks!
>
>> }
>> - else
>> + else
>> {
>
> Unnecessary change. I'll push your patch in tomorrow.
Okay, I wasn't sure if whitespace/code-style fixes should be merged as
they were found.
Thanks!
-Kees
--
Kees Cook
Nexus Security
^ permalink raw reply [flat|nested] 5+ messages in thread[parent not found: <20170127112807.GA24676@E107787-LIN>]
end of thread, other threads:[~2017-01-27 20:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-19 21:00 [PATCH v3] Fix PTRACE_GETREGSET failure for compat inferiors on arm64 Kees Cook
2017-01-26 19:43 ` Kees Cook
2017-01-26 23:23 ` Yao Qi
2017-01-26 23:37 ` Kees Cook
[not found] ` <20170127112807.GA24676@E107787-LIN>
2017-01-27 20:48 ` Kees Cook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox