From: Kees Cook <keescook@chromium.org>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Doug Evans <dje@google.com>,
Brian Murray <brian.murray@canonical.com>,
Matthias Klose <matthias.klose@canonical.com>
Subject: Re: [PATCH v3] Fix PTRACE_GETREGSET failure for compat inferiors on arm64
Date: Thu, 26 Jan 2017 23:37:00 -0000 [thread overview]
Message-ID: <CAGXu5jKV28mqrU=1-zxQQoKSWk7N91scd2_7FU-g3r33tbehLQ@mail.gmail.com> (raw)
In-Reply-To: <CAH=s-PNgbtTayMYYNYgKK1kUJoS4tT_WS88EUB+EYYGEkf24qQ@mail.gmail.com>
On Thu, Jan 26, 2017 at 3:23 PM, Yao Qi <qiyaoltc@gmail.com> wrote:
> On Thu, Jan 19, 2017 at 9:00 PM, Kees Cook <keescook@chromium.org> wrote:
>>
>
> The patch is good to me, some nits below,
>
>> gdb/ChangeLog:
>>
>> 2016-12-19 Kees Cook <keescook@google.com>
>>
>> * gdb/arm-linux-nat.c: Skip soft-float registers when using hard-float.
>
> * gdb/arm-linux-nat.c (arm_linux_fetch_inferior_registers): Call fetch_fpregs
> if target has fpa registers.
> (arm_linux_store_inferior_registers): Call store_fpregs if target has
> fpa registers.
Ah-ha, thanks!
>
>> }
>> - else
>> + else
>> {
>
> Unnecessary change. I'll push your patch in tomorrow.
Okay, I wasn't sure if whitespace/code-style fixes should be merged as
they were found.
Thanks!
-Kees
--
Kees Cook
Nexus Security
next prev parent reply other threads:[~2017-01-26 23:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 21:00 Kees Cook
2017-01-26 19:43 ` Kees Cook
2017-01-26 23:23 ` Yao Qi
2017-01-26 23:37 ` Kees Cook [this message]
[not found] ` <20170127112807.GA24676@E107787-LIN>
2017-01-27 20:48 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXu5jKV28mqrU=1-zxQQoKSWk7N91scd2_7FU-g3r33tbehLQ@mail.gmail.com' \
--to=keescook@chromium.org \
--cc=brian.murray@canonical.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=matthias.klose@canonical.com \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox