From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-136553-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 8693 invoked by alias); 26 Jan 2017 23:37:18 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 8676 invoked by uid 89); 26 Jan 2017 23:37:17 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-5.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=H*f:CAH, H*i:CAH, H*f:sk:s-PNgbt, H*i:sk:EYYGEkf
X-HELO: mail-it0-f46.google.com
Received: from mail-it0-f46.google.com (HELO mail-it0-f46.google.com) (209.85.214.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Jan 2017 23:37:06 +0000
Received: by mail-it0-f46.google.com with SMTP id r185so45311329ita.0        for <gdb-patches@sourceware.org>; Thu, 26 Jan 2017 15:37:06 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=1e100.net; s=20161025;        h=x-gm-message-state:mime-version:sender:in-reply-to:references:from         :date:message-id:subject:to:cc;        bh=jNl24sLKmhVN0tQgB0rRdXNe2vhgudiTCYAivkMfXf0=;        b=Q7vQcT2oQjjVQeLnqY8v394A0Fv4FZmGgtaL368upRJWabspnH6FK6DlHAbV8/rW6Q         EAq5hmXwy0Z1xgj26XkzBFYRMXfn5BgAkgGvfSLhkIUuqmZCZoAC9Ynt1iuVUmmQlmnX         0E4XqCWZAGgGZ6fFV3pQDKVUhoxjjVjT8qP4FiOHzeVaznp2qI3BNKZ23j8xvFhZvqqO         ZIA98R67bI28cVm2Aiw1GnTzlZwBCiKjC6aeJSvjdk2ngmofy6oDgYIo4zQZtvAT5qZ0         6iVhE8qPtbMQ0s7cleqkacPjVp9UtvAR4ZucxHU5vSlubaZjdlnLWNnndTto/gW7BlBR         vT4A==
X-Gm-Message-State: AIkVDXJRmil8HRPopAv3ipIlzg6cDpeU4v2EFg6j7ZKfCbX25V7we4pFpP++dtxQRI0kiPJOW7w4vj/x0wppb7D6
X-Received: by 10.36.64.70 with SMTP id n67mr931130ita.21.1485473825257; Thu, 26 Jan 2017 15:37:05 -0800 (PST)
MIME-Version: 1.0
Received: by 10.107.143.138 with HTTP; Thu, 26 Jan 2017 15:37:04 -0800 (PST)
In-Reply-To: <CAH=s-PNgbtTayMYYNYgKK1kUJoS4tT_WS88EUB+EYYGEkf24qQ@mail.gmail.com>
References: <20170119210015.GA87383@beast> <CAH=s-PNgbtTayMYYNYgKK1kUJoS4tT_WS88EUB+EYYGEkf24qQ@mail.gmail.com>
From: Kees Cook <keescook@chromium.org>
Date: Thu, 26 Jan 2017 23:37:00 -0000
Message-ID: <CAGXu5jKV28mqrU=1-zxQQoKSWk7N91scd2_7FU-g3r33tbehLQ@mail.gmail.com>
Subject: Re: [PATCH v3] Fix PTRACE_GETREGSET failure for compat inferiors on arm64
To: Yao Qi <qiyaoltc@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>, Doug Evans <dje@google.com>, 	Brian Murray <brian.murray@canonical.com>, Matthias Klose <matthias.klose@canonical.com>
Content-Type: text/plain; charset=UTF-8
X-SW-Source: 2017-01/txt/msg00609.txt.bz2

On Thu, Jan 26, 2017 at 3:23 PM, Yao Qi <qiyaoltc@gmail.com> wrote:
> On Thu, Jan 19, 2017 at 9:00 PM, Kees Cook <keescook@chromium.org> wrote:
>>
>
> The patch is good to me, some nits below,
>
>> gdb/ChangeLog:
>>
>> 2016-12-19  Kees Cook  <keescook@google.com>
>>
>>     * gdb/arm-linux-nat.c: Skip soft-float registers when using hard-float.
>
> * gdb/arm-linux-nat.c (arm_linux_fetch_inferior_registers): Call fetch_fpregs
> if target has fpa registers.
> (arm_linux_store_inferior_registers): Call store_fpregs if target has
> fpa registers.

Ah-ha, thanks!

>
>>      }
>> -  else
>> +  else
>>      {
>
> Unnecessary change.  I'll push your patch in tomorrow.

Okay, I wasn't sure if whitespace/code-style fixes should be merged as
they were found.

Thanks!

-Kees

-- 
Kees Cook
Nexus Security