From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70746 invoked by alias); 26 Jan 2017 23:23:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70702 invoked by uid 89); 26 Jan 2017 23:23:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-2.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy==e5=b0=a7, H*MI:CAH?= X-HELO: mail-qt0-f195.google.com Received: from mail-qt0-f195.google.com (HELO mail-qt0-f195.google.com) (209.85.216.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Jan 2017 23:23:31 +0000 Received: by mail-qt0-f195.google.com with SMTP id n13so42064850qtc.0 for ; Thu, 26 Jan 2017 15:23:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=inYkTQOGNcHt8z+uTjA4PYDoqVGOikvcUgLq4KyEbRM=; b=iCadHrxq4Elamku1/9rX8UDlXhzHPRjgAQs4dtz5QNykRZZ9WdJ0DwTvQh/FIa67wI ITwUCpEoeC1LZIO7aUxjy3dCcXDggivUTJtqFetYVHOoVXcoofzPJTa8DSbboQklh1WV AwKXcAM88xIQgCy4wDqwX3FobysIRHd1ah8N08glBPQSR9548uZ8IqJzdD6FjFLCGi/v ff70TPUinGE9TIjyS+l3RL9qIt1U0lSKKtas4zHm+4DbYd4k/g/2c1xgmng8cf3HmcFD ktQOIFmvZSqwrvrH124THsbW3uThpf2YMgfqhZFzSgY5QCgrdt+7+hixJ2tR45MpqAh8 BWvA== X-Gm-Message-State: AIkVDXIdvm0CrJu/saWNKFZZ+M4DVmeJ5TQXSlydI3HubPDi838fqJXduPZ387CQaahjTATc3Uoibqst/L1HTA== X-Received: by 10.200.41.73 with SMTP id z9mr5230797qtz.137.1485473010386; Thu, 26 Jan 2017 15:23:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.140.194 with HTTP; Thu, 26 Jan 2017 15:23:30 -0800 (PST) In-Reply-To: <20170119210015.GA87383@beast> References: <20170119210015.GA87383@beast> From: Yao Qi Date: Thu, 26 Jan 2017 23:23:00 -0000 Message-ID: Subject: Re: [PATCH v3] Fix PTRACE_GETREGSET failure for compat inferiors on arm64 To: Kees Cook Cc: "gdb-patches@sourceware.org" , Doug Evans , Brian Murray , Matthias Klose Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00608.txt.bz2 On Thu, Jan 19, 2017 at 9:00 PM, Kees Cook wrote: > The patch is good to me, some nits below, > gdb/ChangeLog: > > 2016-12-19 Kees Cook > > * gdb/arm-linux-nat.c: Skip soft-float registers when using hard-floa= t. * gdb/arm-linux-nat.c (arm_linux_fetch_inferior_registers): Call fetch_fpre= gs if target has fpa registers. (arm_linux_store_inferior_registers): Call store_fpregs if target has fpa registers. > } > - else > + else > { Unnecessary change. I'll push your patch in tomorrow. --=20 Yao (=E9=BD=90=E5=B0=A7)