From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: qiyaoltc@gmail.com (Yao Qi)
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Move computed value's frame id to piece_closure
Date: Fri, 25 Nov 2016 11:48:00 -0000 [thread overview]
Message-ID: <20161125114836.530D010BCB8@oc8523832656.ibm.com> (raw)
In-Reply-To: <1480068407-22616-2-git-send-email-yao.qi@linaro.org> from "Yao Qi" at Nov 25, 2016 10:06:45 AM
Yao Qi wrote:
> + if (frame == NULL)
> + c->frame_id = null_frame_id;
> + else
> + c->frame_id = get_frame_id (get_next_frame_sentinel_okay (frame));
[...]
> + struct frame_info *frame
> + = frame_find_by_id (get_prev_frame_id_by_id (c->frame_id));
I guess now that this is a separate field, there's no longer a reason
to go via next-frame / prev-frame here. It looks like this was introduced
when VALUE_FRAME_ID was changed to VALUE_NEXT_FRAME_ID, but this isn't
really necessary for the piece logic here. I think this can simply be:
c->frame_id = get_frame_id (frame);
[...]
struct frame_info *frame = frame_find_by_id (c->frame_id);
instead.
Otherwise, this looks good to me.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2016-11-25 11:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 15:49 [PATCH 0/3] New function value_has_address Yao Qi
2016-11-22 15:49 ` [PATCH 2/3] Set VALUE_VAL before set_value_address Yao Qi
2016-11-22 17:46 ` Luis Machado
2016-11-22 18:03 ` Pedro Alves
2016-11-22 15:49 ` [PATCH 1/3] New function value_has_address Yao Qi
2016-11-22 16:50 ` Joel Brobecker
2016-11-22 17:56 ` Pedro Alves
2016-11-22 18:16 ` Ulrich Weigand
2016-11-22 18:29 ` Pedro Alves
2016-11-23 9:26 ` Yao Qi
2016-11-23 12:50 ` Ulrich Weigand
2016-11-25 10:07 ` [PATCH 0/3] regnum and next_frame_id are only used for lval_register Yao Qi
2016-11-25 10:07 ` [PATCH 3/3] Restrict checking value.lval on using address Yao Qi
2016-11-25 11:52 ` Ulrich Weigand
2016-11-28 17:22 ` Yao Qi
2016-11-25 10:07 ` [PATCH 1/3] Move computed value's frame id to piece_closure Yao Qi
2016-11-25 11:48 ` Ulrich Weigand [this message]
2016-11-28 17:20 ` Yao Qi
2016-11-25 10:07 ` [PATCH 2/3] Adjust Value.location for lval_register Yao Qi
2016-11-25 11:51 ` Ulrich Weigand
2016-11-25 11:57 ` Yao Qi
2016-11-25 12:10 ` Ulrich Weigand
2016-11-28 17:22 ` Yao Qi
2016-11-22 15:49 ` [PATCH 3/3] Restrict value_has_address Yao Qi
2016-11-22 18:06 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161125114836.530D010BCB8@oc8523832656.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox