Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: gdb-patches@sourceware.org
Subject: [PATCH 0/3] New function value_has_address
Date: Tue, 22 Nov 2016 15:49:00 -0000	[thread overview]
Message-ID: <1479829721-22162-1-git-send-email-yao.qi@linaro.org> (raw)

This patch series is inspired by the discussion in this thread
https://sourceware.org/ml/gdb-patches/2016-10/msg00741.html in which
I only added value_has_address.  During the discussion, looks
value_has_address should be true only for lval_memory and lval_register,
then, I restrict value_has_address (done in patch #3), and trigger a
lot of assertions, because VALUE_VAL is not set properly before
set_value_address.  Patch #2 fixes these problems.

Patch series is regression tested on x86_64-linux.

Note that, I also find that value_has_address may only return true
for lval_memory, because I can't see how VALUE->location.address is valid
to lval_register.  Of course, I can be wrong, so further analysis
is needed.

*** BLURB HERE ***

Yao Qi (3):
  New function value_has_address
  Set VALUE_VAL before set_value_address
  Restrict value_has_address

 gdb/ada-lang.c |  2 +-
 gdb/elfread.c  |  2 ++
 gdb/value.c    | 27 ++++++++++++++++-----------
 3 files changed, 19 insertions(+), 12 deletions(-)

-- 
1.9.1


             reply	other threads:[~2016-11-22 15:49 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-22 15:49 Yao Qi [this message]
2016-11-22 15:49 ` [PATCH 2/3] Set VALUE_VAL before set_value_address Yao Qi
2016-11-22 17:46   ` Luis Machado
2016-11-22 18:03   ` Pedro Alves
2016-11-22 15:49 ` [PATCH 3/3] Restrict value_has_address Yao Qi
2016-11-22 18:06   ` Pedro Alves
2016-11-22 15:49 ` [PATCH 1/3] New function value_has_address Yao Qi
2016-11-22 16:50   ` Joel Brobecker
2016-11-22 17:56     ` Pedro Alves
2016-11-22 18:16       ` Ulrich Weigand
2016-11-22 18:29         ` Pedro Alves
2016-11-23  9:26         ` Yao Qi
2016-11-23 12:50           ` Ulrich Weigand
2016-11-25 10:07             ` [PATCH 0/3] regnum and next_frame_id are only used for lval_register Yao Qi
2016-11-25 10:07               ` [PATCH 1/3] Move computed value's frame id to piece_closure Yao Qi
2016-11-25 11:48                 ` Ulrich Weigand
2016-11-28 17:20                   ` Yao Qi
2016-11-25 10:07               ` [PATCH 2/3] Adjust Value.location for lval_register Yao Qi
2016-11-25 11:51                 ` Ulrich Weigand
2016-11-25 11:57                   ` Yao Qi
2016-11-25 12:10                     ` Ulrich Weigand
2016-11-28 17:22                       ` Yao Qi
2016-11-25 10:07               ` [PATCH 3/3] Restrict checking value.lval on using address Yao Qi
2016-11-25 11:52                 ` Ulrich Weigand
2016-11-28 17:22                   ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1479829721-22162-1-git-send-email-yao.qi@linaro.org \
    --to=qiyaoltc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox