From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105773 invoked by alias); 25 Nov 2016 11:48:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105760 invoked by uid 89); 25 Nov 2016 11:48:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RCVD_IN_SEMBACKSCATTER,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0a-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.156.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Nov 2016 11:48:45 +0000 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uAPBi6ET038302 for ; Fri, 25 Nov 2016 06:48:44 -0500 Received: from e06smtp10.uk.ibm.com (e06smtp10.uk.ibm.com [195.75.94.106]) by mx0a-001b2d01.pphosted.com with ESMTP id 26xg53c8ak-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 25 Nov 2016 06:48:43 -0500 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 25 Nov 2016 11:48:41 -0000 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 25 Nov 2016 11:48:38 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id C8E0717D8056 for ; Fri, 25 Nov 2016 11:51:06 +0000 (GMT) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id uAPBmckT27525306 for ; Fri, 25 Nov 2016 11:48:38 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id uAPBmb5f025070 for ; Fri, 25 Nov 2016 06:48:37 -0500 Received: from oc8523832656.ibm.com (icon-9-167-232-32.megacenter.de.ibm.com [9.167.232.32]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id uAPBmbir025067; Fri, 25 Nov 2016 06:48:37 -0500 Received: by oc8523832656.ibm.com (Postfix, from userid 500) id 530D010BCB8; Fri, 25 Nov 2016 12:48:36 +0100 (CET) Subject: Re: [PATCH 1/3] Move computed value's frame id to piece_closure To: qiyaoltc@gmail.com (Yao Qi) Date: Fri, 25 Nov 2016 11:48:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <1480068407-22616-2-git-send-email-yao.qi@linaro.org> from "Yao Qi" at Nov 25, 2016 10:06:45 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16112511-0040-0000-0000-000002699CB8 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16112511-0041-0000-0000-000022B6E5E4 Message-Id: <20161125114836.530D010BCB8@oc8523832656.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-25_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611250207 X-SW-Source: 2016-11/txt/msg00798.txt.bz2 Yao Qi wrote: > + if (frame == NULL) > + c->frame_id = null_frame_id; > + else > + c->frame_id = get_frame_id (get_next_frame_sentinel_okay (frame)); [...] > + struct frame_info *frame > + = frame_find_by_id (get_prev_frame_id_by_id (c->frame_id)); I guess now that this is a separate field, there's no longer a reason to go via next-frame / prev-frame here. It looks like this was introduced when VALUE_FRAME_ID was changed to VALUE_NEXT_FRAME_ID, but this isn't really necessary for the piece logic here. I think this can simply be: c->frame_id = get_frame_id (frame); [...] struct frame_info *frame = frame_find_by_id (c->frame_id); instead. Otherwise, this looks good to me. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com