[pushed] [BUILDROBOT] makeinfo fails (was: [pushed] [PATCH V4] Add support for bound table in the Intel MPX context.)

[pushed] [BUILDROBOT] makeinfo fails (was: [pushed] [PATCH V4] Add support for bound table in the Intel MPX context.)

[Tedeschi, Walfred]

Joel,

Pushed the fix.
The final changes were slightly different from what I proposed. Basically incorporating two of your comments.
I still think that we could improve the error message to help user understand what is wrong. 
In fact I did not want to wait longer to have a fix for the builds.

In case you have comments on that commit please let me know I will fix it immediately!

THANKS A LOT!!!

Best regards,
-Fred

-----Original Message-----
From: Joel Brobecker [mailto:brobecker@adacore.com] 
Sent: Thursday, June 11, 2015 8:12 PM
To: Jan-Benedict Glaw
Cc: Tedeschi, Walfred; gdb-patches@sourceware.org
Subject: Re: [BUILDROBOT] makeinfo fails (was: [pushed] [PATCH V4] Add support for bound table in the Intel MPX context.)

> > I am sorry, for that. 
> > BTW: Also got a message from BUILDBOT that I caused issues on 32bit builds.
> > I am working to fix it!
> 
> Additional to what GDB'ish BUILDBOT may have found, I also see general
> breakages due to a wrongly moved @end table in the docs (just a first
> glance, I'm not sure so I'm not promoting an own patch to fix it.)

Ah yes, I think the patch that was sent includes a documentation
fix as well, and was approved. That documentation fix should go in
on its own, and right away.

-- 
Joel
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052

Re: [pushed] [BUILDROBOT] makeinfo fails (was: [pushed] [PATCH V4] Add support for bound table in the Intel MPX context.)

[Joel Brobecker]

> Pushed the fix.
> The final changes were slightly different from what I proposed.
> Basically incorporating two of your comments.
> I still think that we could improve the error message to help user
> understand what is wrong. 
> In fact I did not want to wait longer to have a fix for the builds.
> 
> In case you have comments on that commit please let me know I will fix
> it immediately!

I agree that a more informative error message would be welcome;
that is: explain which feature is not supported, and why it is not.

For the emergency fix, it looks good to me, modulo the above.
Procedurally, when someone pushes a patch that's different from
the one that was previously sent, it's customary to email the patch
to this mailing-list as well, just for archiving and also to give
everyone an opportunity to react to it, just in case.

-- 
Joel

RE: [pushed] [BUILDROBOT] makeinfo fails (was: [pushed] [PATCH V4] Add support for bound table in the Intel MPX context.)

[Tedeschi, Walfred]

Joel,

I will improve the error message and will send you a patch.
Will send for review by moday/Tuesday.

I still can send it as post pushed, so people can contribute to it.

Thanks a lot again,
-Fred

-----Original Message-----
From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Joel Brobecker
Sent: Friday, June 12, 2015 2:55 PM
To: Tedeschi, Walfred
Cc: Jan-Benedict Glaw; gdb-patches@sourceware.org
Subject: Re: [pushed] [BUILDROBOT] makeinfo fails (was: [pushed] [PATCH V4] Add support for bound table in the Intel MPX context.)

> Pushed the fix.
> The final changes were slightly different from what I proposed.
> Basically incorporating two of your comments.
> I still think that we could improve the error message to help user 
> understand what is wrong.
> In fact I did not want to wait longer to have a fix for the builds.
> 
> In case you have comments on that commit please let me know I will fix 
> it immediately!

I agree that a more informative error message would be welcome; that is: explain which feature is not supported, and why it is not.

For the emergency fix, it looks good to me, modulo the above.
Procedurally, when someone pushes a patch that's different from the one that was previously sent, it's customary to email the patch to this mailing-list as well, just for archiving and also to give everyone an opportunity to react to it, just in case.

--
Joel
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052