From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92898 invoked by alias); 12 Jun 2015 13:10:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92886 invoked by uid 89); 12 Jun 2015 13:10:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mga03.intel.com Received: from mga03.intel.com (HELO mga03.intel.com) (134.134.136.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 12 Jun 2015 13:10:01 +0000 Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP; 12 Jun 2015 06:09:57 -0700 X-ExtLoop1: 1 Received: from irsmsx153.ger.corp.intel.com ([163.33.192.75]) by orsmga003.jf.intel.com with ESMTP; 12 Jun 2015 06:09:56 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.171]) by IRSMSX153.ger.corp.intel.com ([169.254.9.95]) with mapi id 14.03.0224.002; Fri, 12 Jun 2015 14:09:55 +0100 From: "Tedeschi, Walfred" To: Joel Brobecker CC: Jan-Benedict Glaw , "gdb-patches@sourceware.org" Subject: RE: [pushed] [BUILDROBOT] makeinfo fails (was: [pushed] [PATCH V4] Add support for bound table in the Intel MPX context.) Date: Fri, 12 Jun 2015 13:10:00 -0000 Message-ID: References: <20150612125439.GA2609@adacore.com> In-Reply-To: <20150612125439.GA2609@adacore.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00255.txt.bz2 Joel, I will improve the error message and will send you a patch. Will send for review by moday/Tuesday. I still can send it as post pushed, so people can contribute to it. Thanks a lot again, -Fred -----Original Message----- From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-owner@sourceware= .org] On Behalf Of Joel Brobecker Sent: Friday, June 12, 2015 2:55 PM To: Tedeschi, Walfred Cc: Jan-Benedict Glaw; gdb-patches@sourceware.org Subject: Re: [pushed] [BUILDROBOT] makeinfo fails (was: [pushed] [PATCH V4]= Add support for bound table in the Intel MPX context.) > Pushed the fix. > The final changes were slightly different from what I proposed. > Basically incorporating two of your comments. > I still think that we could improve the error message to help user=20 > understand what is wrong. > In fact I did not want to wait longer to have a fix for the builds. >=20 > In case you have comments on that commit please let me know I will fix=20 > it immediately! I agree that a more informative error message would be welcome; that is: ex= plain which feature is not supported, and why it is not. For the emergency fix, it looks good to me, modulo the above. Procedurally, when someone pushes a patch that's different from the one tha= t was previously sent, it's customary to email the patch to this mailing-li= st as well, just for archiving and also to give everyone an opportunity to = react to it, just in case. -- Joel Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052