From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55210 invoked by alias); 12 Jun 2015 12:54:43 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55198 invoked by uid 89); 12 Jun 2015 12:54:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_05,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 12 Jun 2015 12:54:42 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 18C0E2878A; Fri, 12 Jun 2015 08:54:40 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id e4UHJ6ZVpwFD; Fri, 12 Jun 2015 08:54:40 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 0846D286D7; Fri, 12 Jun 2015 08:54:39 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8F96848276; Fri, 12 Jun 2015 08:54:39 -0400 (EDT) Date: Fri, 12 Jun 2015 12:54:00 -0000 From: Joel Brobecker To: "Tedeschi, Walfred" Cc: Jan-Benedict Glaw , "gdb-patches@sourceware.org" Subject: Re: [pushed] [BUILDROBOT] makeinfo fails (was: [pushed] [PATCH V4] Add support for bound table in the Intel MPX context.) Message-ID: <20150612125439.GA2609@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-SW-Source: 2015-06/txt/msg00253.txt.bz2 > Pushed the fix. > The final changes were slightly different from what I proposed. > Basically incorporating two of your comments. > I still think that we could improve the error message to help user > understand what is wrong. > In fact I did not want to wait longer to have a fix for the builds. > > In case you have comments on that commit please let me know I will fix > it immediately! I agree that a more informative error message would be welcome; that is: explain which feature is not supported, and why it is not. For the emergency fix, it looks good to me, modulo the above. Procedurally, when someone pushes a patch that's different from the one that was previously sent, it's customary to email the patch to this mailing-list as well, just for archiving and also to give everyone an opportunity to react to it, just in case. -- Joel