From: Joel Brobecker <brobecker@adacore.com>
To: "Tedeschi, Walfred" <walfred.tedeschi@intel.com>
Cc: Jan-Benedict Glaw <jbglaw@lug-owl.de>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [pushed] [BUILDROBOT] makeinfo fails (was: [pushed] [PATCH V4] Add support for bound table in the Intel MPX context.)
Date: Fri, 12 Jun 2015 12:54:00 -0000 [thread overview]
Message-ID: <20150612125439.GA2609@adacore.com> (raw)
In-Reply-To: <AC542571535E904D8E8ADAE745D60B194442AD4B@IRSMSX104.ger.corp.intel.com>
> Pushed the fix.
> The final changes were slightly different from what I proposed.
> Basically incorporating two of your comments.
> I still think that we could improve the error message to help user
> understand what is wrong.
> In fact I did not want to wait longer to have a fix for the builds.
>
> In case you have comments on that commit please let me know I will fix
> it immediately!
I agree that a more informative error message would be welcome;
that is: explain which feature is not supported, and why it is not.
For the emergency fix, it looks good to me, modulo the above.
Procedurally, when someone pushes a patch that's different from
the one that was previously sent, it's customary to email the patch
to this mailing-list as well, just for archiving and also to give
everyone an opportunity to react to it, just in case.
--
Joel
next prev parent reply other threads:[~2015-06-12 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-12 7:50 Tedeschi, Walfred
2015-06-12 12:54 ` Joel Brobecker [this message]
2015-06-12 13:10 ` Tedeschi, Walfred
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150612125439.GA2609@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jbglaw@lug-owl.de \
--cc=walfred.tedeschi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox