From: Kyle McMartin <kmcmarti@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv5] aarch64: detect atomic sequences like other ll/sc architectures
Date: Wed, 07 May 2014 15:10:00 -0000 [thread overview]
Message-ID: <20140507151022.GQ674@redacted.bos.redhat.com> (raw)
In-Reply-To: <20140507135217.GC4063@adacore.com>
On Wed, May 07, 2014 at 06:52:17AM -0700, Joel Brobecker wrote:
> > + struct gdbarch *gdbarch = get_frame_arch (frame);
> > + struct address_space *aspace = get_frame_address_space (frame);
> > + enum bfd_endian byte_order_for_code = gdbarch_byte_order_for_code (gdbarch);
>
> AndrewP said that the code is always LE, so why not just use
> BFD_ENDIAN_LITTLE in this case, rather than go through
> byte_order_for_code?
>
Seemed sensible to do what aarch64_analyze_prologue did, rather than
hard code it... I'm happy one way or another though.
regards, Kyle
next prev parent reply other threads:[~2014-05-07 15:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 18:35 [PATCHv4] " Kyle McMartin
2014-04-24 18:39 ` Andrew Pinski
2014-04-24 18:51 ` Kyle McMartin
2014-04-30 16:04 ` [PATCHv5] " Kyle McMartin
2014-05-07 13:52 ` Joel Brobecker
2014-05-07 15:10 ` Kyle McMartin [this message]
2014-05-07 16:41 ` Andrew Pinski
2014-05-07 16:46 ` Joel Brobecker
2014-05-07 18:12 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140507151022.GQ674@redacted.bos.redhat.com \
--to=kmcmarti@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox