From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32165 invoked by alias); 7 May 2014 15:10:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32151 invoked by uid 89); 7 May 2014 15:10:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 May 2014 15:10:31 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s47FAP8V014997 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 7 May 2014 11:10:26 -0400 Received: from redacted.bos.redhat.com ([10.18.17.143]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s47FANFU025389 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 7 May 2014 11:10:24 -0400 Date: Wed, 07 May 2014 15:10:00 -0000 From: Kyle McMartin To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv5] aarch64: detect atomic sequences like other ll/sc architectures Message-ID: <20140507151022.GQ674@redacted.bos.redhat.com> References: <20140424183510.GI7588@redacted.bos.redhat.com> <20140430160450.GE2148@redacted.bos.redhat.com> <20140507135217.GC4063@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140507135217.GC4063@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-05/txt/msg00067.txt.bz2 On Wed, May 07, 2014 at 06:52:17AM -0700, Joel Brobecker wrote: > > + struct gdbarch *gdbarch = get_frame_arch (frame); > > + struct address_space *aspace = get_frame_address_space (frame); > > + enum bfd_endian byte_order_for_code = gdbarch_byte_order_for_code (gdbarch); > > AndrewP said that the code is always LE, so why not just use > BFD_ENDIAN_LITTLE in this case, rather than go through > byte_order_for_code? > Seemed sensible to do what aarch64_analyze_prologue did, rather than hard code it... I'm happy one way or another though. regards, Kyle