Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Kyle McMartin <kmcmarti@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv5] aarch64: detect atomic sequences like other ll/sc architectures
Date: Wed, 07 May 2014 16:46:00 -0000	[thread overview]
Message-ID: <20140507164611.GD4063@adacore.com> (raw)
In-Reply-To: <20140507151022.GQ674@redacted.bos.redhat.com>

> > AndrewP said that the code is always LE, so why not just use
> > BFD_ENDIAN_LITTLE in this case, rather than go through
> > byte_order_for_code?
> > 
> 
> Seemed sensible to do what aarch64_analyze_prologue did, rather than
> hard code it... I'm happy one way or another though.

Hmmm, true. It doesn't matter all that much, I think, and yours has
indeed the advantate of consistency. I pushed your patch.

For future submissions, may I make a request? Would you mind including
the revision log as part of the email when sending your patches? I went
through all versions of the patch that were sent, and couldn't find
a description of the problem. We try to have those in the revision log
to avoid having to re-locate the patches in the mailing-list when
searching for the reasons behind the patch. The nice side-effect of
following this approach is that submitting the patch is just a matter
of "git send-email"-ing it, and for me, pushing the patch is just
a matter of "git am" + "git push" (with a possible update to add
the ChangeLog entries).

Thanks again!
-- 
Joel


  parent reply	other threads:[~2014-05-07 16:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-24 18:35 [PATCHv4] " Kyle McMartin
2014-04-24 18:39 ` Andrew Pinski
2014-04-24 18:51   ` Kyle McMartin
2014-04-30 16:04 ` [PATCHv5] " Kyle McMartin
2014-05-07 13:52   ` Joel Brobecker
2014-05-07 15:10     ` Kyle McMartin
2014-05-07 16:41       ` Andrew Pinski
2014-05-07 16:46       ` Joel Brobecker [this message]
2014-05-07 18:12         ` Kyle McMartin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140507164611.GD4063@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=kmcmarti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox