From: Kyle McMartin <kmcmarti@redhat.com>
To: Andrew Pinski <pinskia@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCHv4] aarch64: detect atomic sequences like other ll/sc architectures
Date: Thu, 24 Apr 2014 18:51:00 -0000 [thread overview]
Message-ID: <20140424185119.GJ7588@redacted.bos.redhat.com> (raw)
In-Reply-To: <CA+=Sn1mWke-_8O0-rJb5186MLZMOqtq46hBfNueW_v0BS13fzw@mail.gmail.com>
On Thu, Apr 24, 2014 at 11:38:57AM -0700, Andrew Pinski wrote:
> > + uint32_t insn = read_memory_unsigned_integer (loc, insn_size, byte_order);
>
>
> I think this is broken for big-endian aarch64. Instructions are
> always in little-endian mode so we really should be reading them
> always as little-endian.
>
You're right, I meant to do gdbarch_byte_order_for_code as is done
elsewhere in tdep for AArch64... will resend.
regards,
--Kyle
next prev parent reply other threads:[~2014-04-24 18:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 18:35 Kyle McMartin
2014-04-24 18:39 ` Andrew Pinski
2014-04-24 18:51 ` Kyle McMartin [this message]
2014-04-30 16:04 ` [PATCHv5] " Kyle McMartin
2014-05-07 13:52 ` Joel Brobecker
2014-05-07 15:10 ` Kyle McMartin
2014-05-07 16:41 ` Andrew Pinski
2014-05-07 16:46 ` Joel Brobecker
2014-05-07 18:12 ` Kyle McMartin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424185119.GJ7588@redacted.bos.redhat.com \
--to=kmcmarti@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pinskia@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox