From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3228 invoked by alias); 24 Apr 2014 18:51:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3217 invoked by uid 89); 24 Apr 2014 18:51:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 Apr 2014 18:51:24 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3OIpL6t027317 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 24 Apr 2014 14:51:22 -0400 Received: from redacted.bos.redhat.com ([10.18.17.143]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s3OIpJ6a018199 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Thu, 24 Apr 2014 14:51:21 -0400 Date: Thu, 24 Apr 2014 18:51:00 -0000 From: Kyle McMartin To: Andrew Pinski Cc: "gdb-patches@sourceware.org" , Joel Brobecker Subject: Re: [PATCHv4] aarch64: detect atomic sequences like other ll/sc architectures Message-ID: <20140424185119.GJ7588@redacted.bos.redhat.com> References: <20140424183510.GI7588@redacted.bos.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes X-SW-Source: 2014-04/txt/msg00507.txt.bz2 On Thu, Apr 24, 2014 at 11:38:57AM -0700, Andrew Pinski wrote: > > + uint32_t insn = read_memory_unsigned_integer (loc, insn_size, byte_order); > > > I think this is broken for big-endian aarch64. Instructions are > always in little-endian mode so we really should be reading them > always as little-endian. > You're right, I meant to do gdbarch_byte_order_for_code as is done elsewhere in tdep for AArch64... will resend. regards, --Kyle