From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: palves@redhat.com
Cc: gdb-patches@sourceware.org, ysato@users.sourceforge.jp
Subject: Re: [PATCH 2/2] H8/300: Fix pseudo registers reads/writes.
Date: Wed, 12 Feb 2014 12:59:00 -0000 [thread overview]
Message-ID: <201402121259.s1CCxStN019780@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <1392208927-15739-3-git-send-email-palves@redhat.com> (message from Pedro Alves on Wed, 12 Feb 2014 12:42:07 +0000)
> From: Pedro Alves <palves@redhat.com>
> Date: Wed, 12 Feb 2014 12:42:07 +0000
>
> shows the problem. The CCR pseudo register has type length of 1,
> while the corresponding CCR raw register has a length of 2 or 4
> (depending on mode). In
> sim/h8300/compile.c:sim_{fetch|store}_register we see that the sim
> also treats those raw registers (CCR/EXR) as 2 or 4 bytes length.
>
> gdb/
> 2014-02-12 Pedro Alves <palves@redhat.com>
>
> * h8300-tdep.c (pseudo_from_raw_register)
> (raw_from_pseudo_register): New functions.
> (h8300_pseudo_register_read, h8300_pseudo_register_write): Use
> them.
Since the whole point of the pseudo registers seems to be to handle
the size difference, this looks totally ok to me.
prev parent reply other threads:[~2014-02-12 12:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-01 12:43 [PATCH] h8300 "info registers" broken Yoshinori Sato
2014-02-04 19:38 ` Pedro Alves
2014-02-05 17:51 ` Yoshinori Sato
2014-02-05 17:59 ` Mark Kettenis
2014-02-08 18:36 ` Yoshinori Sato
2014-02-10 15:53 ` Pedro Alves
2014-02-11 10:29 ` Yoshinori Sato
2014-02-11 11:47 ` Pedro Alves
2014-02-11 13:11 ` Yoshinori Sato
2014-02-12 12:42 ` [PATCH 0/2] H8/300: Fix registers Pedro Alves
2014-02-12 12:42 ` [PATCH 1/2] H8/300: Fix gdb<->sim register mapping Pedro Alves
2014-02-12 12:42 ` [PATCH 2/2] H8/300: Fix pseudo registers reads/writes Pedro Alves
2014-02-12 12:59 ` Mark Kettenis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201402121259.s1CCxStN019780@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox