From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11183 invoked by alias); 12 Feb 2014 12:59:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11173 invoked by uid 89); 12 Feb 2014 12:59:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: glazunov.sibelius.xs4all.nl Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 12 Feb 2014 12:59:36 +0000 Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3) with ESMTP id s1CCxTlR026780; Wed, 12 Feb 2014 13:59:29 +0100 (CET) Received: (from kettenis@localhost) by glazunov.sibelius.xs4all.nl (8.14.5/8.14.3/Submit) id s1CCxStN019780; Wed, 12 Feb 2014 13:59:28 +0100 (CET) Date: Wed, 12 Feb 2014 12:59:00 -0000 Message-Id: <201402121259.s1CCxStN019780@glazunov.sibelius.xs4all.nl> From: Mark Kettenis To: palves@redhat.com CC: gdb-patches@sourceware.org, ysato@users.sourceforge.jp In-reply-to: <1392208927-15739-3-git-send-email-palves@redhat.com> (message from Pedro Alves on Wed, 12 Feb 2014 12:42:07 +0000) Subject: Re: [PATCH 2/2] H8/300: Fix pseudo registers reads/writes. References: <87y51hiyjt.wl%ysato@users.sourceforge.jp> <1392208927-15739-1-git-send-email-palves@redhat.com> <1392208927-15739-3-git-send-email-palves@redhat.com> X-SW-Source: 2014-02/txt/msg00406.txt.bz2 > From: Pedro Alves > Date: Wed, 12 Feb 2014 12:42:07 +0000 > > shows the problem. The CCR pseudo register has type length of 1, > while the corresponding CCR raw register has a length of 2 or 4 > (depending on mode). In > sim/h8300/compile.c:sim_{fetch|store}_register we see that the sim > also treats those raw registers (CCR/EXR) as 2 or 4 bytes length. > > gdb/ > 2014-02-12 Pedro Alves > > * h8300-tdep.c (pseudo_from_raw_register) > (raw_from_pseudo_register): New functions. > (h8300_pseudo_register_read, h8300_pseudo_register_write): Use > them. Since the whole point of the pseudo registers seems to be to handle the size difference, this looks totally ok to me.