From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: gdb-patches@sourceware.org
Subject: [PATCH] h8300 "info registers" broken
Date: Sat, 01 Feb 2014 12:43:00 -0000 [thread overview]
Message-ID: <8738k3j95o.wl%ysato@users.sourceforge.jp> (raw)
Following result in h8300-elf-gdb.
(gdb) info registers ccr
memory clobbered past end of allocated block
This cause of missing register size.
diff --git a/gdb/h8300-tdep.c b/gdb/h8300-tdep.c
index ffffbc9..a21f7de 100644
--- a/gdb/h8300-tdep.c
+++ b/gdb/h8300-tdep.c
@@ -946,7 +946,7 @@ h8300_register_name (struct gdbarch *gdbarch, int regno)
type is selected. */
static char *register_names[] = {
"r0", "r1", "r2", "r3", "r4", "r5", "r6",
- "sp", "", "pc", "cycles", "tick", "inst",
+ "sp", "ccr", "pc", "cycles", "tick", "inst",
"ccr", /* pseudo register */
};
if (regno < 0
@@ -963,7 +963,7 @@ h8300s_register_name (struct gdbarch *gdbarch, int regno)
{
static char *register_names[] = {
"er0", "er1", "er2", "er3", "er4", "er5", "er6",
- "sp", "", "pc", "cycles", "", "tick", "inst",
+ "sp", "ccr", "pc", "cycles", "exr", "tick", "inst",
"mach", "macl",
"ccr", "exr" /* pseudo registers */
};
@@ -981,7 +981,7 @@ h8300sx_register_name (struct gdbarch *gdbarch, int regno)
{
static char *register_names[] = {
"er0", "er1", "er2", "er3", "er4", "er5", "er6",
- "sp", "", "pc", "cycles", "", "tick", "inst",
+ "sp", "ccr", "pc", "cycles", "exr", "tick", "inst",
"mach", "macl", "sbr", "vbr",
"ccr", "exr" /* pseudo registers */
};
@@ -1136,9 +1136,9 @@ h8300_register_type (struct gdbarch *gdbarch, int regno)
case E_FP_REGNUM:
return builtin_type (gdbarch)->builtin_data_ptr;
default:
- if (regno == E_PSEUDO_CCR_REGNUM (gdbarch))
+ if (regno == E_PSEUDO_CCR_REGNUM (gdbarch) || regno == E_CCR_REGNUM)
return builtin_type (gdbarch)->builtin_uint8;
- else if (regno == E_PSEUDO_EXR_REGNUM (gdbarch))
+ else if (regno == E_PSEUDO_EXR_REGNUM (gdbarch) || regno == E_EXR_REGNUM)
return builtin_type (gdbarch)->builtin_uint8;
else if (is_h8300hmode (gdbarch))
return builtin_type (gdbarch)->builtin_int32;
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
next reply other threads:[~2014-02-01 12:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-01 12:43 Yoshinori Sato [this message]
2014-02-04 19:38 ` Pedro Alves
2014-02-05 17:51 ` Yoshinori Sato
2014-02-05 17:59 ` Mark Kettenis
2014-02-08 18:36 ` Yoshinori Sato
2014-02-10 15:53 ` Pedro Alves
2014-02-11 10:29 ` Yoshinori Sato
2014-02-11 11:47 ` Pedro Alves
2014-02-11 13:11 ` Yoshinori Sato
2014-02-12 12:42 ` [PATCH 0/2] H8/300: Fix registers Pedro Alves
2014-02-12 12:42 ` [PATCH 2/2] H8/300: Fix pseudo registers reads/writes Pedro Alves
2014-02-12 12:59 ` Mark Kettenis
2014-02-12 12:42 ` [PATCH 1/2] H8/300: Fix gdb<->sim register mapping Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8738k3j95o.wl%ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox