From: Joel Brobecker <brobecker@adacore.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Cc: 'Ulrich Weigand' <uweigand@de.ibm.com>, gdb-patches@sourceware.org
Subject: Re: RFA: Fix build regression on 32-bit hosts [Re: [RFA][PATCH v5 2/2] S/390: Add TDB regset]
Date: Mon, 16 Sep 2013 12:23:00 -0000 [thread overview]
Message-ID: <20130916122345.GA3132@adacore.com> (raw)
In-Reply-To: <003e01ceb2d0$c5051770$4f0f4650$@muller@ics-cnrs.unistra.fr>
> PS:I think that system includes should be banned
> in all files that are used for cross-debugging.
This is already the main idea, except that we cannot banish
all system includes. For instance, includes that are part of
the C standard are OK (ctype.h, stdint.h, stdarg.h, etc) are
fine. Others, such as dlfcn.h or sys/cygwin.h, on the other
hand, are not.
> Especially cases like <string.h> should be avoided as we do have
> common/gdb_string.h...
Agreed on this one.
--
Joel
next prev parent reply other threads:[~2013-09-16 12:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 15:15 [RFA][PATCH v5 0/2] S/390: Add TDB regset support Andreas Arnez
2013-09-11 15:29 ` [RFA][PATCH v5 1/2] S/390 regmap rework Andreas Arnez
2013-09-13 12:40 ` Ulrich Weigand
2013-09-11 15:30 ` [RFA][PATCH v5 2/2] S/390: Add TDB regset Andreas Arnez
2013-09-11 16:28 ` Eli Zaretskii
2013-09-11 16:55 ` Andreas Arnez
2013-09-11 16:59 ` Eli Zaretskii
2013-09-11 17:39 ` Andreas Arnez
2013-09-11 19:21 ` Eli Zaretskii
2013-09-13 12:42 ` Ulrich Weigand
2013-09-15 15:52 ` Build regression on 32-bit hosts [Re: [RFA][PATCH v5 2/2] S/390: Add TDB regset] Jan Kratochvil
2013-09-15 21:33 ` RFA: Fix build " Pierre Muller
2013-09-16 9:52 ` Ulrich Weigand
2013-09-16 11:35 ` Pierre Muller
2013-09-16 12:23 ` Joel Brobecker [this message]
2013-09-16 13:53 ` Eli Zaretskii
[not found] ` <38466.0263116986$1379331313@news.gmane.org>
2013-09-17 18:39 ` Tom Tromey
2013-09-16 10:43 ` Andreas Arnez
2013-09-12 15:36 ` [RFA][PATCH v5 0/2] S/390: Add TDB regset support Andreas Arnez
2013-09-13 14:19 ` Ulrich Weigand
2013-09-15 14:42 ` Pierre Muller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130916122345.GA3132@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox